* [PATCH] acpi/arm64: Mark next_platform_timer as __init
@ 2021-06-02 21:46 ` Kees Cook
0 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2021-06-02 21:46 UTC (permalink / raw)
To: Hanjun Guo
Cc: Kees Cook, Kefeng Wang, Lorenzo Pieralisi, Sudeep Holla,
Rafael J. Wysocki, Len Brown, linux-kernel, linux-acpi,
linux-arm-kernel
Fix section mismatch warning:
WARNING: modpost: vmlinux.o(.text.unlikely+0x95ac): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
The function next_platform_timer() references
the variable __initdata acpi_gtdt_desc.
This is often because next_platform_timer lacks a __initdata
annotation or the annotation of acpi_gtdt_desc is wrong.
Suggested-by: Hanjun Guo <guohanjun@huawei.com>
Link: https://lore.kernel.org/linux-acpi/20200508152653.157663-1-wangkefeng.wang@huawei.com/
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/acpi/arm64/gtdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
index 0a0a982f9c28..c3ad42470a7c 100644
--- a/drivers/acpi/arm64/gtdt.c
+++ b/drivers/acpi/arm64/gtdt.c
@@ -36,7 +36,7 @@ struct acpi_gtdt_descriptor {
static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata;
-static inline void *next_platform_timer(void *platform_timer)
+static __init void *next_platform_timer(void *platform_timer)
{
struct acpi_gtdt_header *gh = platform_timer;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] acpi/arm64: Mark next_platform_timer as __init
@ 2021-06-02 21:46 ` Kees Cook
0 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2021-06-02 21:46 UTC (permalink / raw)
To: Hanjun Guo
Cc: Kees Cook, Kefeng Wang, Lorenzo Pieralisi, Sudeep Holla,
Rafael J. Wysocki, Len Brown, linux-kernel, linux-acpi,
linux-arm-kernel
Fix section mismatch warning:
WARNING: modpost: vmlinux.o(.text.unlikely+0x95ac): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
The function next_platform_timer() references
the variable __initdata acpi_gtdt_desc.
This is often because next_platform_timer lacks a __initdata
annotation or the annotation of acpi_gtdt_desc is wrong.
Suggested-by: Hanjun Guo <guohanjun@huawei.com>
Link: https://lore.kernel.org/linux-acpi/20200508152653.157663-1-wangkefeng.wang@huawei.com/
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/acpi/arm64/gtdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
index 0a0a982f9c28..c3ad42470a7c 100644
--- a/drivers/acpi/arm64/gtdt.c
+++ b/drivers/acpi/arm64/gtdt.c
@@ -36,7 +36,7 @@ struct acpi_gtdt_descriptor {
static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata;
-static inline void *next_platform_timer(void *platform_timer)
+static __init void *next_platform_timer(void *platform_timer)
{
struct acpi_gtdt_header *gh = platform_timer;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] acpi/arm64: Mark next_platform_timer as __init
2021-06-02 21:46 ` Kees Cook
@ 2021-06-03 2:00 ` Hanjun Guo
-1 siblings, 0 replies; 4+ messages in thread
From: Hanjun Guo @ 2021-06-03 2:00 UTC (permalink / raw)
To: Kees Cook
Cc: Kefeng Wang, Lorenzo Pieralisi, Sudeep Holla, Rafael J. Wysocki,
Len Brown, linux-kernel, linux-acpi, linux-arm-kernel
On 2021/6/3 5:46, Kees Cook wrote:
> Fix section mismatch warning:
>
> WARNING: modpost: vmlinux.o(.text.unlikely+0x95ac): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
> The function next_platform_timer() references
> the variable __initdata acpi_gtdt_desc.
> This is often because next_platform_timer lacks a __initdata
> annotation or the annotation of acpi_gtdt_desc is wrong.
>
> Suggested-by: Hanjun Guo <guohanjun@huawei.com>
> Link: https://lore.kernel.org/linux-acpi/20200508152653.157663-1-wangkefeng.wang@huawei.com/
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> drivers/acpi/arm64/gtdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index 0a0a982f9c28..c3ad42470a7c 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -36,7 +36,7 @@ struct acpi_gtdt_descriptor {
>
> static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata;
>
> -static inline void *next_platform_timer(void *platform_timer)
> +static __init void *next_platform_timer(void *platform_timer)
> {
> struct acpi_gtdt_header *gh = platform_timer;
Thanks for the fix,
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] acpi/arm64: Mark next_platform_timer as __init
@ 2021-06-03 2:00 ` Hanjun Guo
0 siblings, 0 replies; 4+ messages in thread
From: Hanjun Guo @ 2021-06-03 2:00 UTC (permalink / raw)
To: Kees Cook
Cc: Kefeng Wang, Lorenzo Pieralisi, Sudeep Holla, Rafael J. Wysocki,
Len Brown, linux-kernel, linux-acpi, linux-arm-kernel
On 2021/6/3 5:46, Kees Cook wrote:
> Fix section mismatch warning:
>
> WARNING: modpost: vmlinux.o(.text.unlikely+0x95ac): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
> The function next_platform_timer() references
> the variable __initdata acpi_gtdt_desc.
> This is often because next_platform_timer lacks a __initdata
> annotation or the annotation of acpi_gtdt_desc is wrong.
>
> Suggested-by: Hanjun Guo <guohanjun@huawei.com>
> Link: https://lore.kernel.org/linux-acpi/20200508152653.157663-1-wangkefeng.wang@huawei.com/
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> drivers/acpi/arm64/gtdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index 0a0a982f9c28..c3ad42470a7c 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -36,7 +36,7 @@ struct acpi_gtdt_descriptor {
>
> static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata;
>
> -static inline void *next_platform_timer(void *platform_timer)
> +static __init void *next_platform_timer(void *platform_timer)
> {
> struct acpi_gtdt_header *gh = platform_timer;
Thanks for the fix,
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-03 2:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02 21:46 [PATCH] acpi/arm64: Mark next_platform_timer as __init Kees Cook
2021-06-02 21:46 ` Kees Cook
2021-06-03 2:00 ` Hanjun Guo
2021-06-03 2:00 ` Hanjun Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.