From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3905025663430362223==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [RFC PATCH mchinth] platform/x86: sw_copy_driver_interface_info_i can be static Date: Thu, 03 Jun 2021 11:44:33 +0800 Message-ID: <20210603034433.GA44263@7e00ed148fbe> In-Reply-To: <202106031111.jAttDVEM-lkp@intel.com> List-Id: --===============3905025663430362223== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable drivers/platform/x86/socwatch/sw_collector.c:85:33: warning: symbol 'sw_cop= y_driver_interface_info_i' was not declared. Should it be static? drivers/platform/x86/socwatch/sw_collector.c:116:5: warning: symbol 'sw_ini= t_driver_interface_info_i' was not declared. Should it be static? drivers/platform/x86/socwatch/sw_collector.c:138:5: warning: symbol 'sw_ini= t_ops_i' was not declared. Should it be static? drivers/platform/x86/socwatch/sw_collector.c:211:24: warning: symbol 'sw_al= loc_ops_i' was not declared. Should it be static? drivers/platform/x86/socwatch/sw_collector.c:323:6: warning: symbol 'sw_fre= e_driver_interface_info_i' was not declared. Should it be static? drivers/platform/x86/socwatch/sw_collector.c:329:6: warning: symbol 'sw_fre= e_ops_i' was not declared. Should it be static? drivers/platform/x86/socwatch/sw_collector.c:335:5: warning: symbol 'sw_res= et_driver_interface_info_i' was not declared. Should it be static? drivers/platform/x86/socwatch/sw_collector.c:453:6: warning: symbol 'sw_fre= e_collector_msg_i' was not declared. Should it be static? drivers/platform/x86/socwatch/sw_collector.c:459:6: warning: symbol 'sw_han= dle_per_cpu_msg_i' was not declared. Should it be static? Reported-by: kernel test robot Signed-off-by: kernel test robot --- sw_collector.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/platform/x86/socwatch/sw_collector.c b/drivers/platfor= m/x86/socwatch/sw_collector.c index 652d5af6113ba..212cf2b4e9645 100644 --- a/drivers/platform/x86/socwatch/sw_collector.c +++ b/drivers/platform/x86/socwatch/sw_collector.c @@ -82,7 +82,7 @@ const static struct sw_hw_ops *s_hw_ops; * Returns: a pointer to the newly allocated sw_driver_interface_info, * which is a copy of the version passed in via the info pointer. */ -struct sw_driver_interface_info * +static struct sw_driver_interface_info * sw_copy_driver_interface_info_i(const struct sw_driver_interface_info *inf= o) { size_t size; @@ -113,7 +113,7 @@ sw_copy_driver_interface_info_i(const struct sw_driver_= interface_info *info) return node; } = -int sw_init_driver_interface_info_i(struct sw_driver_interface_info *info) +static int sw_init_driver_interface_info_i(struct sw_driver_interface_info= *info) { /* * Do any initialization here. @@ -135,7 +135,7 @@ int sw_init_driver_interface_info_i(struct sw_driver_in= terface_info *info) return PW_SUCCESS; } = -int sw_init_ops_i(const struct sw_hw_ops **ops, +static int sw_init_ops_i(const struct sw_hw_ops **ops, const struct sw_driver_interface_info *info) { int i =3D 0; @@ -208,7 +208,7 @@ sw_alloc_collector_msg_i(const struct sw_driver_interfa= ce_info *info, return msg; } = -const struct sw_hw_ops **sw_alloc_ops_i(pw_u16_t num_io_descriptors) +static const struct sw_hw_ops **sw_alloc_ops_i(pw_u16_t num_io_descriptors) { size_t size =3D num_io_descriptors * sizeof(struct sw_hw_ops *); const struct sw_hw_ops **ops =3D sw_kmalloc(size, GFP_KERNEL); @@ -320,19 +320,19 @@ int sw_add_driver_info(void *list_head, return PW_SUCCESS; } = -void sw_free_driver_interface_info_i(struct sw_driver_interface_info *info) +static void sw_free_driver_interface_info_i(struct sw_driver_interface_inf= o *info) { if (info) sw_kfree(info); } = -void sw_free_ops_i(const struct sw_hw_ops **ops) +static void sw_free_ops_i(const struct sw_hw_ops **ops) { if (ops) sw_kfree(ops); } = -int sw_reset_driver_interface_info_i(struct sw_driver_interface_info *info) +static int sw_reset_driver_interface_info_i(struct sw_driver_interface_inf= o *info) { /* * Do any finalization here. @@ -450,13 +450,13 @@ int sw_handle_driver_io_descriptor( return PW_SUCCESS; } = -void sw_free_collector_msg_i(sw_driver_msg_t *msg) +static void sw_free_collector_msg_i(sw_driver_msg_t *msg) { if (msg) sw_kfree(msg); } = -void sw_handle_per_cpu_msg_i(void *info, enum sw_wakeup_action action) +static void sw_handle_per_cpu_msg_i(void *info, enum sw_wakeup_action acti= on) { /* * Basic algo: --===============3905025663430362223==--