From: Mark Brown <broonie@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] regulator: core: always use enable_delay when enabling regulators
Date: Thu, 3 Jun 2021 11:27:41 +0100 [thread overview]
Message-ID: <20210603102741.GA4257@sirena.org.uk> (raw)
In-Reply-To: <CAA8EJprEQcP3hzqSsq8jzoCzf0gvbWdnQtCEGBO5S3WJNUkYEQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
On Wed, Jun 02, 2021 at 04:14:35PM +0300, Dmitry Baryshkov wrote:
> On Thu, 20 May 2021 at 14:58, Mark Brown <broonie@kernel.org> wrote:
> > On Thu, May 20, 2021 at 01:12:24AM +0300, Dmitry Baryshkov wrote:
> > > Some regulators (e.g. fixed) do not have .enable callback per se, but
> > > use supply regulator and enable_delay. Do not return early from
> > > _regulator_do_enable in such cases, so that enable_delay is properly
> > > handled.
> > This doesn't seem like the right fix - if we didn't actually do anything
> > then we don't need to add a delay. We should only be doing this if some
> > parent regulator changed state.
> I have implemented this, but then it becomes too fragile. If the
> parent gets enabled for whatever reason just few us ago, the whole
> delay would be skipped.
This seems like a solvable problem, we can track what parents are doing
or teach parents about their children for example.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-03 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 22:12 [PATCH 1/2] regulator: core: resolve supply for boot-on/always-on regulators Dmitry Baryshkov
2021-05-19 22:12 ` [PATCH 2/2] regulator: core: always use enable_delay when enabling regulators Dmitry Baryshkov
2021-05-20 11:57 ` Mark Brown
2021-06-02 13:14 ` Dmitry Baryshkov
2021-06-03 10:27 ` Mark Brown [this message]
2021-05-20 21:08 ` (subset) [PATCH 1/2] regulator: core: resolve supply for boot-on/always-on regulators Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603102741.GA4257@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.