From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D85C47096 for ; Thu, 3 Jun 2021 12:30:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 480A3610CB for ; Thu, 3 Jun 2021 12:30:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229911AbhFCMbt (ORCPT ); Thu, 3 Jun 2021 08:31:49 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:47932 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229840AbhFCMbs (ORCPT ); Thu, 3 Jun 2021 08:31:48 -0400 Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6BFB51FD5C; Thu, 3 Jun 2021 12:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622723403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3uMdkzMw1KNWFmkp5TDgOr4+NxSoov+sUKA8B8+ulqI=; b=TcIN+EV9riNOgld2I7+jC7kHRJjBFnsoy/lk96yz/2Y4U8lgYPJScVfgPxvf+7Alvp5I22 WOIHaMCGtxv7bU3nzHjuEPsiON/GQC9Wc7e/+nyMYTVdrR7GRjYr9bVYX6WctHDJj4rrNb x7FyBL1+dGE/Q7F8uVZFtz5nUCQuo3c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622723403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3uMdkzMw1KNWFmkp5TDgOr4+NxSoov+sUKA8B8+ulqI=; b=hDY/gHFSys2PUUQWFRmDDYZF7pPyc3r++DwMnhT9OpN7OaMKyO5sAP8aJUJr7UtIATrPRk jitLWRggC9OGGnAQ== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id A588D118DD; Thu, 3 Jun 2021 12:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622723403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3uMdkzMw1KNWFmkp5TDgOr4+NxSoov+sUKA8B8+ulqI=; b=TcIN+EV9riNOgld2I7+jC7kHRJjBFnsoy/lk96yz/2Y4U8lgYPJScVfgPxvf+7Alvp5I22 WOIHaMCGtxv7bU3nzHjuEPsiON/GQC9Wc7e/+nyMYTVdrR7GRjYr9bVYX6WctHDJj4rrNb x7FyBL1+dGE/Q7F8uVZFtz5nUCQuo3c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622723403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3uMdkzMw1KNWFmkp5TDgOr4+NxSoov+sUKA8B8+ulqI=; b=hDY/gHFSys2PUUQWFRmDDYZF7pPyc3r++DwMnhT9OpN7OaMKyO5sAP8aJUJr7UtIATrPRk jitLWRggC9OGGnAQ== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id gsBMJUrLuGCiFwAALh3uQQ (envelope-from ); Thu, 03 Jun 2021 12:30:02 +0000 From: Claudio Fontana To: Peter Maydell , Paolo Bonzini , Eduardo Habkost , Siddharth Chandrasekaran , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Vitaly Kuznetsov Cc: Claudio Fontana , "Michael S . Tsirkin" , kvm@vger.kernel.org, Marcelo Tosatti , Richard Henderson , Cameron Esfahani , Roman Bolshakov , qemu-devel@nongnu.org Subject: [PATCH v2 0/2] Fixes for "Windows fails to boot" Date: Thu, 3 Jun 2021 14:29:59 +0200 Message-Id: <20210603123001.17843-1-cfontana@suse.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org v1 -> v2: * moved hyperv realizefn call before cpu expansion (Vitaly) * added more comments (Eduardo) * fixed references to commit ids (Eduardo) The combination of Commits: f5cc5a5c ("i386: split cpu accelerators from cpu.c"...) 30565f10 ("cpu: call AccelCPUClass::cpu_realizefn in"...) introduced two bugs that break cpu max and host in the refactoring, by running initializations in the wrong order. This small series of two patches is an attempt to correct the situation. Please provide your test results and feedback, thanks! Claudio Claudio Fontana (2): i386: reorder call to cpu_exec_realizefn in x86_cpu_realizefn i386: run accel_cpu_instance_init as instance_post_init target/i386/cpu.c | 89 +++++++++++++++++++++++++-------------- target/i386/kvm/kvm-cpu.c | 12 +++++- 2 files changed, 68 insertions(+), 33 deletions(-) -- 2.26.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D4FCC47082 for ; Thu, 3 Jun 2021 12:32:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04E02613E6 for ; Thu, 3 Jun 2021 12:32:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04E02613E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lomWR-0000bS-Oh for qemu-devel@archiver.kernel.org; Thu, 03 Jun 2021 08:32:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lomUA-0006nX-DX for qemu-devel@nongnu.org; Thu, 03 Jun 2021 08:30:06 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:42732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lomU8-00041Z-P3 for qemu-devel@nongnu.org; Thu, 03 Jun 2021 08:30:06 -0400 Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6BFB51FD5C; Thu, 3 Jun 2021 12:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622723403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3uMdkzMw1KNWFmkp5TDgOr4+NxSoov+sUKA8B8+ulqI=; b=TcIN+EV9riNOgld2I7+jC7kHRJjBFnsoy/lk96yz/2Y4U8lgYPJScVfgPxvf+7Alvp5I22 WOIHaMCGtxv7bU3nzHjuEPsiON/GQC9Wc7e/+nyMYTVdrR7GRjYr9bVYX6WctHDJj4rrNb x7FyBL1+dGE/Q7F8uVZFtz5nUCQuo3c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622723403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3uMdkzMw1KNWFmkp5TDgOr4+NxSoov+sUKA8B8+ulqI=; b=hDY/gHFSys2PUUQWFRmDDYZF7pPyc3r++DwMnhT9OpN7OaMKyO5sAP8aJUJr7UtIATrPRk jitLWRggC9OGGnAQ== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id A588D118DD; Thu, 3 Jun 2021 12:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622723403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3uMdkzMw1KNWFmkp5TDgOr4+NxSoov+sUKA8B8+ulqI=; b=TcIN+EV9riNOgld2I7+jC7kHRJjBFnsoy/lk96yz/2Y4U8lgYPJScVfgPxvf+7Alvp5I22 WOIHaMCGtxv7bU3nzHjuEPsiON/GQC9Wc7e/+nyMYTVdrR7GRjYr9bVYX6WctHDJj4rrNb x7FyBL1+dGE/Q7F8uVZFtz5nUCQuo3c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622723403; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3uMdkzMw1KNWFmkp5TDgOr4+NxSoov+sUKA8B8+ulqI=; b=hDY/gHFSys2PUUQWFRmDDYZF7pPyc3r++DwMnhT9OpN7OaMKyO5sAP8aJUJr7UtIATrPRk jitLWRggC9OGGnAQ== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id gsBMJUrLuGCiFwAALh3uQQ (envelope-from ); Thu, 03 Jun 2021 12:30:02 +0000 From: Claudio Fontana To: Peter Maydell , Paolo Bonzini , Eduardo Habkost , Siddharth Chandrasekaran , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Vitaly Kuznetsov Subject: [PATCH v2 0/2] Fixes for "Windows fails to boot" Date: Thu, 3 Jun 2021 14:29:59 +0200 Message-Id: <20210603123001.17843-1-cfontana@suse.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.29; envelope-from=cfontana@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, "Michael S . Tsirkin" , Marcelo Tosatti , Richard Henderson , qemu-devel@nongnu.org, Cameron Esfahani , Roman Bolshakov , Claudio Fontana Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" v1 -> v2: * moved hyperv realizefn call before cpu expansion (Vitaly) * added more comments (Eduardo) * fixed references to commit ids (Eduardo) The combination of Commits: f5cc5a5c ("i386: split cpu accelerators from cpu.c"...) 30565f10 ("cpu: call AccelCPUClass::cpu_realizefn in"...) introduced two bugs that break cpu max and host in the refactoring, by running initializations in the wrong order. This small series of two patches is an attempt to correct the situation. Please provide your test results and feedback, thanks! Claudio Claudio Fontana (2): i386: reorder call to cpu_exec_realizefn in x86_cpu_realizefn i386: run accel_cpu_instance_init as instance_post_init target/i386/cpu.c | 89 +++++++++++++++++++++++++-------------- target/i386/kvm/kvm-cpu.c | 12 +++++- 2 files changed, 68 insertions(+), 33 deletions(-) -- 2.26.2