From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF694C47082 for ; Thu, 3 Jun 2021 14:10:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B225E613B1 for ; Thu, 3 Jun 2021 14:10:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231366AbhFCOMA (ORCPT ); Thu, 3 Jun 2021 10:12:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230044AbhFCOL6 (ORCPT ); Thu, 3 Jun 2021 10:11:58 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 065D9C06174A for ; Thu, 3 Jun 2021 07:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DzJLzbuBdtLjC4lVWi0u5S27k9XDbTBq5eWguU0jgHE=; b=cjG7lTpuKtu9+we2S2BPSq8oj A4flU8iOuWDn8BYcrxd7V8EIByXULphhcLRDdx1iZqXomjc09jdgDEuAN3Nm6DY8vTaeaQERXUhQM az8S4JLqpD4dxyDpChkBmxxiIZw7oBLiyVbr4yQ7YPATOTDJ6jLOQTfU9INf5t0e84WVC7n5+7inR C9gkSznX7Q9jzut3N7+2xfIGlPGnTRf4dRORBm/5LFXNUOW2u2HJGJU83EqH8xcfAHf+URAef3+tb 74G0I+B3oqY+7iyC8V5UyBMR3D5ZPX0i/GKjjp2T7BaKB7IFqLWvQZ0QBtsofCTBBFFRe8qQ7tPX4 ekOExT5og==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44678) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loo2w-0002v7-6d; Thu, 03 Jun 2021 15:10:06 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1loo2v-0002Ba-8e; Thu, 03 Jun 2021 15:10:05 +0100 Date: Thu, 3 Jun 2021 15:10:05 +0100 From: "Russell King (Oracle)" To: Lee Jones Cc: Boris Ostrovsky , Guenter Roeck , Thierry Reding , arm@kernel.org, Arnd Bergmann , Olof Johansson , Stefan Agner , Wolfram Sang , Catalin Marinas , Lorenzo Pieralisi , linux-arm-kernel , open list , Stefano Stabellini Subject: Re: [PATCH 2/6] ARM: xen: Register with kernel restart handler Message-ID: <20210603141005.GV30436@shell.armlinux.org.uk> References: <20191015145147.1106247-1-thierry.reding@gmail.com> <20191015145147.1106247-3-thierry.reding@gmail.com> <20210603131124.GA1040254@roeck-us.net> <20210603133840.GB2435141@dell> <7a1cf301-ba99-1e01-c43e-53b53f4d3e04@oracle.com> <20210603135608.GU30436@shell.armlinux.org.uk> <20210603140301.GC2435141@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210603140301.GC2435141@dell> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 03, 2021 at 03:03:01PM +0100, Lee Jones wrote: > On Thu, 03 Jun 2021, Russell King (Oracle) wrote: > > > On Thu, Jun 03, 2021 at 09:48:59AM -0400, Boris Ostrovsky wrote: > > > On 6/3/21 9:38 AM, Lee Jones wrote: > > > > On Thu, 03 Jun 2021, Guenter Roeck wrote: > > > > > > > >> On Thu, Jun 03, 2021 at 01:43:36PM +0100, Lee Jones wrote: > > > >>> On Tue, 15 Oct 2019 at 15:52, Thierry Reding > > > >>> wrote: > > > >>> > > > >>>> From: Guenter Roeck > > > >>>> > > > >>>> Register with kernel restart handler instead of setting arm_pm_restart > > > >>>> directly. > > > >>>> > > > >>>> Select a high priority of 192 to ensure that default restart handlers > > > >>>> are replaced if Xen is running. > > > >>>> > > > >>>> Acked-by: Arnd Bergmann > > > >>>> Reviewed-by: Wolfram Sang > > > >>>> Reviewed-by: Stefano Stabellini > > > >>>> Signed-off-by: Guenter Roeck > > > >>>> Signed-off-by: Thierry Reding > > > >>>> --- > > > >>>> arch/arm/xen/enlighten.c | 12 ++++++++++-- > > > >>>> 1 file changed, 10 insertions(+), 2 deletions(-) > > > >>>> > > > >>> This patch does appear to be useful. > > > >>> > > > >>> Is this just being solved in downstream trees at the moment? > > > >>> > > > >>> It would be nice if we could relinquish people of this burden and get it > > > >>> into Mainline finally. > > > >>> > > > >> There must have been half a dozen attempts to send this patch series > > > >> upstream. I have tried, and others have tried. Each attempt failed with > > > >> someone else objecting for non-technical reasons (such as "we need more > > > >> reviews") or no reaction at all, and maintainers just don't pick it up. > > > > Looking at the *-by tag list above, I think we have enough quality > > > > reviews to take this forward. > > > > > > > >> So, yes, this patch series can only be found in downstream trees, > > > >> and it seems pointless to submit it yet again. > > > > IMHO, it's unfair to burden multiple downstream trees with this purely > > > > due to poor or nervy maintainership. Functionality as broadly useful > > > > as this should be merged and maintained in Mainline. > > > > > > > > OOI, who is blocking? As I see it, we have 2 of the key maintainers > > > > in the *-by list. With those on-board, it's difficult to envisage > > > > what the problem is. > > > > > > > > > Stefano (who is ARM Xen maintainer) left Citrix a while ago. He is at sstabellini@kernel.org (which I added to the CC line). > > > > Stefano already reviewed this patch, which is part of a larger series > > that primarily touches 32-bit ARM code, but also touches 64-bit ARM > > code as well. > > > > As I said in my previous reply, I don't see that there's any problem > > with getting these patches merged had the usual processes been > > followed - either ending up in the patch system, or the pull request > > being sent to me directly. > > > > Sadly, the pull request was sent to the arm-soc people excluding me, > > I happened to notice it and requested to see the patches that were > > being asked to be pulled (since I probably couldn't find them)... > > and it then took two further weeks before the patches were posted, > > which I then missed amongst all the other email. > > > > It's a process failure and unfortunate timing rather than anything > > malicious. > > Understood. > > Is there anything I can do to help this forward? > > I can either collect and re-submit the patches to the MLs if that > makes people's lives any easier. Or if one of the original submitters > wish to retain responsibility, I have no qualms with that either. I think at this point the usual applies - to make sure that they still apply to current kernels and don't cause any regressions. I would hope there won't be anything significant to invalidate the reviews already given. If that's the case, it should just be a matter of someone putting them in the patch system or send me a pull request. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1390C47082 for ; Thu, 3 Jun 2021 14:12:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84C32613B1 for ; Thu, 3 Jun 2021 14:12:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84C32613B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZgcXyE3JKbdIKFFSlL6Vu/pPlGjW2o/fz8iJrE1GFJs=; b=VlUyE/+bOetq8d NTsNwCxVLiGbjYVV53RaU4cwR7Jwf7M4rjv3p6Hb+CKWsCoWBxYU9q83xQWMfewFG+pjZeGvbwwL5 NGmDd0ytR1WyP/DYVm8leWm6kHbVJurOinvnfNPZlgdjHMzGbb9yxrzIZM8w7AKgyjYS4nDilrbyT HeA5VsJIMcnDxhBxF5RsUXYPgtwVdeKTIFm9ecv7PO1PQVgj4n1oDSi9UdYIl1rHNVlns4ECwyEbS X8ECbMBm05ZGAtu6DHWFYmO4LSZFr5qEm2/H1vQZ9fN1f1eoY9TwFteZY8lgXfCVopP4EfwrtSusY 1DzI9mrxVXjdtjCT3Bbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loo3B-00947G-VS; Thu, 03 Jun 2021 14:10:22 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loo35-00946K-Pm for linux-arm-kernel@lists.infradead.org; Thu, 03 Jun 2021 14:10:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DzJLzbuBdtLjC4lVWi0u5S27k9XDbTBq5eWguU0jgHE=; b=cjG7lTpuKtu9+we2S2BPSq8oj A4flU8iOuWDn8BYcrxd7V8EIByXULphhcLRDdx1iZqXomjc09jdgDEuAN3Nm6DY8vTaeaQERXUhQM az8S4JLqpD4dxyDpChkBmxxiIZw7oBLiyVbr4yQ7YPATOTDJ6jLOQTfU9INf5t0e84WVC7n5+7inR C9gkSznX7Q9jzut3N7+2xfIGlPGnTRf4dRORBm/5LFXNUOW2u2HJGJU83EqH8xcfAHf+URAef3+tb 74G0I+B3oqY+7iyC8V5UyBMR3D5ZPX0i/GKjjp2T7BaKB7IFqLWvQZ0QBtsofCTBBFFRe8qQ7tPX4 ekOExT5og==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44678) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loo2w-0002v7-6d; Thu, 03 Jun 2021 15:10:06 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1loo2v-0002Ba-8e; Thu, 03 Jun 2021 15:10:05 +0100 Date: Thu, 3 Jun 2021 15:10:05 +0100 From: "Russell King (Oracle)" To: Lee Jones Cc: Boris Ostrovsky , Guenter Roeck , Thierry Reding , arm@kernel.org, Arnd Bergmann , Olof Johansson , Stefan Agner , Wolfram Sang , Catalin Marinas , Lorenzo Pieralisi , linux-arm-kernel , open list , Stefano Stabellini Subject: Re: [PATCH 2/6] ARM: xen: Register with kernel restart handler Message-ID: <20210603141005.GV30436@shell.armlinux.org.uk> References: <20191015145147.1106247-1-thierry.reding@gmail.com> <20191015145147.1106247-3-thierry.reding@gmail.com> <20210603131124.GA1040254@roeck-us.net> <20210603133840.GB2435141@dell> <7a1cf301-ba99-1e01-c43e-53b53f4d3e04@oracle.com> <20210603135608.GU30436@shell.armlinux.org.uk> <20210603140301.GC2435141@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210603140301.GC2435141@dell> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210603_071015_866915_AD62599E X-CRM114-Status: GOOD ( 45.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 03, 2021 at 03:03:01PM +0100, Lee Jones wrote: > On Thu, 03 Jun 2021, Russell King (Oracle) wrote: > > > On Thu, Jun 03, 2021 at 09:48:59AM -0400, Boris Ostrovsky wrote: > > > On 6/3/21 9:38 AM, Lee Jones wrote: > > > > On Thu, 03 Jun 2021, Guenter Roeck wrote: > > > > > > > >> On Thu, Jun 03, 2021 at 01:43:36PM +0100, Lee Jones wrote: > > > >>> On Tue, 15 Oct 2019 at 15:52, Thierry Reding > > > >>> wrote: > > > >>> > > > >>>> From: Guenter Roeck > > > >>>> > > > >>>> Register with kernel restart handler instead of setting arm_pm_restart > > > >>>> directly. > > > >>>> > > > >>>> Select a high priority of 192 to ensure that default restart handlers > > > >>>> are replaced if Xen is running. > > > >>>> > > > >>>> Acked-by: Arnd Bergmann > > > >>>> Reviewed-by: Wolfram Sang > > > >>>> Reviewed-by: Stefano Stabellini > > > >>>> Signed-off-by: Guenter Roeck > > > >>>> Signed-off-by: Thierry Reding > > > >>>> --- > > > >>>> arch/arm/xen/enlighten.c | 12 ++++++++++-- > > > >>>> 1 file changed, 10 insertions(+), 2 deletions(-) > > > >>>> > > > >>> This patch does appear to be useful. > > > >>> > > > >>> Is this just being solved in downstream trees at the moment? > > > >>> > > > >>> It would be nice if we could relinquish people of this burden and get it > > > >>> into Mainline finally. > > > >>> > > > >> There must have been half a dozen attempts to send this patch series > > > >> upstream. I have tried, and others have tried. Each attempt failed with > > > >> someone else objecting for non-technical reasons (such as "we need more > > > >> reviews") or no reaction at all, and maintainers just don't pick it up. > > > > Looking at the *-by tag list above, I think we have enough quality > > > > reviews to take this forward. > > > > > > > >> So, yes, this patch series can only be found in downstream trees, > > > >> and it seems pointless to submit it yet again. > > > > IMHO, it's unfair to burden multiple downstream trees with this purely > > > > due to poor or nervy maintainership. Functionality as broadly useful > > > > as this should be merged and maintained in Mainline. > > > > > > > > OOI, who is blocking? As I see it, we have 2 of the key maintainers > > > > in the *-by list. With those on-board, it's difficult to envisage > > > > what the problem is. > > > > > > > > > Stefano (who is ARM Xen maintainer) left Citrix a while ago. He is at sstabellini@kernel.org (which I added to the CC line). > > > > Stefano already reviewed this patch, which is part of a larger series > > that primarily touches 32-bit ARM code, but also touches 64-bit ARM > > code as well. > > > > As I said in my previous reply, I don't see that there's any problem > > with getting these patches merged had the usual processes been > > followed - either ending up in the patch system, or the pull request > > being sent to me directly. > > > > Sadly, the pull request was sent to the arm-soc people excluding me, > > I happened to notice it and requested to see the patches that were > > being asked to be pulled (since I probably couldn't find them)... > > and it then took two further weeks before the patches were posted, > > which I then missed amongst all the other email. > > > > It's a process failure and unfortunate timing rather than anything > > malicious. > > Understood. > > Is there anything I can do to help this forward? > > I can either collect and re-submit the patches to the MLs if that > makes people's lives any easier. Or if one of the original submitters > wish to retain responsibility, I have no qualms with that either. I think at this point the usual applies - to make sure that they still apply to current kernels and don't cause any regressions. I would hope there won't be anything significant to invalidate the reviews already given. If that's the case, it should just be a matter of someone putting them in the patch system or send me a pull request. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel