From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FA3CC47096 for ; Thu, 3 Jun 2021 16:41:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4493A60230 for ; Thu, 3 Jun 2021 16:41:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4493A60230 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB0466F4E1; Thu, 3 Jun 2021 16:41:24 +0000 (UTC) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B7576F4CF for ; Thu, 3 Jun 2021 16:41:23 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id f2so6491348wri.11 for ; Thu, 03 Jun 2021 09:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pnUIa0sFyDkR/8t0TailNKYrmyNBbS9VS6vHPr+XJFM=; b=Aa7AZGtw63BnkaMzv6wcrRiI+/ZHWYm+GBIdIGkUYQ0xUnIlkN9wjTywEz4cVTRhqV Jadm7zaJVtCW7YAUHtMJeZIjVyzVO0zs7KxB/cDeBF9QvU79ks1AjFFcBLaA7hOS+6wu 7LijeKsrhygvieIIb6URYzDI+TbdMychlzrAg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pnUIa0sFyDkR/8t0TailNKYrmyNBbS9VS6vHPr+XJFM=; b=q/Ic75Ksi5Ku/6PSGFL/ZLC40WGP/5uuQUH8deDjGtfcO3MXfNC/qcPTLdSUhhMxJd MwE1iDiKfjZcJdOmrgmIxTn0UL9YFMUVstURg0KaHUwCodDdTrFiBxI8hJ88lqgf2MHY 5u9TzMbkTN9TQ2c9yokxqad4wmsv+ZcwXnIURi+n5hBqOGe5ZlyaWCjbfPYKSdv8iNfY gV2c093PVxGoC61rCXfaARhwrFmI57zjksbWhVWl8ZKONFqv+tuy4OheOe6pWvLW1oMG ptY4P72t4PlFn++ly2J3ATlMWFS5JKPwJ3lCanNzJPVTIKPmqpbAcOvglmnP9SWsRwHi wsFQ== X-Gm-Message-State: AOAM532PaSiBWzfVs82ea3m4eEMpYSVQHnUehjF7Yi5kpLUjMvFLlyvE AuGAsUdHTZOLtFgk0/RnYjZF+w== X-Google-Smtp-Source: ABdhPJx2EW93bSROSlwL/SPbtZuKGb5rUHHCkWPYvtz96a8qSRqJB48oEvTXkZHA8oMhCV/36GSEuQ== X-Received: by 2002:adf:ea4c:: with SMTP id j12mr856222wrn.64.1622738481941; Thu, 03 Jun 2021 09:41:21 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id s28sm4992683wra.54.2021.06.03.09.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 09:41:21 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Subject: [PATCH v3 3/4] drm/shmem-helper: Align to page size in dumb_create Date: Thu, 3 Jun 2021 18:41:12 +0200 Message-Id: <20210603164113.1433476-4-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210603164113.1433476-1-daniel.vetter@ffwll.ch> References: <20210603164113.1433476-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , DRI Development , Thomas Zimmermann , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" shmem helpers seem a bit sloppy here by automatically rounding up when actually creating the buffer, which results in under-reporting of what we actually have. Caught by igt/vgem_basic tests. Acked-by: Thomas Zimmermann Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/drm_gem_shmem_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index 11edd54f0580..296ab1b7c07f 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -505,13 +505,13 @@ int drm_gem_shmem_dumb_create(struct drm_file *file, struct drm_device *dev, if (!args->pitch || !args->size) { args->pitch = min_pitch; - args->size = args->pitch * args->height; + args->size = PAGE_ALIGN(args->pitch * args->height); } else { /* ensure sane minimum values */ if (args->pitch < min_pitch) args->pitch = min_pitch; if (args->size < args->pitch * args->height) - args->size = args->pitch * args->height; + args->size = PAGE_ALIGN(args->pitch * args->height); } shmem = drm_gem_shmem_create_with_handle(file, dev, args->size, &args->handle); -- 2.31.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EBFDC47082 for ; Thu, 3 Jun 2021 16:41:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D20B8610A8 for ; Thu, 3 Jun 2021 16:41:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D20B8610A8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 94D206F4F9; Thu, 3 Jun 2021 16:41:26 +0000 (UTC) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D0496F4CA for ; Thu, 3 Jun 2021 16:41:23 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id y7so1888138wrh.7 for ; Thu, 03 Jun 2021 09:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pnUIa0sFyDkR/8t0TailNKYrmyNBbS9VS6vHPr+XJFM=; b=Aa7AZGtw63BnkaMzv6wcrRiI+/ZHWYm+GBIdIGkUYQ0xUnIlkN9wjTywEz4cVTRhqV Jadm7zaJVtCW7YAUHtMJeZIjVyzVO0zs7KxB/cDeBF9QvU79ks1AjFFcBLaA7hOS+6wu 7LijeKsrhygvieIIb6URYzDI+TbdMychlzrAg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pnUIa0sFyDkR/8t0TailNKYrmyNBbS9VS6vHPr+XJFM=; b=H1sVwU4/KWBqm2/iJsN2Q8VyaP25AUG+l4+qpIkwok/vt40pQlM+54jmgbJtfoZI4b 5ZCknlm1k4u/ZhDYYaAQX1wJNe+a772xWmq7sKCW5sDOlYw2/ybTO6+QkIUD3Fx1aGbK dtRKRuCXygTYDKxNt1VzcPQK27ROzVXbCV9L26RKd9VDlxnIAeULqZelo4Jlk+WU2S3c RP8mUndZiLJ5LfU8sKh65b98dG/2rfoGvkl0DgV8Q9YTHtOr6rHvsPEgC/ThVj/zEaRK sp12ZCQ+I4ksTUwSsHH3KAgomD4lmxw3cX36GaM4xWiOWQK5Eq5LMErCfXFDnfKhmTnV 59GQ== X-Gm-Message-State: AOAM531yZC4h8yKkRZsvaeNigV+bfycnj5tlyrj5Zr+9iZsMzu07zxe+ gHjc2Yhi1SePnQip404SatyyTM4fLwyZtQ== X-Google-Smtp-Source: ABdhPJx2EW93bSROSlwL/SPbtZuKGb5rUHHCkWPYvtz96a8qSRqJB48oEvTXkZHA8oMhCV/36GSEuQ== X-Received: by 2002:adf:ea4c:: with SMTP id j12mr856222wrn.64.1622738481941; Thu, 03 Jun 2021 09:41:21 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id s28sm4992683wra.54.2021.06.03.09.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 09:41:21 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Date: Thu, 3 Jun 2021 18:41:12 +0200 Message-Id: <20210603164113.1433476-4-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210603164113.1433476-1-daniel.vetter@ffwll.ch> References: <20210603164113.1433476-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v3 3/4] drm/shmem-helper: Align to page size in dumb_create X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , Maxime Ripard , DRI Development , Thomas Zimmermann , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" shmem helpers seem a bit sloppy here by automatically rounding up when actually creating the buffer, which results in under-reporting of what we actually have. Caught by igt/vgem_basic tests. Acked-by: Thomas Zimmermann Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter --- drivers/gpu/drm/drm_gem_shmem_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index 11edd54f0580..296ab1b7c07f 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -505,13 +505,13 @@ int drm_gem_shmem_dumb_create(struct drm_file *file, struct drm_device *dev, if (!args->pitch || !args->size) { args->pitch = min_pitch; - args->size = args->pitch * args->height; + args->size = PAGE_ALIGN(args->pitch * args->height); } else { /* ensure sane minimum values */ if (args->pitch < min_pitch) args->pitch = min_pitch; if (args->size < args->pitch * args->height) - args->size = args->pitch * args->height; + args->size = PAGE_ALIGN(args->pitch * args->height); } shmem = drm_gem_shmem_create_with_handle(file, dev, args->size, &args->handle); -- 2.31.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx