From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EEAAC47096 for ; Thu, 3 Jun 2021 15:19:03 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4197E60FF0 for ; Thu, 3 Jun 2021 15:19:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4197E60FF0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nic.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5B68982F47; Thu, 3 Jun 2021 17:18:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="uNn6OC9v"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5756182FBE; Thu, 3 Jun 2021 17:18:57 +0200 (CEST) Received: from mail.nic.cz (lists.nic.cz [217.31.204.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DD4A682F47 for ; Thu, 3 Jun 2021 17:18:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from dellmb (unknown [IPv6:2001:1488:fffe:6:8747:7254:5571:3010]) by mail.nic.cz (Postfix) with ESMTPSA id 77A40140A87; Thu, 3 Jun 2021 17:18:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1622733531; bh=s38+/JTfAxiYD6saMIDd6XtsF3fzN2B4Ie8YrSesL3U=; h=Date:From:To; b=uNn6OC9vToZi3H2eHvm/vig0KnFqeEu+whT/pZqN7pwqquMKHPhPY7ufyZ5SmideO BZY9vIi2pW4LUHGMvgtx9nH9CLE0ERggiGI4es9bh79aomK3RlmNb6csQ9KBFZ7CRu KnyDGj6ZKa7YOlv4faItkTy44sDkbliBUpdXJzwc= Date: Thu, 3 Jun 2021 17:18:51 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Stefan Roese , u-boot@lists.denx.de Cc: Pali =?UTF-8?B?Um9ow6Fy?= Subject: Re: [PATCH u-boot-marvell 2/7] arm: mvebu: turris_mox: add support for board rescue mode Message-ID: <20210603171851.0394786f@dellmb> In-Reply-To: <20210602171001.29614-3-marek.behun@nic.cz> References: <20210602171001.29614-1-marek.behun@nic.cz> <20210602171001.29614-3-marek.behun@nic.cz> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On Wed, 2 Jun 2021 19:09:56 +0200 Marek Beh=C3=BAn wrote: > +#define TURRIS_MOX_BOOTCMD_RESCUE \ > + "setenv bootargs \"console=3DttyMV0,115200 " \ > + "earlycon=3Dar3700_uart,0xd0012000\" && " \ > + "sf probe && " \ > + "sf read ${kernel_addr_r} 0x190000 && " \ > + "lzmadec ${kernel_addr_r} ${ramdisk_addr_r} && " \ > + "bootm ${ramdisk_addr_r}" OMG, we should use constants for addresses here instead of ${kernel_addr_r} and ${ramdisk_addr_r}, in case user changes or removed this variables. I will update this in v2. > + > #define CONFIG_EXTRA_ENV_SETTINGS \ > "scriptaddr=3D0x4d00000\0" \ > "pxefile_addr_r=3D0x4e00000\0" \ > "fdt_addr_r=3D0x4f00000\0" \ > "kernel_addr_r=3D0x5000000\0" \ > "ramdisk_addr_r=3D0x8000000\0" \ > + "bootcmd_rescue=3D" TURRIS_MOX_BOOTCMD_RESCUE "\0" \ > BOOTENV > =20 > #endif /* _CONFIG_TURRIS_MOX_H */