Re: [PATCH V7 for-next 3/3] RDMA/bnxt_re: update ABI to pass wqe-mode to user space

From: Jason Gunthorpe <jgg@nvidia.com>
To: Devesh Sharma <devesh.sharma@broadcom.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH V7 for-next 3/3] RDMA/bnxt_re: update ABI to pass wqe-mode to user space
Date: Thu, 3 Jun 2021 16:58:09 -0300	[thread overview]
Message-ID: <20210603195809.GA322627@nvidia.com> (raw)
In-Reply-To: <20210603131534.982257-4-devesh.sharma@broadcom.com>

On Thu, Jun 03, 2021 at 06:45:34PM +0530, Devesh Sharma wrote:
> Changing ucontext ABI response structure to pass wqe_mode
> to user library.
> A flag in comp_mask has been set to indicate presence of
> wqe_mode.
> 
> Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
>  drivers/infiniband/hw/bnxt_re/ib_verbs.c | 3 +++
>  include/uapi/rdma/bnxt_re-abi.h          | 5 ++++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> index a113d8d9e9ed..5955713234cb 100644
> +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> @@ -3882,6 +3882,9 @@ int bnxt_re_alloc_ucontext(struct ib_ucontext *ctx, struct ib_udata *udata)
>  	resp.max_cqd = dev_attr->max_cq_wqes;
>  	resp.rsvd    = 0;
>  
> +	resp.comp_mask |= BNXT_RE_UCNTX_CMASK_HAVE_MODE;
> +	resp.mode = rdev->chip_ctx->modes.wqe_mode;

The enum for this value is not in bnxt_re-abi.h and needs to be moved
there if you are going to start using it as uABI

In fact it looks like several of the things in
providers/bnxt_re/bnxt_re-abi.h needs to be moved to the kernel ABI
header and harmonized with the kernel driver.

Jason