From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED7CFC47096 for ; Thu, 3 Jun 2021 20:12:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D486E611C9 for ; Thu, 3 Jun 2021 20:12:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230157AbhFCUNx (ORCPT ); Thu, 3 Jun 2021 16:13:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:40442 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230052AbhFCUNr (ORCPT ); Thu, 3 Jun 2021 16:13:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 615936140F; Thu, 3 Jun 2021 20:12:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622751122; bh=YSrDFqeX1SRtC4e4s2UzUUYnUf4jnY6M9JUal4Hw8s4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d277b87svp7PTwWaA+vreitWyi4A477o2zbyEDN1rSKRzTyEJJbr0540MI/z5DRpH 2FQb0twLKMrvIoHj6D65Cp42LmvehPkJ4EwuJrNq1Dpu+u3gA9K+IdyJ4UP08o+xiC oMJU5HXiX7EgjTH72IkSjEbmyBob/8D3iCXvPXNKKCyLfsVfGz2FTXmNFq77pfUUNi I0jxyy+MWK00G0O4tR/+D6E+angunaXRgExfebS2O25E6Js+g6TtAjI/D/AlYsudpv 3ffY8Gv/UvtsOHeIM7TPvz1+yvZP0OLyeaCHtqAX//wDgk5QteW0aaKBzyHQy4jyFe 2PJue75Sxz5oA== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Tariq Toukan , Lama Kayal , Saeed Mahameed Subject: [net-next 06/10] net/mlx5e: Zero-init DIM structures Date: Thu, 3 Jun 2021 13:11:51 -0700 Message-Id: <20210603201155.109184-7-saeed@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210603201155.109184-1-saeed@kernel.org> References: <20210603201155.109184-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Lama Kayal Initialize structs to avoid unexpected behavior. No immediate issue in current code, structs are return values, it's safer to initialize. Signed-off-by: Lama Kayal Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/params.c b/drivers/net/ethernet/mellanox/mlx5/core/en/params.c index f410c1268422..69cdc4e41a46 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/params.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/params.c @@ -201,7 +201,7 @@ int mlx5e_validate_params(struct mlx5_core_dev *mdev, struct mlx5e_params *param static struct dim_cq_moder mlx5e_get_def_tx_moderation(u8 cq_period_mode) { - struct dim_cq_moder moder; + struct dim_cq_moder moder = {}; moder.cq_period_mode = cq_period_mode; moder.pkts = MLX5E_PARAMS_DEFAULT_TX_CQ_MODERATION_PKTS; @@ -214,7 +214,7 @@ static struct dim_cq_moder mlx5e_get_def_tx_moderation(u8 cq_period_mode) static struct dim_cq_moder mlx5e_get_def_rx_moderation(u8 cq_period_mode) { - struct dim_cq_moder moder; + struct dim_cq_moder moder = {}; moder.cq_period_mode = cq_period_mode; moder.pkts = MLX5E_PARAMS_DEFAULT_RX_CQ_MODERATION_PKTS; -- 2.31.1