All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
	Saeed Mahameed <saeedm@nvidia.com>
Subject: [net-next 07/10] net/mlx5e: RX, Re-place page pool numa node change logic
Date: Thu,  3 Jun 2021 13:11:52 -0700	[thread overview]
Message-ID: <20210603201155.109184-8-saeed@kernel.org> (raw)
In-Reply-To: <20210603201155.109184-1-saeed@kernel.org>

From: Tariq Toukan <tariqt@nvidia.com>

Move the logic that updates the page pool upon changes in numa node.
Before this patch, logic was placed in the RX polling function, being
called also when no RX traffic, wasting cpu cycles.  Here we move it to
the RX post_wqes function, to be called only when new RX descriptors are
going to be allocated.

Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
index e88429356018..3c65fd0bcf31 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
@@ -579,6 +579,9 @@ INDIRECT_CALLABLE_SCOPE bool mlx5e_post_rx_wqes(struct mlx5e_rq *rq)
 	if (mlx5_wq_cyc_missing(wq) < wqe_bulk)
 		return false;
 
+	if (rq->page_pool)
+		page_pool_nid_changed(rq->page_pool, numa_mem_id());
+
 	do {
 		u16 head = mlx5_wq_cyc_get_head(wq);
 
@@ -734,6 +737,9 @@ INDIRECT_CALLABLE_SCOPE bool mlx5e_post_rx_mpwqes(struct mlx5e_rq *rq)
 	if (likely(missing < UMR_WQE_BULK))
 		return false;
 
+	if (rq->page_pool)
+		page_pool_nid_changed(rq->page_pool, numa_mem_id());
+
 	head = rq->mpwqe.actual_wq_head;
 	i = missing;
 	do {
@@ -1555,9 +1561,6 @@ int mlx5e_poll_rx_cq(struct mlx5e_cq *cq, int budget)
 	if (unlikely(!test_bit(MLX5E_RQ_STATE_ENABLED, &rq->state)))
 		return 0;
 
-	if (rq->page_pool)
-		page_pool_nid_changed(rq->page_pool, numa_mem_id());
-
 	if (rq->cqd.left) {
 		work_done += mlx5e_decompress_cqes_cont(rq, cqwq, 0, budget);
 		if (work_done >= budget)
-- 
2.31.1


  parent reply	other threads:[~2021-06-03 20:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 20:11 [pull request][net-next 00/10] mlx5 updates 2021-06-03 Saeed Mahameed
2021-06-03 20:11 ` [net-next 01/10] mlx5: count all link events Saeed Mahameed
2021-06-03 22:30   ` patchwork-bot+netdevbpf
2021-06-03 20:11 ` [net-next 02/10] net/mlx5: Fix duplicate included vhca_event.h Saeed Mahameed
2021-06-03 20:11 ` [net-next 03/10] net/mlx5: check for allocation failure in mlx5_ft_pool_init() Saeed Mahameed
2021-06-03 20:11 ` [net-next 04/10] net/mlx5e: Remove the repeated declaration Saeed Mahameed
2021-06-03 20:11 ` [net-next 05/10] net/mlx5e: IPoIB, Add support for NDR speed Saeed Mahameed
2021-06-03 20:11 ` [net-next 06/10] net/mlx5e: Zero-init DIM structures Saeed Mahameed
2021-06-03 20:11 ` Saeed Mahameed [this message]
2021-06-03 20:11 ` [net-next 08/10] net/mlx5e: Disable TX MPWQE in kdump mode Saeed Mahameed
2021-06-03 20:11 ` [net-next 09/10] net/mlx5e: Disable TLS device offload " Saeed Mahameed
2021-06-03 20:11 ` [net-next 10/10] net/mlx5e: Remove unreachable code in mlx5e_xmit() Saeed Mahameed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210603201155.109184-8-saeed@kernel.org \
    --to=saeed@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.