All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2] sched/fair: Correctly insert cfs_rq's to list on unthrottle
Date: Thu, 03 Jun 2021 22:39:49 +0800	[thread overview]
Message-ID: <202106032238.nLLExUou-lkp@intel.com> (raw)
In-Reply-To: <20210603113847.163512-1-odin@uged.al>

[-- Attachment #1: Type: text/plain, Size: 2668 bytes --]

Hi Odin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on tip/master linux/master linus/master v5.13-rc4 next-20210603]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Odin-Ugedal/sched-fair-Correctly-insert-cfs_rq-s-to-list-on-unthrottle/20210603-194311
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 858f9e11be8855ed62cb97e58174515da595c76b
config: h8300-randconfig-r001-20210603 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/fd98f41f84acfad0ad1c7d1eb553807e8d1e0b9b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Odin-Ugedal/sched-fair-Correctly-insert-cfs_rq-s-to-list-on-unthrottle/20210603-194311
        git checkout fd98f41f84acfad0ad1c7d1eb553807e8d1e0b9b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/sched/fair.c: In function 'tg_unthrottle_up':
>> kernel/sched/fair.c:4704:13: error: 'struct cfs_rq' has no member named 'tg_load_avg_contrib'
    4704 |   if (cfs_rq->tg_load_avg_contrib || cfs_rq->nr_running)
         |             ^~


vim +4704 kernel/sched/fair.c

  4689	
  4690	static int tg_unthrottle_up(struct task_group *tg, void *data)
  4691	{
  4692		struct rq *rq = data;
  4693		struct cfs_rq *cfs_rq = tg->cfs_rq[cpu_of(rq)];
  4694	
  4695		cfs_rq->throttle_count--;
  4696		if (!cfs_rq->throttle_count) {
  4697			cfs_rq->throttled_clock_task_time += rq_clock_task(rq) -
  4698						     cfs_rq->throttled_clock_task;
  4699	
  4700			/*
  4701			 * Add cfs_rq with tg load avg contribution or one or more
  4702			 * already running entities to the list
  4703			 */
> 4704			if (cfs_rq->tg_load_avg_contrib || cfs_rq->nr_running)
  4705				list_add_leaf_cfs_rq(cfs_rq);
  4706		}
  4707	
  4708		return 0;
  4709	}
  4710	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 20340 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Odin Ugedal <odin-RObV4cXtwVA@public.gmane.org>,
	Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Juri Lelli <juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Vincent Guittot
	<vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Dietmar Eggemann <dietmar.eggemann-5wv7dgnIgG8@public.gmane.org>,
	Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>,
	Ben Segall <bsegall-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Mel Gorman <mgorman-l3A5Bk7waGM@public.gmane.org>,
	Daniel Bristot de Oliveira
	<bristot-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] sched/fair: Correctly insert cfs_rq's to list on unthrottle
Date: Thu, 3 Jun 2021 22:39:49 +0800	[thread overview]
Message-ID: <202106032238.nLLExUou-lkp@intel.com> (raw)
In-Reply-To: <20210603113847.163512-1-odin-RObV4cXtwVA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 2660 bytes --]

Hi Odin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on tip/master linux/master linus/master v5.13-rc4 next-20210603]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Odin-Ugedal/sched-fair-Correctly-insert-cfs_rq-s-to-list-on-unthrottle/20210603-194311
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 858f9e11be8855ed62cb97e58174515da595c76b
config: h8300-randconfig-r001-20210603 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/fd98f41f84acfad0ad1c7d1eb553807e8d1e0b9b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Odin-Ugedal/sched-fair-Correctly-insert-cfs_rq-s-to-list-on-unthrottle/20210603-194311
        git checkout fd98f41f84acfad0ad1c7d1eb553807e8d1e0b9b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

All errors (new ones prefixed by >>):

   kernel/sched/fair.c: In function 'tg_unthrottle_up':
>> kernel/sched/fair.c:4704:13: error: 'struct cfs_rq' has no member named 'tg_load_avg_contrib'
    4704 |   if (cfs_rq->tg_load_avg_contrib || cfs_rq->nr_running)
         |             ^~


vim +4704 kernel/sched/fair.c

  4689	
  4690	static int tg_unthrottle_up(struct task_group *tg, void *data)
  4691	{
  4692		struct rq *rq = data;
  4693		struct cfs_rq *cfs_rq = tg->cfs_rq[cpu_of(rq)];
  4694	
  4695		cfs_rq->throttle_count--;
  4696		if (!cfs_rq->throttle_count) {
  4697			cfs_rq->throttled_clock_task_time += rq_clock_task(rq) -
  4698						     cfs_rq->throttled_clock_task;
  4699	
  4700			/*
  4701			 * Add cfs_rq with tg load avg contribution or one or more
  4702			 * already running entities to the list
  4703			 */
> 4704			if (cfs_rq->tg_load_avg_contrib || cfs_rq->nr_running)
  4705				list_add_leaf_cfs_rq(cfs_rq);
  4706		}
  4707	
  4708		return 0;
  4709	}
  4710	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 20340 bytes --]

  parent reply	other threads:[~2021-06-03 14:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 11:38 [PATCH v2] sched/fair: Correctly insert cfs_rq's to list on unthrottle Odin Ugedal
2021-06-03 12:51 ` Vincent Guittot
2021-06-03 13:12   ` Odin Ugedal
2021-06-03 13:12     ` Odin Ugedal
2021-06-03 13:40     ` Vincent Guittot
2021-06-03 13:55       ` Odin Ugedal
2021-06-03 14:39 ` kernel test robot [this message]
2021-06-03 14:39   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202106032238.nLLExUou-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.