* [PATCH -next v2] mfd: pm8008: Fix return value check in pm8008_probe()
@ 2021-06-04 1:38 Yang Yingliang
2021-06-04 17:50 ` Guru Das Srinagesh
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-06-04 1:38 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm; +Cc: lee.jones, agross, gurus, dmitry.baryshkov
In case of error, the function devm_regmap_init_i2c() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
v2:
make the change correspond to the changelog
---
drivers/mfd/qcom-pm8008.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
index c472d7f8103c..476171455d32 100644
--- a/drivers/mfd/qcom-pm8008.c
+++ b/drivers/mfd/qcom-pm8008.c
@@ -228,7 +228,7 @@ static int pm8008_probe(struct i2c_client *client)
chip->dev = &client->dev;
chip->regmap = devm_regmap_init_i2c(client, &qcom_mfd_regmap_cfg);
- if (!chip->regmap)
+ if (IS_ERR(chip->regmap))
return -ENODEV;
i2c_set_clientdata(client, chip);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next v2] mfd: pm8008: Fix return value check in pm8008_probe()
2021-06-04 1:38 [PATCH -next v2] mfd: pm8008: Fix return value check in pm8008_probe() Yang Yingliang
@ 2021-06-04 17:50 ` Guru Das Srinagesh
0 siblings, 0 replies; 2+ messages in thread
From: Guru Das Srinagesh @ 2021-06-04 17:50 UTC (permalink / raw)
To: Yang Yingliang
Cc: linux-kernel, linux-arm-msm, lee.jones, agross, dmitry.baryshkov
On Fri, Jun 04, 2021 at 09:38:24AM +0800, Yang Yingliang wrote:
> In case of error, the function devm_regmap_init_i2c() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Fixes: 6b149f3310a4 ("mfd: pm8008: Add driver for QCOM PM8008 PMIC")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> v2:
> make the change correspond to the changelog
> ---
> drivers/mfd/qcom-pm8008.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
> index c472d7f8103c..476171455d32 100644
> --- a/drivers/mfd/qcom-pm8008.c
> +++ b/drivers/mfd/qcom-pm8008.c
> @@ -228,7 +228,7 @@ static int pm8008_probe(struct i2c_client *client)
>
> chip->dev = &client->dev;
> chip->regmap = devm_regmap_init_i2c(client, &qcom_mfd_regmap_cfg);
> - if (!chip->regmap)
> + if (IS_ERR(chip->regmap))
> return -ENODEV;
The error received from devm_regmap_init_i2c should be returned as-is and not
-ENODEV. Could you please do:
if (IS_ERR(chip->regmap))
return PTR_ERR(chip->regmap);
Thank you for this patch.
>
> i2c_set_clientdata(client, chip);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-04 17:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 1:38 [PATCH -next v2] mfd: pm8008: Fix return value check in pm8008_probe() Yang Yingliang
2021-06-04 17:50 ` Guru Das Srinagesh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.