* [PATCH -next] EDAC/armada_xp: Remove redundant dev_err call in axp_mc_probe() and aurora_l2_probe()
@ 2021-06-04 10:12 ChenXiaoSong
0 siblings, 0 replies; only message in thread
From: ChenXiaoSong @ 2021-06-04 10:12 UTC (permalink / raw)
Cc: linux-kernel, yukuai3, yi.zhang, chenxiaosong2
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
---
drivers/edac/armada_xp_edac.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/edac/armada_xp_edac.c b/drivers/edac/armada_xp_edac.c
index e3e757513d1b..9661c72e6554 100644
--- a/drivers/edac/armada_xp_edac.c
+++ b/drivers/edac/armada_xp_edac.c
@@ -297,10 +297,8 @@ static int axp_mc_probe(struct platform_device *pdev)
}
base = devm_ioremap_resource(&pdev->dev, r);
- if (IS_ERR(base)) {
- dev_err(&pdev->dev, "Unable to map regs\n");
+ if (IS_ERR(base))
return PTR_ERR(base);
- }
config = readl(base + SDRAM_CONFIG_REG);
if (!(config & SDRAM_CONFIG_ECC_MASK)) {
@@ -525,10 +523,8 @@ static int aurora_l2_probe(struct platform_device *pdev)
}
base = devm_ioremap_resource(&pdev->dev, r);
- if (IS_ERR(base)) {
- dev_err(&pdev->dev, "Unable to map regs\n");
+ if (IS_ERR(base))
return PTR_ERR(base);
- }
l2x0_aux_ctrl = readl(base + L2X0_AUX_CTRL);
if (!(l2x0_aux_ctrl & AURORA_ACR_PARITY_EN))
--
2.25.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-04 10:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 10:12 [PATCH -next] EDAC/armada_xp: Remove redundant dev_err call in axp_mc_probe() and aurora_l2_probe() ChenXiaoSong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.