Re: [PATCH v5 08/12] wcn36xx: Add GTK offload to WoWLAN path

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 08/12] wcn36xx: Add GTK offload to WoWLAN path
Date: Fri, 04 Jun 2021 12:57:22 +0800	[thread overview]
Message-ID: <202106041241.wE8HKauK-lkp@intel.com> (raw)
In-Reply-To: <20210601151001.1450540-9-bryan.odonoghue@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 3511 bytes --]

Hi Bryan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.13-rc4 next-20210603]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Enable-downstream-consistent-Wake-on-Lan/20210601-231011
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: x86_64-randconfig-s022-20210604 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/3fc5c2f97f5bdc763f508bbb239b5eedc324be42
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Enable-downstream-consistent-Wake-on-Lan/20210601-231011
        git checkout 3fc5c2f97f5bdc763f508bbb239b5eedc324be42
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/net/wireless/ath/wcn36xx/smd.c:2873:45: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned long long [addressable] [assigned] [usertype] key_replay_counter @@     got restricted __le64 [usertype] replay_ctr @@
   drivers/net/wireless/ath/wcn36xx/smd.c:2873:45: sparse:     expected unsigned long long [addressable] [assigned] [usertype] key_replay_counter
   drivers/net/wireless/ath/wcn36xx/smd.c:2873:45: sparse:     got restricted __le64 [usertype] replay_ctr

vim +2873 drivers/net/wireless/ath/wcn36xx/smd.c

  2858	
  2859	int wcn36xx_smd_gtk_offload(struct wcn36xx *wcn, struct ieee80211_vif *vif,
  2860				    bool enable)
  2861	{
  2862		struct wcn36xx_vif *vif_priv = wcn36xx_vif_to_priv(vif);
  2863		struct wcn36xx_hal_gtk_offload_req_msg msg_body;
  2864		int ret;
  2865	
  2866		mutex_lock(&wcn->hal_mutex);
  2867	
  2868		INIT_HAL_MSG(msg_body, WCN36XX_HAL_GTK_OFFLOAD_REQ);
  2869	
  2870		if (enable) {
  2871			memcpy(&msg_body.kek, vif_priv->rekey_data.kek, NL80211_KEK_LEN);
  2872			memcpy(&msg_body.kck, vif_priv->rekey_data.kck, NL80211_KCK_LEN);
> 2873			msg_body.key_replay_counter = vif_priv->rekey_data.replay_ctr;
  2874			msg_body.bss_index = vif_priv->bss_index;
  2875		} else {
  2876			msg_body.flags = WCN36XX_HAL_GTK_OFFLOAD_FLAGS_DISABLE;
  2877		}
  2878	
  2879		PREPARE_HAL_BUF(wcn->hal_buf, msg_body);
  2880	
  2881		ret = wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);
  2882		if (ret) {
  2883			wcn36xx_err("Sending host_offload_arp failed\n");
  2884			goto out;
  2885		}
  2886		ret = wcn36xx_smd_rsp_status_check(wcn->hal_buf, wcn->hal_rsp_len);
  2887		if (ret) {
  2888			wcn36xx_err("host_offload_arp failed err=%d\n", ret);
  2889			goto out;
  2890		}
  2891	out:
  2892		mutex_unlock(&wcn->hal_mutex);
  2893		return ret;
  2894	}
  2895	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34715 bytes --]