From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDDD7C07E94 for ; Fri, 4 Jun 2021 15:34:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C16A961406 for ; Fri, 4 Jun 2021 15:34:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230385AbhFDPge (ORCPT ); Fri, 4 Jun 2021 11:36:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:35550 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229675AbhFDPge (ORCPT ); Fri, 4 Jun 2021 11:36:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CC37361402; Fri, 4 Jun 2021 15:34:44 +0000 (UTC) Date: Fri, 4 Jun 2021 16:34:42 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Haibo Xu , Andrew Jones Subject: Re: [PATCH v13 7/8] KVM: arm64: ioctl to fetch/store tags in a guest Message-ID: <20210604153441.GG31173@arm.com> References: <20210524104513.13258-1-steven.price@arm.com> <20210524104513.13258-8-steven.price@arm.com> <20210603171336.GH20338@arm.com> <02c7682e-5fb6-29eb-9105-02e3521756a2@arm.com> <20210604114233.GE31173@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 04, 2021 at 02:09:50PM +0100, Steven Price wrote: > On 04/06/2021 12:42, Catalin Marinas wrote: > > On Fri, Jun 04, 2021 at 12:15:56PM +0100, Steven Price wrote: > >> On 03/06/2021 18:13, Catalin Marinas wrote: > >>> On Mon, May 24, 2021 at 11:45:12AM +0100, Steven Price wrote: > >>>> diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h > >>>> index 24223adae150..b3edde68bc3e 100644 > >>>> --- a/arch/arm64/include/uapi/asm/kvm.h > >>>> +++ b/arch/arm64/include/uapi/asm/kvm.h > >>>> @@ -184,6 +184,17 @@ struct kvm_vcpu_events { > >>>> __u32 reserved[12]; > >>>> }; > >>>> > >>>> +struct kvm_arm_copy_mte_tags { > >>>> + __u64 guest_ipa; > >>>> + __u64 length; > >>>> + void __user *addr; > >>>> + __u64 flags; > >>>> + __u64 reserved[2]; > >>>> +}; > >>>> + > >>>> +#define KVM_ARM_TAGS_TO_GUEST 0 > >>>> +#define KVM_ARM_TAGS_FROM_GUEST 1 > >>>> + > >>>> /* If you need to interpret the index values, here is the key: */ > >>>> #define KVM_REG_ARM_COPROC_MASK 0x000000000FFF0000 > >>>> #define KVM_REG_ARM_COPROC_SHIFT 16 > >>>> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > >>>> index e89a5e275e25..baa33359e477 100644 > >>>> --- a/arch/arm64/kvm/arm.c > >>>> +++ b/arch/arm64/kvm/arm.c > >>>> @@ -1345,6 +1345,13 @@ long kvm_arch_vm_ioctl(struct file *filp, > >>>> > >>>> return 0; > >>>> } > >>>> + case KVM_ARM_MTE_COPY_TAGS: { > >>>> + struct kvm_arm_copy_mte_tags copy_tags; > >>>> + > >>>> + if (copy_from_user(©_tags, argp, sizeof(copy_tags))) > >>>> + return -EFAULT; > >>>> + return kvm_vm_ioctl_mte_copy_tags(kvm, ©_tags); > >>>> + } > >>> > >>> I wonder whether we need an update of the user structure following a > >>> fault, like how much was copied etc. In case of an error, some tags were > >>> copied and the VMM may want to skip the page before continuing. But here > >>> there's no such information provided. > >>> > >>> On the ptrace interface, we return 0 on the syscall if any bytes were > >>> copied and update iov_len to such number. Maybe you want to still return > >>> an error here but updating copy_tags.length would be nice (and, of > >>> course, a copy_to_user() back). > >> > >> Good idea - as you suggest I'll make it update length with the number of > >> bytes not processed. Although in general I think we're expecting the VMM > >> to know where the memory is so this is more of a programming error - but > >> could still be useful for debugging. > > > > Or update it to the number of bytes copied to be consistent with > > ptrace()'s iov.len. On success, the structure is effectively left > > unchanged. > > I was avoiding that because it confuses the error code when the initial > copy_from_user() fails. In that case the structure is clearly unchanged, > so you can only tell from a -EFAULT return that nothing happened. By > returning the number of bytes left you can return an error code along > with the information that the copy only half completed. > > It also seems cleaner to leave the structure unchanged if e.g. the flags > or reserved fields are invalid rather than having to set length=0 to > signal that nothing was done. > > Although I do feel like arguing whether to use a ptrace() interface or a > copy_{to,from}_user() interface is somewhat ridiculous considering > neither are exactly considered good. > > Rather than changing the structure we could return either an error code > (if nothing was copied) or the number of bytes left. That way ioctl()==0 > means complete success, >0 means partial success and <0 means complete > failure and provides a detailed error code. The ioctl() can be repeated > (with adjusted pointers) if it returns >0 and a detailed error is needed. That would be more like read/write (nearly, those always return the amount copied). Anyway, I don't have any strong preference, I'll leave the details up to you as long as there is some indication of how much was copied or left. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B021C07E94 for ; Fri, 4 Jun 2021 15:35:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5962261402 for ; Fri, 4 Jun 2021 15:35:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5962261402 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpBrG-00070o-HJ for qemu-devel@archiver.kernel.org; Fri, 04 Jun 2021 11:35:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpBqW-0006C4-GY for qemu-devel@nongnu.org; Fri, 04 Jun 2021 11:34:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:52474) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpBqU-0003Di-7h for qemu-devel@nongnu.org; Fri, 04 Jun 2021 11:34:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CC37361402; Fri, 4 Jun 2021 15:34:44 +0000 (UTC) Date: Fri, 4 Jun 2021 16:34:42 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v13 7/8] KVM: arm64: ioctl to fetch/store tags in a guest Message-ID: <20210604153441.GG31173@arm.com> References: <20210524104513.13258-1-steven.price@arm.com> <20210524104513.13258-8-steven.price@arm.com> <20210603171336.GH20338@arm.com> <02c7682e-5fb6-29eb-9105-02e3521756a2@arm.com> <20210604114233.GE31173@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=198.145.29.99; envelope-from=cmarinas@kernel.org; helo=mail.kernel.org X-Spam_score_int: -66 X-Spam_score: -6.7 X-Spam_bar: ------ X-Spam_report: (-6.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Maydell , "Dr. David Alan Gilbert" , Andrew Jones , Haibo Xu , Suzuki K Poulose , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , James Morse , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jun 04, 2021 at 02:09:50PM +0100, Steven Price wrote: > On 04/06/2021 12:42, Catalin Marinas wrote: > > On Fri, Jun 04, 2021 at 12:15:56PM +0100, Steven Price wrote: > >> On 03/06/2021 18:13, Catalin Marinas wrote: > >>> On Mon, May 24, 2021 at 11:45:12AM +0100, Steven Price wrote: > >>>> diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h > >>>> index 24223adae150..b3edde68bc3e 100644 > >>>> --- a/arch/arm64/include/uapi/asm/kvm.h > >>>> +++ b/arch/arm64/include/uapi/asm/kvm.h > >>>> @@ -184,6 +184,17 @@ struct kvm_vcpu_events { > >>>> __u32 reserved[12]; > >>>> }; > >>>> > >>>> +struct kvm_arm_copy_mte_tags { > >>>> + __u64 guest_ipa; > >>>> + __u64 length; > >>>> + void __user *addr; > >>>> + __u64 flags; > >>>> + __u64 reserved[2]; > >>>> +}; > >>>> + > >>>> +#define KVM_ARM_TAGS_TO_GUEST 0 > >>>> +#define KVM_ARM_TAGS_FROM_GUEST 1 > >>>> + > >>>> /* If you need to interpret the index values, here is the key: */ > >>>> #define KVM_REG_ARM_COPROC_MASK 0x000000000FFF0000 > >>>> #define KVM_REG_ARM_COPROC_SHIFT 16 > >>>> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > >>>> index e89a5e275e25..baa33359e477 100644 > >>>> --- a/arch/arm64/kvm/arm.c > >>>> +++ b/arch/arm64/kvm/arm.c > >>>> @@ -1345,6 +1345,13 @@ long kvm_arch_vm_ioctl(struct file *filp, > >>>> > >>>> return 0; > >>>> } > >>>> + case KVM_ARM_MTE_COPY_TAGS: { > >>>> + struct kvm_arm_copy_mte_tags copy_tags; > >>>> + > >>>> + if (copy_from_user(©_tags, argp, sizeof(copy_tags))) > >>>> + return -EFAULT; > >>>> + return kvm_vm_ioctl_mte_copy_tags(kvm, ©_tags); > >>>> + } > >>> > >>> I wonder whether we need an update of the user structure following a > >>> fault, like how much was copied etc. In case of an error, some tags were > >>> copied and the VMM may want to skip the page before continuing. But here > >>> there's no such information provided. > >>> > >>> On the ptrace interface, we return 0 on the syscall if any bytes were > >>> copied and update iov_len to such number. Maybe you want to still return > >>> an error here but updating copy_tags.length would be nice (and, of > >>> course, a copy_to_user() back). > >> > >> Good idea - as you suggest I'll make it update length with the number of > >> bytes not processed. Although in general I think we're expecting the VMM > >> to know where the memory is so this is more of a programming error - but > >> could still be useful for debugging. > > > > Or update it to the number of bytes copied to be consistent with > > ptrace()'s iov.len. On success, the structure is effectively left > > unchanged. > > I was avoiding that because it confuses the error code when the initial > copy_from_user() fails. In that case the structure is clearly unchanged, > so you can only tell from a -EFAULT return that nothing happened. By > returning the number of bytes left you can return an error code along > with the information that the copy only half completed. > > It also seems cleaner to leave the structure unchanged if e.g. the flags > or reserved fields are invalid rather than having to set length=0 to > signal that nothing was done. > > Although I do feel like arguing whether to use a ptrace() interface or a > copy_{to,from}_user() interface is somewhat ridiculous considering > neither are exactly considered good. > > Rather than changing the structure we could return either an error code > (if nothing was copied) or the number of bytes left. That way ioctl()==0 > means complete success, >0 means partial success and <0 means complete > failure and provides a detailed error code. The ioctl() can be repeated > (with adjusted pointers) if it returns >0 and a detailed error is needed. That would be more like read/write (nearly, those always return the amount copied). Anyway, I don't have any strong preference, I'll leave the details up to you as long as there is some indication of how much was copied or left. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC0B1C07E94 for ; Fri, 4 Jun 2021 15:34:57 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 4245D61404 for ; Fri, 4 Jun 2021 15:34:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4245D61404 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BE4314B0FE; Fri, 4 Jun 2021 11:34:56 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8a79yt7jE9os; Fri, 4 Jun 2021 11:34:52 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id CE8D74B0D0; Fri, 4 Jun 2021 11:34:52 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7C3BF4B0C8 for ; Fri, 4 Jun 2021 11:34:51 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id swoDPASkhZzD for ; Fri, 4 Jun 2021 11:34:48 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id B2B784B0C3 for ; Fri, 4 Jun 2021 11:34:48 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id CC37361402; Fri, 4 Jun 2021 15:34:44 +0000 (UTC) Date: Fri, 4 Jun 2021 16:34:42 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v13 7/8] KVM: arm64: ioctl to fetch/store tags in a guest Message-ID: <20210604153441.GG31173@arm.com> References: <20210524104513.13258-1-steven.price@arm.com> <20210524104513.13258-8-steven.price@arm.com> <20210603171336.GH20338@arm.com> <02c7682e-5fb6-29eb-9105-02e3521756a2@arm.com> <20210604114233.GE31173@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Jun 04, 2021 at 02:09:50PM +0100, Steven Price wrote: > On 04/06/2021 12:42, Catalin Marinas wrote: > > On Fri, Jun 04, 2021 at 12:15:56PM +0100, Steven Price wrote: > >> On 03/06/2021 18:13, Catalin Marinas wrote: > >>> On Mon, May 24, 2021 at 11:45:12AM +0100, Steven Price wrote: > >>>> diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h > >>>> index 24223adae150..b3edde68bc3e 100644 > >>>> --- a/arch/arm64/include/uapi/asm/kvm.h > >>>> +++ b/arch/arm64/include/uapi/asm/kvm.h > >>>> @@ -184,6 +184,17 @@ struct kvm_vcpu_events { > >>>> __u32 reserved[12]; > >>>> }; > >>>> > >>>> +struct kvm_arm_copy_mte_tags { > >>>> + __u64 guest_ipa; > >>>> + __u64 length; > >>>> + void __user *addr; > >>>> + __u64 flags; > >>>> + __u64 reserved[2]; > >>>> +}; > >>>> + > >>>> +#define KVM_ARM_TAGS_TO_GUEST 0 > >>>> +#define KVM_ARM_TAGS_FROM_GUEST 1 > >>>> + > >>>> /* If you need to interpret the index values, here is the key: */ > >>>> #define KVM_REG_ARM_COPROC_MASK 0x000000000FFF0000 > >>>> #define KVM_REG_ARM_COPROC_SHIFT 16 > >>>> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > >>>> index e89a5e275e25..baa33359e477 100644 > >>>> --- a/arch/arm64/kvm/arm.c > >>>> +++ b/arch/arm64/kvm/arm.c > >>>> @@ -1345,6 +1345,13 @@ long kvm_arch_vm_ioctl(struct file *filp, > >>>> > >>>> return 0; > >>>> } > >>>> + case KVM_ARM_MTE_COPY_TAGS: { > >>>> + struct kvm_arm_copy_mte_tags copy_tags; > >>>> + > >>>> + if (copy_from_user(©_tags, argp, sizeof(copy_tags))) > >>>> + return -EFAULT; > >>>> + return kvm_vm_ioctl_mte_copy_tags(kvm, ©_tags); > >>>> + } > >>> > >>> I wonder whether we need an update of the user structure following a > >>> fault, like how much was copied etc. In case of an error, some tags were > >>> copied and the VMM may want to skip the page before continuing. But here > >>> there's no such information provided. > >>> > >>> On the ptrace interface, we return 0 on the syscall if any bytes were > >>> copied and update iov_len to such number. Maybe you want to still return > >>> an error here but updating copy_tags.length would be nice (and, of > >>> course, a copy_to_user() back). > >> > >> Good idea - as you suggest I'll make it update length with the number of > >> bytes not processed. Although in general I think we're expecting the VMM > >> to know where the memory is so this is more of a programming error - but > >> could still be useful for debugging. > > > > Or update it to the number of bytes copied to be consistent with > > ptrace()'s iov.len. On success, the structure is effectively left > > unchanged. > > I was avoiding that because it confuses the error code when the initial > copy_from_user() fails. In that case the structure is clearly unchanged, > so you can only tell from a -EFAULT return that nothing happened. By > returning the number of bytes left you can return an error code along > with the information that the copy only half completed. > > It also seems cleaner to leave the structure unchanged if e.g. the flags > or reserved fields are invalid rather than having to set length=0 to > signal that nothing was done. > > Although I do feel like arguing whether to use a ptrace() interface or a > copy_{to,from}_user() interface is somewhat ridiculous considering > neither are exactly considered good. > > Rather than changing the structure we could return either an error code > (if nothing was copied) or the number of bytes left. That way ioctl()==0 > means complete success, >0 means partial success and <0 means complete > failure and provides a detailed error code. The ioctl() can be repeated > (with adjusted pointers) if it returns >0 and a detailed error is needed. That would be more like read/write (nearly, those always return the amount copied). Anyway, I don't have any strong preference, I'll leave the details up to you as long as there is some indication of how much was copied or left. -- Catalin _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C1FC07E94 for ; Fri, 4 Jun 2021 15:36:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0307E610A1 for ; Fri, 4 Jun 2021 15:36:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0307E610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4IHKHlMA0VwNoWZGxFBGGNuwwMCB7QFb3I3roPeSqR8=; b=GTZsFZj/A/Mz3+ pSzna64ZF9gJDUSHOBBqC+ELM1+3cAZEsjrKC1bZfCgZJlsQ/u0O/jP1SNKbHVCau0LVe+/XiWBkE IUkG6YEegtEZhMfe7YLAc5UQQ5LBJstrk2q4q308ec9DgD+3OOzWbxVCqmno1GRvQrqWSRsrjcJRH qCJ7usrVYcTMoLEqUKLsbT78PLGAhFDYYRW82Mn/GPDaJcvFaMas4Y5Tv3Cdi7Tb6THh7h10DvWqL HihgrQFCDb3Rhk+8Q79ZH9OeSHbNfdsctUDUYb08+eBi7M5eSWfpDXjBbFJH/0XO8J0nfqKIBxSYd tFRN1c9Yi5idSJbh6soQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lpBqa-00EBhT-Vv; Fri, 04 Jun 2021 15:34:57 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lpBqS-00EBgb-7M for linux-arm-kernel@lists.infradead.org; Fri, 04 Jun 2021 15:34:50 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id CC37361402; Fri, 4 Jun 2021 15:34:44 +0000 (UTC) Date: Fri, 4 Jun 2021 16:34:42 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Haibo Xu , Andrew Jones Subject: Re: [PATCH v13 7/8] KVM: arm64: ioctl to fetch/store tags in a guest Message-ID: <20210604153441.GG31173@arm.com> References: <20210524104513.13258-1-steven.price@arm.com> <20210524104513.13258-8-steven.price@arm.com> <20210603171336.GH20338@arm.com> <02c7682e-5fb6-29eb-9105-02e3521756a2@arm.com> <20210604114233.GE31173@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210604_083448_342874_9E567378 X-CRM114-Status: GOOD ( 32.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 04, 2021 at 02:09:50PM +0100, Steven Price wrote: > On 04/06/2021 12:42, Catalin Marinas wrote: > > On Fri, Jun 04, 2021 at 12:15:56PM +0100, Steven Price wrote: > >> On 03/06/2021 18:13, Catalin Marinas wrote: > >>> On Mon, May 24, 2021 at 11:45:12AM +0100, Steven Price wrote: > >>>> diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h > >>>> index 24223adae150..b3edde68bc3e 100644 > >>>> --- a/arch/arm64/include/uapi/asm/kvm.h > >>>> +++ b/arch/arm64/include/uapi/asm/kvm.h > >>>> @@ -184,6 +184,17 @@ struct kvm_vcpu_events { > >>>> __u32 reserved[12]; > >>>> }; > >>>> > >>>> +struct kvm_arm_copy_mte_tags { > >>>> + __u64 guest_ipa; > >>>> + __u64 length; > >>>> + void __user *addr; > >>>> + __u64 flags; > >>>> + __u64 reserved[2]; > >>>> +}; > >>>> + > >>>> +#define KVM_ARM_TAGS_TO_GUEST 0 > >>>> +#define KVM_ARM_TAGS_FROM_GUEST 1 > >>>> + > >>>> /* If you need to interpret the index values, here is the key: */ > >>>> #define KVM_REG_ARM_COPROC_MASK 0x000000000FFF0000 > >>>> #define KVM_REG_ARM_COPROC_SHIFT 16 > >>>> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > >>>> index e89a5e275e25..baa33359e477 100644 > >>>> --- a/arch/arm64/kvm/arm.c > >>>> +++ b/arch/arm64/kvm/arm.c > >>>> @@ -1345,6 +1345,13 @@ long kvm_arch_vm_ioctl(struct file *filp, > >>>> > >>>> return 0; > >>>> } > >>>> + case KVM_ARM_MTE_COPY_TAGS: { > >>>> + struct kvm_arm_copy_mte_tags copy_tags; > >>>> + > >>>> + if (copy_from_user(©_tags, argp, sizeof(copy_tags))) > >>>> + return -EFAULT; > >>>> + return kvm_vm_ioctl_mte_copy_tags(kvm, ©_tags); > >>>> + } > >>> > >>> I wonder whether we need an update of the user structure following a > >>> fault, like how much was copied etc. In case of an error, some tags were > >>> copied and the VMM may want to skip the page before continuing. But here > >>> there's no such information provided. > >>> > >>> On the ptrace interface, we return 0 on the syscall if any bytes were > >>> copied and update iov_len to such number. Maybe you want to still return > >>> an error here but updating copy_tags.length would be nice (and, of > >>> course, a copy_to_user() back). > >> > >> Good idea - as you suggest I'll make it update length with the number of > >> bytes not processed. Although in general I think we're expecting the VMM > >> to know where the memory is so this is more of a programming error - but > >> could still be useful for debugging. > > > > Or update it to the number of bytes copied to be consistent with > > ptrace()'s iov.len. On success, the structure is effectively left > > unchanged. > > I was avoiding that because it confuses the error code when the initial > copy_from_user() fails. In that case the structure is clearly unchanged, > so you can only tell from a -EFAULT return that nothing happened. By > returning the number of bytes left you can return an error code along > with the information that the copy only half completed. > > It also seems cleaner to leave the structure unchanged if e.g. the flags > or reserved fields are invalid rather than having to set length=0 to > signal that nothing was done. > > Although I do feel like arguing whether to use a ptrace() interface or a > copy_{to,from}_user() interface is somewhat ridiculous considering > neither are exactly considered good. > > Rather than changing the structure we could return either an error code > (if nothing was copied) or the number of bytes left. That way ioctl()==0 > means complete success, >0 means partial success and <0 means complete > failure and provides a detailed error code. The ioctl() can be repeated > (with adjusted pointers) if it returns >0 and a detailed error is needed. That would be more like read/write (nearly, those always return the amount copied). Anyway, I don't have any strong preference, I'll leave the details up to you as long as there is some indication of how much was copied or left. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel