All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com,
	Daniel Henrique Barboza <danielhb413@gmail.com>,
	qemu-ppc@nongnu.org, groug@kaod.org, david@gibson.dropbear.id.au
Subject: [PATCH v2 0/2] DEVICE_UNPLUG_ERROR QAPI event
Date: Fri,  4 Jun 2021 17:03:51 -0300	[thread overview]
Message-ID: <20210604200353.1206897-1-danielhb413@gmail.com> (raw)

Hi,

This is the v2 of a series that started with 2 events,
DEVICE_UNPLUG_ERROR and DEVICE_NOT_DELETED [1]. After discussions in v1
we reached the conclussion that the DEVICE_NOT_DELETED wasn't doing much
of anything. It was an event that was trying to say 'I think something
happen, but I'm not sure', forcing the QAPI listener to inspect the
guest itself to see what went wrong, or just wait for some sort of
internal timeout (as Libvirt will do) and fail the operation regardless.

During this period between v1 and this v2 the PowerPC kernel was changed
to add a reliable error report mechanism in the device_removal path of
CPUs, which in turn gave QEMU the opportunity to do the same. This made
the DEVICE_UNPLUG_ERROR more relevant because now we can report CPU and
DIMM hotunplug errors.


changes from v1:
- former patches 1 and 2: dropped
- patch 1 (former 3): changed the version to '6.1'
- patch 2 (former 4): add a DEVICE_UNPLUG_ERROR event in the device
  unplug error path of CPUs and DIMMs

[1] v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg04682.html



Daniel Henrique Barboza (2):
  qapi/machine.json: add DEVICE_UNPLUG_ERROR QAPI event
  spapr: use DEVICE_UNPLUG_ERROR to report unplug errors

 hw/ppc/spapr.c     |  2 +-
 hw/ppc/spapr_drc.c | 15 +++++++++------
 qapi/machine.json  | 23 +++++++++++++++++++++++
 3 files changed, 33 insertions(+), 7 deletions(-)

-- 
2.31.1



             reply	other threads:[~2021-06-04 20:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 20:03 Daniel Henrique Barboza [this message]
2021-06-04 20:03 ` [PATCH v2 1/2] qapi/machine.json: add DEVICE_UNPLUG_ERROR QAPI event Daniel Henrique Barboza
2021-06-07  2:23   ` David Gibson
2021-06-07  2:23     ` David Gibson
2021-06-07 18:41       ` Eric Blake
2021-06-11 12:12   ` Markus Armbruster
2021-06-16 16:41     ` Daniel Henrique Barboza
2021-06-17  5:59       ` Markus Armbruster
2021-06-04 20:03 ` [PATCH v2 2/2] spapr: use DEVICE_UNPLUG_ERROR to report unplug errors Daniel Henrique Barboza
2021-06-07  2:24   ` David Gibson
2021-06-11 12:18   ` Markus Armbruster
2021-06-16 16:58     ` Daniel Henrique Barboza
2021-06-16 17:58       ` Eric Blake
2021-06-07  2:25 ` [PATCH v2 0/2] DEVICE_UNPLUG_ERROR QAPI event David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210604200353.1206897-1-danielhb413@gmail.com \
    --to=danielhb413@gmail.com \
    --cc=armbru@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.