All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/4] pcf857x: DTS fixes and DT binding to json-schema conversion
@ 2021-06-01 15:25 Geert Uytterhoeven
  2021-06-01 15:25 ` [PATCH v2 1/4] dt-bindings: i2c: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575" Geert Uytterhoeven
                   ` (3 more replies)
  0 siblings, 4 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2021-06-01 15:25 UTC (permalink / raw)
  To: Rob Herring, Laurent Pinchart, Linus Walleij,
	Bartosz Golaszewski, Benoît Cousson, Tony Lindgren,
	Darren Hart, Andy Shevchenko, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H . Peter Anvin
  Cc: devicetree, linux-gpio, x86, linux-omap, linux-i2c,
	platform-driver-x86, Geert Uytterhoeven

	Hi all,

This patch series converts the PCF857x-compatible I/O expanders Device
Tree binding documentation to json-schema, after fixing a few issues in
DT binding examples and DTS files.

Changes compared to v1[1]:
  - Drop applied fixes,
  - Drop "ti,pcf8575" from examples and DTS files,
  - Drop support for "ti,pcf8575", as it's 100% compatible with
    "nxp,pcf8575",
  - Drop "hog-[0-9]+" from hog names,
  - Rely on dt-schema/schemas/gpio/gpio-hog.yaml for hog properties.

Thanks!

[1] [PATCH 0/3] pcf857x: DTS fixes and DT binding to json-schema conversion
    https://lore.kernel.org/r/cover.1621583562.git.geert+renesas@glider.be/

Geert Uytterhoeven (4):
  dt-bindings: i2c: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575"
  ARM: dts: dra7x-evm: Drop "ti,pcf8575"
  x86: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575"
  dt-bindings: gpio: pcf857x: Convert to json-schema

 .../devicetree/bindings/gpio/gpio-pcf857x.txt |  69 ------------
 .../devicetree/bindings/gpio/nxp,pcf8575.yaml | 103 ++++++++++++++++++
 .../bindings/i2c/i2c-pxa-pci-ce4100.txt       |   4 +-
 arch/arm/boot/dts/dra7-evm.dts                |   6 +-
 arch/arm/boot/dts/dra72-evm-common.dtsi       |   4 +-
 arch/arm/boot/dts/dra76-evm.dts               |   6 +-
 arch/x86/platform/ce4100/falconfalls.dts      |   4 +-
 7 files changed, 115 insertions(+), 81 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
 create mode 100644 Documentation/devicetree/bindings/gpio/nxp,pcf8575.yaml

-- 
2.25.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v2 1/4] dt-bindings: i2c: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575"
  2021-06-01 15:25 [PATCH v2 0/4] pcf857x: DTS fixes and DT binding to json-schema conversion Geert Uytterhoeven
@ 2021-06-01 15:25 ` Geert Uytterhoeven
  2021-06-04 20:27   ` Wolfram Sang
  2021-06-20 21:08   ` Wolfram Sang
  2021-06-01 15:25 ` [PATCH v2 2/4] ARM: dts: dra7x-evm: Drop "ti,pcf8575" Geert Uytterhoeven
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2021-06-01 15:25 UTC (permalink / raw)
  To: Rob Herring, Laurent Pinchart, Linus Walleij,
	Bartosz Golaszewski, Benoît Cousson, Tony Lindgren,
	Darren Hart, Andy Shevchenko, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H . Peter Anvin
  Cc: devicetree, linux-gpio, x86, linux-omap, linux-i2c,
	platform-driver-x86, Geert Uytterhoeven

The TI part is equivalent to the NXP part, and its compatible value is
not documented in the DT bindings.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - New.
---
 Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt b/Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt
index 569b16248514ff86..1ff6f8487a2d7bbd 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt
@@ -71,7 +71,7 @@ This is an example which is used on FalconFalls:
 			/* This I2C controller has one gpio controller */
 			gpio@26 {
 				#gpio-cells = <2>;
-				compatible = "ti,pcf8575";
+				compatible = "nxp,pcf8575";
 				reg = <0x26>;
 				gpio-controller;
 			};
@@ -85,7 +85,7 @@ This is an example which is used on FalconFalls:
 
 			gpio@26 {
 				#gpio-cells = <2>;
-				compatible = "ti,pcf8575";
+				compatible = "nxp,pcf8575";
 				reg = <0x26>;
 				gpio-controller;
 			};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v2 2/4] ARM: dts: dra7x-evm: Drop "ti,pcf8575"
  2021-06-01 15:25 [PATCH v2 0/4] pcf857x: DTS fixes and DT binding to json-schema conversion Geert Uytterhoeven
  2021-06-01 15:25 ` [PATCH v2 1/4] dt-bindings: i2c: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575" Geert Uytterhoeven
@ 2021-06-01 15:25 ` Geert Uytterhoeven
  2021-06-11  7:33   ` Tony Lindgren
  2021-06-01 15:25 ` [PATCH v2 3/4] x86: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575" Geert Uytterhoeven
  2021-06-01 15:25 ` [PATCH v2 4/4] dt-bindings: gpio: pcf857x: Convert to json-schema Geert Uytterhoeven
  3 siblings, 1 reply; 13+ messages in thread
From: Geert Uytterhoeven @ 2021-06-01 15:25 UTC (permalink / raw)
  To: Rob Herring, Laurent Pinchart, Linus Walleij,
	Bartosz Golaszewski, Benoît Cousson, Tony Lindgren,
	Darren Hart, Andy Shevchenko, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H . Peter Anvin
  Cc: devicetree, linux-gpio, x86, linux-omap, linux-i2c,
	platform-driver-x86, Geert Uytterhoeven

The TI part is equivalent to the NXP part and its compatible value is
not documented in the DT bindings.  All other users of similar I2C GPIO
expanders just use the compatible values of the original NXP parts.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - New.
---
 arch/arm/boot/dts/dra7-evm.dts          | 6 +++---
 arch/arm/boot/dts/dra72-evm-common.dtsi | 4 ++--
 arch/arm/boot/dts/dra76-evm.dts         | 6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index 3dcb6e1f49bcf1f0..87deb6a76eff3602 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -319,7 +319,7 @@ sysen2: sysen2 {
 	};
 
 	pcf_lcd: gpio@20 {
-		compatible = "ti,pcf8575", "nxp,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x20>;
 		gpio-controller;
 		#gpio-cells = <2>;
@@ -330,7 +330,7 @@ pcf_lcd: gpio@20 {
 	};
 
 	pcf_gpio_21: gpio@21 {
-		compatible = "ti,pcf8575", "nxp,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x21>;
 		lines-initial-states = <0x1408>;
 		gpio-controller;
@@ -362,7 +362,7 @@ &i2c2 {
 	clock-frequency = <400000>;
 
 	pcf_hdmi: gpio@26 {
-		compatible = "ti,pcf8575", "nxp,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x26>;
 		gpio-controller;
 		#gpio-cells = <2>;
diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi
index f2384277d5dcdc5c..f12825268188e493 100644
--- a/arch/arm/boot/dts/dra72-evm-common.dtsi
+++ b/arch/arm/boot/dts/dra72-evm-common.dtsi
@@ -226,7 +226,7 @@ pcf_lcd: gpio@20 {
 	};
 
 	pcf_gpio_21: gpio@21 {
-		compatible = "ti,pcf8575", "nxp,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x21>;
 		lines-initial-states = <0x1408>;
 		gpio-controller;
@@ -256,7 +256,7 @@ &i2c5 {
 	clock-frequency = <400000>;
 
 	pcf_hdmi: pcf8575@26 {
-		compatible = "ti,pcf8575", "nxp,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x26>;
 		gpio-controller;
 		#gpio-cells = <2>;
diff --git a/arch/arm/boot/dts/dra76-evm.dts b/arch/arm/boot/dts/dra76-evm.dts
index df47ea59c9c404c2..90e036ac6ffb5197 100644
--- a/arch/arm/boot/dts/dra76-evm.dts
+++ b/arch/arm/boot/dts/dra76-evm.dts
@@ -355,7 +355,7 @@ buck23_reg: buck23 {
 	};
 
 	pcf_lcd: pcf8757@20 {
-		compatible = "ti,pcf8575", "nxp,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x20>;
 		gpio-controller;
 		#gpio-cells = <2>;
@@ -366,7 +366,7 @@ pcf_lcd: pcf8757@20 {
 	};
 
 	pcf_gpio_21: pcf8757@21 {
-		compatible = "ti,pcf8575", "nxp,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x21>;
 		gpio-controller;
 		#gpio-cells = <2>;
@@ -377,7 +377,7 @@ pcf_gpio_21: pcf8757@21 {
 	};
 
 	pcf_hdmi: pcf8575@26 {
-		compatible = "ti,pcf8575", "nxp,pcf8575";
+		compatible = "nxp,pcf8575";
 		reg = <0x26>;
 		gpio-controller;
 		#gpio-cells = <2>;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v2 3/4] x86: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575"
  2021-06-01 15:25 [PATCH v2 0/4] pcf857x: DTS fixes and DT binding to json-schema conversion Geert Uytterhoeven
  2021-06-01 15:25 ` [PATCH v2 1/4] dt-bindings: i2c: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575" Geert Uytterhoeven
  2021-06-01 15:25 ` [PATCH v2 2/4] ARM: dts: dra7x-evm: Drop "ti,pcf8575" Geert Uytterhoeven
@ 2021-06-01 15:25 ` Geert Uytterhoeven
  2021-06-01 15:30   ` Andy Shevchenko
  2021-06-01 15:25 ` [PATCH v2 4/4] dt-bindings: gpio: pcf857x: Convert to json-schema Geert Uytterhoeven
  3 siblings, 1 reply; 13+ messages in thread
From: Geert Uytterhoeven @ 2021-06-01 15:25 UTC (permalink / raw)
  To: Rob Herring, Laurent Pinchart, Linus Walleij,
	Bartosz Golaszewski, Benoît Cousson, Tony Lindgren,
	Darren Hart, Andy Shevchenko, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H . Peter Anvin
  Cc: devicetree, linux-gpio, x86, linux-omap, linux-i2c,
	platform-driver-x86, Geert Uytterhoeven

The TI part is equivalent to the NXP part, and its compatible value is
not documented in the DT bindings.

Note that while the Linux driver DT match table does not contain the
compatible value of the TI part, it could still match to this part, as
i2c_device_id-based matching ignores the vendor part of the compatible
value.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - New.
---
 arch/x86/platform/ce4100/falconfalls.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/platform/ce4100/falconfalls.dts b/arch/x86/platform/ce4100/falconfalls.dts
index 0ac3d43571361112..65fa3d866226ce97 100644
--- a/arch/x86/platform/ce4100/falconfalls.dts
+++ b/arch/x86/platform/ce4100/falconfalls.dts
@@ -249,7 +249,7 @@ i2c@1 {
 
 						gpio@26 {
 							#gpio-cells = <2>;
-							compatible = "ti,pcf8575";
+							compatible = "nxp,pcf8575";
 							reg = <0x26>;
 							gpio-controller;
 						};
@@ -263,7 +263,7 @@ i2c@2 {
 
 						gpio@26 {
 							#gpio-cells = <2>;
-							compatible = "ti,pcf8575";
+							compatible = "nxp,pcf8575";
 							reg = <0x26>;
 							gpio-controller;
 						};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v2 4/4] dt-bindings: gpio: pcf857x: Convert to json-schema
  2021-06-01 15:25 [PATCH v2 0/4] pcf857x: DTS fixes and DT binding to json-schema conversion Geert Uytterhoeven
                   ` (2 preceding siblings ...)
  2021-06-01 15:25 ` [PATCH v2 3/4] x86: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575" Geert Uytterhoeven
@ 2021-06-01 15:25 ` Geert Uytterhoeven
  2021-06-04 21:52   ` Rob Herring
                     ` (2 more replies)
  3 siblings, 3 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2021-06-01 15:25 UTC (permalink / raw)
  To: Rob Herring, Laurent Pinchart, Linus Walleij,
	Bartosz Golaszewski, Benoît Cousson, Tony Lindgren,
	Darren Hart, Andy Shevchenko, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H . Peter Anvin
  Cc: devicetree, linux-gpio, x86, linux-omap, linux-i2c,
	platform-driver-x86, Geert Uytterhoeven

Convert the PCF857x-compatible I/O expanders Device Tree binding
documentation to json-schema.

Document missing compatible values, properties, and gpio hogs.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Drop support for "ti,pcf8575", as it's 100% compatible with
    "nxp,pcf8575",
  - Drop "hog-[0-9]+" from hog names,
  - Rely on dt-schema/schemas/gpio/gpio-hog.yaml for hog properties.
---
 .../devicetree/bindings/gpio/gpio-pcf857x.txt |  69 ------------
 .../devicetree/bindings/gpio/nxp,pcf8575.yaml | 103 ++++++++++++++++++
 2 files changed, 103 insertions(+), 69 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
 create mode 100644 Documentation/devicetree/bindings/gpio/nxp,pcf8575.yaml

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt b/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
deleted file mode 100644
index a482455a205b0855..0000000000000000
--- a/Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
+++ /dev/null
@@ -1,69 +0,0 @@
-* PCF857x-compatible I/O expanders
-
-The PCF857x-compatible chips have "quasi-bidirectional" I/O lines that can be
-driven high by a pull-up current source or driven low to ground. This combines
-the direction and output level into a single bit per line, which can't be read
-back. We can't actually know at initialization time whether a line is configured
-(a) as output and driving the signal low/high, or (b) as input and reporting a
-low/high value, without knowing the last value written since the chip came out
-of reset (if any). The only reliable solution for setting up line direction is
-thus to do it explicitly.
-
-Required Properties:
-
-  - compatible: should be one of the following.
-    - "maxim,max7328": For the Maxim MAX7378
-    - "maxim,max7329": For the Maxim MAX7329
-    - "nxp,pca8574": For the NXP PCA8574
-    - "nxp,pca8575": For the NXP PCA8575
-    - "nxp,pca9670": For the NXP PCA9670
-    - "nxp,pca9671": For the NXP PCA9671
-    - "nxp,pca9672": For the NXP PCA9672
-    - "nxp,pca9673": For the NXP PCA9673
-    - "nxp,pca9674": For the NXP PCA9674
-    - "nxp,pca9675": For the NXP PCA9675
-    - "nxp,pcf8574": For the NXP PCF8574
-    - "nxp,pcf8574a": For the NXP PCF8574A
-    - "nxp,pcf8575": For the NXP PCF8575
-
-  - reg: I2C slave address.
-
-  - gpio-controller: Marks the device node as a gpio controller.
-  - #gpio-cells: Should be 2. The first cell is the GPIO number and the second
-    cell specifies GPIO flags, as defined in <dt-bindings/gpio/gpio.h>. Only the
-    GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW flags are supported.
-
-Optional Properties:
-
-  - lines-initial-states: Bitmask that specifies the initial state of each
-  line. When a bit is set to zero, the corresponding line will be initialized to
-  the input (pulled-up) state. When the  bit is set to one, the line will be
-  initialized the low-level output state. If the property is not specified
-  all lines will be initialized to the input state.
-
-  The I/O expander can detect input state changes, and thus optionally act as
-  an interrupt controller. When the expander interrupt line is connected all the
-  following properties must be set. For more information please see the
-  interrupt controller device tree bindings documentation available at
-  Documentation/devicetree/bindings/interrupt-controller/interrupts.txt.
-
-  - interrupt-controller: Identifies the node as an interrupt controller.
-  - #interrupt-cells: Number of cells to encode an interrupt source, shall be 2.
-  - interrupts: Interrupt specifier for the controllers interrupt.
-
-
-Please refer to gpio.txt in this directory for details of the common GPIO
-bindings used by client devices.
-
-Example: PCF8575 I/O expander node
-
-	pcf8575: gpio@20 {
-		compatible = "nxp,pcf8575";
-		reg = <0x20>;
-		interrupt-parent = <&irqpin2>;
-		interrupts = <3 0>;
-		gpio-controller;
-		#gpio-cells = <2>;
-		interrupt-controller;
-		#interrupt-cells = <2>;
-	};
diff --git a/Documentation/devicetree/bindings/gpio/nxp,pcf8575.yaml b/Documentation/devicetree/bindings/gpio/nxp,pcf8575.yaml
new file mode 100644
index 0000000000000000..f0ff66c4c74e252d
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/nxp,pcf8575.yaml
@@ -0,0 +1,103 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/nxp,pcf8575.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: PCF857x-compatible I/O expanders
+
+maintainers:
+  - Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
+
+description:
+  The PCF857x-compatible chips have "quasi-bidirectional" I/O lines that can be
+  driven high by a pull-up current source or driven low to ground. This
+  combines the direction and output level into a single bit per line, which
+  can't be read back. We can't actually know at initialization time whether a
+  line is configured (a) as output and driving the signal low/high, or (b) as
+  input and reporting a low/high value, without knowing the last value written
+  since the chip came out of reset (if any). The only reliable solution for
+  setting up line direction is thus to do it explicitly.
+
+properties:
+  compatible:
+    enum:
+      - maxim,max7328
+      - maxim,max7329
+      - nxp,pca8574
+      - nxp,pca8575
+      - nxp,pca9670
+      - nxp,pca9671
+      - nxp,pca9672
+      - nxp,pca9673
+      - nxp,pca9674
+      - nxp,pca9675
+      - nxp,pcf8574
+      - nxp,pcf8574a
+      - nxp,pcf8575
+
+  reg:
+    maxItems: 1
+
+  gpio-controller: true
+
+  '#gpio-cells':
+    const: 2
+    description:
+      The first cell is the GPIO number and the second cell specifies GPIO
+      flags, as defined in <dt-bindings/gpio/gpio.h>. Only the GPIO_ACTIVE_HIGH
+      and GPIO_ACTIVE_LOW flags are supported.
+
+  lines-initial-states:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Bitmask that specifies the initial state of each line.
+      When a bit is set to zero, the corresponding line will be initialized to
+      the input (pulled-up) state.
+      When the  bit is set to one, the line will be initialized to the
+      low-level output state.
+      If the property is not specified all lines will be initialized to the
+      input state.
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-controller: true
+
+  '#interrupt-cells':
+    const: 2
+
+  wakeup-source: true
+
+patternProperties:
+  "^(.+-hog(-[0-9]+)?)$":
+    type: object
+
+    required:
+      - gpio-hog
+
+required:
+  - compatible
+  - reg
+  - gpio-controller
+  - '#gpio-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            pcf8575: gpio@20 {
+                    compatible = "nxp,pcf8575";
+                    reg = <0x20>;
+                    interrupt-parent = <&irqpin2>;
+                    interrupts = <3 0>;
+                    gpio-controller;
+                    #gpio-cells = <2>;
+                    interrupt-controller;
+                    #interrupt-cells = <2>;
+            };
+    };
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH v2 3/4] x86: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575"
  2021-06-01 15:25 ` [PATCH v2 3/4] x86: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575" Geert Uytterhoeven
@ 2021-06-01 15:30   ` Andy Shevchenko
  0 siblings, 0 replies; 13+ messages in thread
From: Andy Shevchenko @ 2021-06-01 15:30 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rob Herring, Laurent Pinchart, Linus Walleij,
	Bartosz Golaszewski, Benoît Cousson, Tony Lindgren,
	Darren Hart, Andy Shevchenko, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H . Peter Anvin, devicetree,
	open list:GPIO SUBSYSTEM,
	maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
	Linux OMAP Mailing List, linux-i2c, Platform Driver

On Tue, Jun 1, 2021 at 6:26 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> The TI part is equivalent to the NXP part, and its compatible value is
> not documented in the DT bindings.
>
> Note that while the Linux driver DT match table does not contain the
> compatible value of the TI part, it could still match to this part, as
> i2c_device_id-based matching ignores the vendor part of the compatible
> value.

LGTM!
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Maybe at some point I will find the time to resurrect the CE4100 based
device that collects dirt on my desk...

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - New.
> ---
>  arch/x86/platform/ce4100/falconfalls.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/platform/ce4100/falconfalls.dts b/arch/x86/platform/ce4100/falconfalls.dts
> index 0ac3d43571361112..65fa3d866226ce97 100644
> --- a/arch/x86/platform/ce4100/falconfalls.dts
> +++ b/arch/x86/platform/ce4100/falconfalls.dts
> @@ -249,7 +249,7 @@ i2c@1 {
>
>                                                 gpio@26 {
>                                                         #gpio-cells = <2>;
> -                                                       compatible = "ti,pcf8575";
> +                                                       compatible = "nxp,pcf8575";
>                                                         reg = <0x26>;
>                                                         gpio-controller;
>                                                 };
> @@ -263,7 +263,7 @@ i2c@2 {
>
>                                                 gpio@26 {
>                                                         #gpio-cells = <2>;
> -                                                       compatible = "ti,pcf8575";
> +                                                       compatible = "nxp,pcf8575";
>                                                         reg = <0x26>;
>                                                         gpio-controller;
>                                                 };
> --
> 2.25.1
>


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2 1/4] dt-bindings: i2c: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575"
  2021-06-01 15:25 ` [PATCH v2 1/4] dt-bindings: i2c: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575" Geert Uytterhoeven
@ 2021-06-04 20:27   ` Wolfram Sang
  2021-06-04 21:50     ` Rob Herring
  2021-06-20 21:08   ` Wolfram Sang
  1 sibling, 1 reply; 13+ messages in thread
From: Wolfram Sang @ 2021-06-04 20:27 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rob Herring, Laurent Pinchart, Linus Walleij,
	Bartosz Golaszewski, Benoît Cousson, Tony Lindgren,
	Darren Hart, Andy Shevchenko, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H . Peter Anvin, devicetree, linux-gpio, x86,
	linux-omap, linux-i2c, platform-driver-x86

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

On Tue, Jun 01, 2021 at 05:25:44PM +0200, Geert Uytterhoeven wrote:
> The TI part is equivalent to the NXP part, and its compatible value is
> not documented in the DT bindings.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

I'd think I pick this individually? Or shall it all go via some tree?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2 1/4] dt-bindings: i2c: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575"
  2021-06-04 20:27   ` Wolfram Sang
@ 2021-06-04 21:50     ` Rob Herring
  0 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2021-06-04 21:50 UTC (permalink / raw)
  To: Wolfram Sang, Geert Uytterhoeven, Laurent Pinchart,
	Linus Walleij, Bartosz Golaszewski, Benoît Cousson,
	Tony Lindgren, Darren Hart, Andy Shevchenko, Thomas Gleixner,
	Ingo Molnar, Borislav Petkov, H . Peter Anvin, devicetree,
	linux-gpio, x86, linux-omap, linux-i2c, platform-driver-x86

On Fri, Jun 04, 2021 at 10:27:28PM +0200, Wolfram Sang wrote:
> On Tue, Jun 01, 2021 at 05:25:44PM +0200, Geert Uytterhoeven wrote:
> > The TI part is equivalent to the NXP part, and its compatible value is
> > not documented in the DT bindings.
> > 
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> I'd think I pick this individually? Or shall it all go via some tree?

Yes, you can take it.

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2 4/4] dt-bindings: gpio: pcf857x: Convert to json-schema
  2021-06-01 15:25 ` [PATCH v2 4/4] dt-bindings: gpio: pcf857x: Convert to json-schema Geert Uytterhoeven
@ 2021-06-04 21:52   ` Rob Herring
  2021-06-04 22:05   ` Linus Walleij
  2021-06-25 10:35   ` Bartosz Golaszewski
  2 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2021-06-04 21:52 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Benoît Cousson, x86, devicetree, Laurent Pinchart,
	Andy Shevchenko, Ingo Molnar, Borislav Petkov, linux-omap,
	platform-driver-x86, Linus Walleij, Bartosz Golaszewski,
	H . Peter Anvin, Thomas Gleixner, Tony Lindgren, linux-gpio,
	linux-i2c, Rob Herring, Darren Hart

On Tue, 01 Jun 2021 17:25:47 +0200, Geert Uytterhoeven wrote:
> Convert the PCF857x-compatible I/O expanders Device Tree binding
> documentation to json-schema.
> 
> Document missing compatible values, properties, and gpio hogs.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Drop support for "ti,pcf8575", as it's 100% compatible with
>     "nxp,pcf8575",
>   - Drop "hog-[0-9]+" from hog names,
>   - Rely on dt-schema/schemas/gpio/gpio-hog.yaml for hog properties.
> ---
>  .../devicetree/bindings/gpio/gpio-pcf857x.txt |  69 ------------
>  .../devicetree/bindings/gpio/nxp,pcf8575.yaml | 103 ++++++++++++++++++
>  2 files changed, 103 insertions(+), 69 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
>  create mode 100644 Documentation/devicetree/bindings/gpio/nxp,pcf8575.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2 4/4] dt-bindings: gpio: pcf857x: Convert to json-schema
  2021-06-01 15:25 ` [PATCH v2 4/4] dt-bindings: gpio: pcf857x: Convert to json-schema Geert Uytterhoeven
  2021-06-04 21:52   ` Rob Herring
@ 2021-06-04 22:05   ` Linus Walleij
  2021-06-25 10:35   ` Bartosz Golaszewski
  2 siblings, 0 replies; 13+ messages in thread
From: Linus Walleij @ 2021-06-04 22:05 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rob Herring, Laurent Pinchart, Bartosz Golaszewski,
	Benoît Cousson, Tony Lindgren, Darren Hart, Andy Shevchenko,
	Thomas Gleixner, Ingo Molnar, Borislav Petkov, H . Peter Anvin,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:GPIO SUBSYSTEM,
	maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
	Linux-OMAP, linux-i2c, platform-driver-x86

On Tue, Jun 1, 2021 at 5:25 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:

> Convert the PCF857x-compatible I/O expanders Device Tree binding
> documentation to json-schema.
>
> Document missing compatible values, properties, and gpio hogs.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2 2/4] ARM: dts: dra7x-evm: Drop "ti,pcf8575"
  2021-06-01 15:25 ` [PATCH v2 2/4] ARM: dts: dra7x-evm: Drop "ti,pcf8575" Geert Uytterhoeven
@ 2021-06-11  7:33   ` Tony Lindgren
  0 siblings, 0 replies; 13+ messages in thread
From: Tony Lindgren @ 2021-06-11  7:33 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rob Herring, Laurent Pinchart, Linus Walleij,
	Bartosz Golaszewski, Benoît Cousson, Darren Hart,
	Andy Shevchenko, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
	H . Peter Anvin, devicetree, linux-gpio, x86, linux-omap,
	linux-i2c, platform-driver-x86

* Geert Uytterhoeven <geert+renesas@glider.be> [210601 18:26]:
> The TI part is equivalent to the NXP part and its compatible value is
> not documented in the DT bindings.  All other users of similar I2C GPIO
> expanders just use the compatible values of the original NXP parts.

Picking this patch into omap-for-v5.14/dt thanks.

Tony

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2 1/4] dt-bindings: i2c: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575"
  2021-06-01 15:25 ` [PATCH v2 1/4] dt-bindings: i2c: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575" Geert Uytterhoeven
  2021-06-04 20:27   ` Wolfram Sang
@ 2021-06-20 21:08   ` Wolfram Sang
  1 sibling, 0 replies; 13+ messages in thread
From: Wolfram Sang @ 2021-06-20 21:08 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rob Herring, Laurent Pinchart, Linus Walleij,
	Bartosz Golaszewski, Benoît Cousson, Tony Lindgren,
	Darren Hart, Andy Shevchenko, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H . Peter Anvin, devicetree, linux-gpio, x86,
	linux-omap, linux-i2c, platform-driver-x86

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

On Tue, Jun 01, 2021 at 05:25:44PM +0200, Geert Uytterhoeven wrote:
> The TI part is equivalent to the NXP part, and its compatible value is
> not documented in the DT bindings.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2 4/4] dt-bindings: gpio: pcf857x: Convert to json-schema
  2021-06-01 15:25 ` [PATCH v2 4/4] dt-bindings: gpio: pcf857x: Convert to json-schema Geert Uytterhoeven
  2021-06-04 21:52   ` Rob Herring
  2021-06-04 22:05   ` Linus Walleij
@ 2021-06-25 10:35   ` Bartosz Golaszewski
  2 siblings, 0 replies; 13+ messages in thread
From: Bartosz Golaszewski @ 2021-06-25 10:35 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rob Herring, Laurent Pinchart, Linus Walleij,
	Benoît Cousson, Tony Lindgren, Darren Hart, Andy Shevchenko,
	Thomas Gleixner, Ingo Molnar, Borislav Petkov, H . Peter Anvin,
	linux-devicetree, linux-gpio, x86, Linux-OMAP, linux-i2c,
	platform-driver-x86

On Tue, Jun 1, 2021 at 5:25 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> Convert the PCF857x-compatible I/O expanders Device Tree binding
> documentation to json-schema.
>
> Document missing compatible values, properties, and gpio hogs.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Applied with Linus' and Rob's tags.

Bart

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2021-06-25 10:35 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 15:25 [PATCH v2 0/4] pcf857x: DTS fixes and DT binding to json-schema conversion Geert Uytterhoeven
2021-06-01 15:25 ` [PATCH v2 1/4] dt-bindings: i2c: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575" Geert Uytterhoeven
2021-06-04 20:27   ` Wolfram Sang
2021-06-04 21:50     ` Rob Herring
2021-06-20 21:08   ` Wolfram Sang
2021-06-01 15:25 ` [PATCH v2 2/4] ARM: dts: dra7x-evm: Drop "ti,pcf8575" Geert Uytterhoeven
2021-06-11  7:33   ` Tony Lindgren
2021-06-01 15:25 ` [PATCH v2 3/4] x86: ce4100: Replace "ti,pcf8575" by "nxp,pcf8575" Geert Uytterhoeven
2021-06-01 15:30   ` Andy Shevchenko
2021-06-01 15:25 ` [PATCH v2 4/4] dt-bindings: gpio: pcf857x: Convert to json-schema Geert Uytterhoeven
2021-06-04 21:52   ` Rob Herring
2021-06-04 22:05   ` Linus Walleij
2021-06-25 10:35   ` Bartosz Golaszewski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.