From: Wei Liu <wei.liu@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Wei Liu <wei.liu@kernel.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
bhelgaas@google.com, lorenzo.pieralisi@arm.com,
linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
kys@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci-hyperv: Add check for hyperv_initialized in init_hv_pci_drv()
Date: Sat, 5 Jun 2021 10:40:21 +0000 [thread overview]
Message-ID: <20210605104021.amywuuhlyesgmybw@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20210604212622.GA2241239@bjorn-Precision-5520>
On Fri, Jun 04, 2021 at 04:26:22PM -0500, Bjorn Helgaas wrote:
> On Wed, Jun 02, 2021 at 10:32:06AM +0000, Wei Liu wrote:
> > On Tue, May 25, 2021 at 04:17:33PM -0700, Haiyang Zhang wrote:
> > > Add check for hv_is_hyperv_initialized() at the top of init_hv_pci_drv(),
> > > so if the pci-hyperv driver is force-loaded on non Hyper-V platforms, the
> > > init_hv_pci_drv() will exit immediately, without any side effects, like
> > > assignments to hvpci_block_ops, etc.
> > >
> > > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > > Reported-and-tested-by: Mohammad Alqayeem <mohammad.alqyeem@nutanix.com>
> >
> > Hello PCI subsystem maintainers, are you going to take this patch or
> > shall I?
>
> This was mistakenly assigned to me, so I reassigned it back to
> Lorenzo.
>
> If you *do* take this, please at least update it to follow the PCI
> commit log conventions, e.g.,
>
> PCI: hv: Add check ...
>
> and wrap the text so it fits in 75 columns.
Lorenzo already picked up two Hyper-V PCI patches from Long Li. I think
leaving this to him is better.
Wei.
next prev parent reply other threads:[~2021-06-05 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 23:17 [PATCH] pci-hyperv: Add check for hyperv_initialized in init_hv_pci_drv() Haiyang Zhang
2021-05-26 10:08 ` Wei Liu
2021-06-02 10:32 ` Wei Liu
2021-06-04 21:26 ` Bjorn Helgaas
2021-06-05 10:40 ` Wei Liu [this message]
2021-06-18 13:22 ` Wei Liu
2021-06-18 13:26 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210605104021.amywuuhlyesgmybw@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=bhelgaas@google.com \
--cc=haiyangz@microsoft.com \
--cc=helgaas@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.