From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] scipts/autobuild-run: properly import urllib2.URLError
Date: Sat, 5 Jun 2021 23:00:16 +0200 [thread overview]
Message-ID: <20210605210016.1157351-1-yann.morin.1998@free.fr> (raw)
Commit 37766e9 (scripts/autobuild-run: add a retry loop to not fail on
urllib URLError) introduced an import of URLError, but that raises
exceptions in both python2 and python3:
$ python2 -c 'import urllib2.URLError as URLError'
Traceback (most recent call last):
File "<string>", line 1, in <module>
ImportError: No module named URLError
$ python3 -c 'import urllib.error.URLError as URLError'
Traceback (most recent call last):
File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'urllib.error.URLError'; 'urllib.error' is not a package
The working solution is to import from:
$ python2 -c 'from urllib2 import URLError; raise URLError(None)'
Traceback (most recent call last):
File "<string>", line 1, in <module>
urllib2.URLError: <urlopen error None>
$ python3 -c 'from urllib.error import URLError; raise URLError(None)'
Traceback (most recent call last):
File "<string>", line 1, in <module>
urllib.error.URLError: <urlopen error None>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
scripts/autobuild-run | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 84e4d40..346928f 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -151,12 +151,12 @@ if sys.hexversion >= 0x3000000:
import configparser
import urllib.request as _urllib
import urllib.parse as urlparse
- import urllib.error.URLError as URLError
+ from urllib.error import URLError
else:
import ConfigParser as configparser
import urllib2 as _urllib
import urlparse
- import urllib2.URLError as URLError
+ from urllib2 import URLError
urlopen = _urllib.urlopen
urlopen_closing = lambda uri: contextlib.closing(urlopen(uri))
--
2.25.1
next reply other threads:[~2021-06-05 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 21:00 Yann E. MORIN [this message]
2021-06-05 21:05 ` [Buildroot] [PATCH] scipts/autobuild-run: properly import urllib2.URLError Thomas Petazzoni
2021-06-06 7:20 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210605210016.1157351-1-yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.