All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] scipts/autobuild-run: properly import urllib2.URLError
@ 2021-06-05 21:00 Yann E. MORIN
  2021-06-05 21:05 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2021-06-05 21:00 UTC (permalink / raw)
  To: buildroot

Commit 37766e9 (scripts/autobuild-run: add a retry loop to not fail on
urllib URLError) introduced an import of URLError, but that raises
exceptions in both python2 and python3:

    $ python2 -c 'import urllib2.URLError as URLError'
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
    ImportError: No module named URLError

    $ python3 -c 'import urllib.error.URLError as URLError'
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
    ModuleNotFoundError: No module named 'urllib.error.URLError'; 'urllib.error' is not a package

The working solution is to import from:

    $ python2 -c 'from urllib2 import URLError; raise URLError(None)'
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
    urllib2.URLError: <urlopen error None>

    $ python3 -c 'from urllib.error import URLError; raise URLError(None)'
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
    urllib.error.URLError: <urlopen error None>

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 scripts/autobuild-run | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 84e4d40..346928f 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -151,12 +151,12 @@ if sys.hexversion >= 0x3000000:
     import configparser
     import urllib.request as _urllib
     import urllib.parse as urlparse
-    import urllib.error.URLError as URLError
+    from urllib.error import URLError
 else:
     import ConfigParser as configparser
     import urllib2 as _urllib
     import urlparse
-    import urllib2.URLError as URLError
+    from urllib2 import URLError
 
 urlopen = _urllib.urlopen
 urlopen_closing = lambda uri: contextlib.closing(urlopen(uri))
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] scipts/autobuild-run: properly import urllib2.URLError
  2021-06-05 21:00 [Buildroot] [PATCH] scipts/autobuild-run: properly import urllib2.URLError Yann E. MORIN
@ 2021-06-05 21:05 ` Thomas Petazzoni
  2021-06-06  7:20   ` Yann E. MORIN
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2021-06-05 21:05 UTC (permalink / raw)
  To: buildroot

On Sat,  5 Jun 2021 23:00:16 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Commit 37766e9 (scripts/autobuild-run: add a retry loop to not fail on
> urllib URLError) introduced an import of URLError, but that raises
> exceptions in both python2 and python3:
> 
>     $ python2 -c 'import urllib2.URLError as URLError'
>     Traceback (most recent call last):
>       File "<string>", line 1, in <module>
>     ImportError: No module named URLError
> 
>     $ python3 -c 'import urllib.error.URLError as URLError'
>     Traceback (most recent call last):
>       File "<string>", line 1, in <module>
>     ModuleNotFoundError: No module named 'urllib.error.URLError'; 'urllib.error' is not a package
> 
> The working solution is to import from:
> 
>     $ python2 -c 'from urllib2 import URLError; raise URLError(None)'
>     Traceback (most recent call last):
>       File "<string>", line 1, in <module>
>     urllib2.URLError: <urlopen error None>
> 
>     $ python3 -c 'from urllib.error import URLError; raise URLError(None)'
>     Traceback (most recent call last):
>       File "<string>", line 1, in <module>
>     urllib.error.URLError: <urlopen error None>
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] scipts/autobuild-run: properly import urllib2.URLError
  2021-06-05 21:05 ` Thomas Petazzoni
@ 2021-06-06  7:20   ` Yann E. MORIN
  0 siblings, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-06-06  7:20 UTC (permalink / raw)
  To: buildroot

All,

On 2021-06-05 23:05 +0200, Thomas Petazzoni spake thusly:
> On Sat,  5 Jun 2021 23:00:16 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > Commit 37766e9 (scripts/autobuild-run: add a retry loop to not fail on
> > urllib URLError) introduced an import of URLError, but that raises
> > exceptions in both python2 and python3:
[--SNIP--]
> > The working solution is to import from:
[--SNIP--]
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master (on buildroot-test), thanks.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-06  7:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-05 21:00 [Buildroot] [PATCH] scipts/autobuild-run: properly import urllib2.URLError Yann E. MORIN
2021-06-05 21:05 ` Thomas Petazzoni
2021-06-06  7:20   ` Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.