* [irqchip: irq/irqchip-next] MIPS: Do not include linux/irqdomain.h from asm/irq.h
@ 2021-06-06 12:43 irqchip-bot for Marc Zyngier
2021-06-06 15:32 ` kernel test robot
0 siblings, 1 reply; 4+ messages in thread
From: irqchip-bot for Marc Zyngier @ 2021-06-06 12:43 UTC (permalink / raw)
To: linux-kernel; +Cc: Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 86e8aea3d7a70068fad33aa5b7d7e3084240b23a
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/86e8aea3d7a70068fad33aa5b7d7e3084240b23a
Author: Marc Zyngier <maz@kernel.org>
AuthorDate: Wed, 12 Sep 2018 16:11:20 +01:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Wed, 02 Jun 2021 14:34:47 +01:00
MIPS: Do not include linux/irqdomain.h from asm/irq.h
Including linux/irqdomain.h from asm/irq.h is going to break
as soon as linux/irqdomain.h will include linux/irq.h, so
let's fix this. Code relying on linux/irqomain.h should include
it directly.
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
arch/mips/include/asm/irq.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h
index f021de6..d1477ec 100644
--- a/arch/mips/include/asm/irq.h
+++ b/arch/mips/include/asm/irq.h
@@ -11,7 +11,6 @@
#include <linux/linkage.h>
#include <linux/smp.h>
-#include <linux/irqdomain.h>
#include <asm/mipsmtregs.h>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [irqchip: irq/irqchip-next] MIPS: Do not include linux/irqdomain.h from asm/irq.h
2021-06-06 12:43 [irqchip: irq/irqchip-next] MIPS: Do not include linux/irqdomain.h from asm/irq.h irqchip-bot for Marc Zyngier
@ 2021-06-06 15:32 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-06-06 15:32 UTC (permalink / raw)
To: irqchip-bot for Marc Zyngier, linux-kernel; +Cc: kbuild-all, Marc Zyngier, tglx
[-- Attachment #1: Type: text/plain, Size: 2880 bytes --]
Hi irqchip-bot,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.13-rc4 next-20210604]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/irqchip-bot-for-Marc-Zyngier/MIPS-Do-not-include-linux-irqdomain-h-from-asm-irq-h/20210606-205208
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd860052c99b1e088352bdd4fb7aef46f8d2ef47
config: mips-xway_defconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/09879bee8f56d44f0bd49d7dba858ff743a608bf
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review irqchip-bot-for-Marc-Zyngier/MIPS-Do-not-include-linux-irqdomain-h-from-asm-irq-h/20210606-205208
git checkout 09879bee8f56d44f0bd49d7dba858ff743a608bf
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> arch/mips/lantiq/xway/dma.c:243:34: error: array type has incomplete element type 'struct of_device_id'
243 | static const struct of_device_id dma_match[] = {
| ^~~~~~~~~
>> arch/mips/lantiq/xway/dma.c:244:4: error: field name not in record or union initializer
244 | { .compatible = "lantiq,dma-xway" },
| ^
arch/mips/lantiq/xway/dma.c:244:4: note: (near initialization for 'dma_match')
arch/mips/lantiq/xway/dma.c:257:1: warning: no previous prototype for 'dma_init' [-Wmissing-prototypes]
257 | dma_init(void)
| ^~~~~~~~
arch/mips/lantiq/xway/dma.c:243:34: warning: 'dma_match' defined but not used [-Wunused-variable]
243 | static const struct of_device_id dma_match[] = {
| ^~~~~~~~~
vim +243 arch/mips/lantiq/xway/dma.c
dfec1a827d2bdc John Crispin 2011-05-06 242
ddd4eeca961cc6 John Crispin 2012-04-12 @243 static const struct of_device_id dma_match[] = {
ddd4eeca961cc6 John Crispin 2012-04-12 @244 { .compatible = "lantiq,dma-xway" },
ddd4eeca961cc6 John Crispin 2012-04-12 245 {},
ddd4eeca961cc6 John Crispin 2012-04-12 246 };
ddd4eeca961cc6 John Crispin 2012-04-12 247
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 18554 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [irqchip: irq/irqchip-next] MIPS: Do not include linux/irqdomain.h from asm/irq.h
@ 2021-06-06 15:32 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-06-06 15:32 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2938 bytes --]
Hi irqchip-bot,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.13-rc4 next-20210604]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/irqchip-bot-for-Marc-Zyngier/MIPS-Do-not-include-linux-irqdomain-h-from-asm-irq-h/20210606-205208
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd860052c99b1e088352bdd4fb7aef46f8d2ef47
config: mips-xway_defconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/09879bee8f56d44f0bd49d7dba858ff743a608bf
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review irqchip-bot-for-Marc-Zyngier/MIPS-Do-not-include-linux-irqdomain-h-from-asm-irq-h/20210606-205208
git checkout 09879bee8f56d44f0bd49d7dba858ff743a608bf
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> arch/mips/lantiq/xway/dma.c:243:34: error: array type has incomplete element type 'struct of_device_id'
243 | static const struct of_device_id dma_match[] = {
| ^~~~~~~~~
>> arch/mips/lantiq/xway/dma.c:244:4: error: field name not in record or union initializer
244 | { .compatible = "lantiq,dma-xway" },
| ^
arch/mips/lantiq/xway/dma.c:244:4: note: (near initialization for 'dma_match')
arch/mips/lantiq/xway/dma.c:257:1: warning: no previous prototype for 'dma_init' [-Wmissing-prototypes]
257 | dma_init(void)
| ^~~~~~~~
arch/mips/lantiq/xway/dma.c:243:34: warning: 'dma_match' defined but not used [-Wunused-variable]
243 | static const struct of_device_id dma_match[] = {
| ^~~~~~~~~
vim +243 arch/mips/lantiq/xway/dma.c
dfec1a827d2bdc John Crispin 2011-05-06 242
ddd4eeca961cc6 John Crispin 2012-04-12 @243 static const struct of_device_id dma_match[] = {
ddd4eeca961cc6 John Crispin 2012-04-12 @244 { .compatible = "lantiq,dma-xway" },
ddd4eeca961cc6 John Crispin 2012-04-12 245 {},
ddd4eeca961cc6 John Crispin 2012-04-12 246 };
ddd4eeca961cc6 John Crispin 2012-04-12 247
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 18554 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [irqchip: irq/irqchip-next] MIPS: Do not include linux/irqdomain.h from asm/irq.h
@ 2021-06-11 13:54 irqchip-bot for Marc Zyngier
0 siblings, 0 replies; 4+ messages in thread
From: irqchip-bot for Marc Zyngier @ 2021-06-11 13:54 UTC (permalink / raw)
To: linux-kernel; +Cc: Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: a12a9c5c03072ec6b1f4f9bd7a554a718ecf234a
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/a12a9c5c03072ec6b1f4f9bd7a554a718ecf234a
Author: Marc Zyngier <maz@kernel.org>
AuthorDate: Wed, 12 Sep 2018 16:11:20 +01:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Thu, 10 Jun 2021 13:09:16 +01:00
MIPS: Do not include linux/irqdomain.h from asm/irq.h
Including linux/irqdomain.h from asm/irq.h is going to break
as soon as linux/irqdomain.h will include linux/irq.h, so
let's fix this. Code relying on linux/irqomain.h should include
it directly.
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
arch/mips/include/asm/irq.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h
index f021de6..d1477ec 100644
--- a/arch/mips/include/asm/irq.h
+++ b/arch/mips/include/asm/irq.h
@@ -11,7 +11,6 @@
#include <linux/linkage.h>
#include <linux/smp.h>
-#include <linux/irqdomain.h>
#include <asm/mipsmtregs.h>
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-11 13:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-06 12:43 [irqchip: irq/irqchip-next] MIPS: Do not include linux/irqdomain.h from asm/irq.h irqchip-bot for Marc Zyngier
2021-06-06 15:32 ` kernel test robot
2021-06-06 15:32 ` kernel test robot
2021-06-11 13:54 irqchip-bot for Marc Zyngier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.