From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 225CAC47082 for ; Mon, 7 Jun 2021 22:26:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02EB161078 for ; Mon, 7 Jun 2021 22:26:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230383AbhFGW20 (ORCPT ); Mon, 7 Jun 2021 18:28:26 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:53194 "EHLO mail.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230183AbhFGW2Z (ORCPT ); Mon, 7 Jun 2021 18:28:25 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 897ED4F6894D6; Mon, 7 Jun 2021 15:26:33 -0700 (PDT) Date: Mon, 07 Jun 2021 15:26:29 -0700 (PDT) Message-Id: <20210607.152629.1604704104944229264.davem@davemloft.net> To: dsahern@kernel.org Cc: netdev@vger.kernel.org, kuba@kernel.org, kasperd@gjkwv.06.feb.2021.kasperd.net, cascardo@canonical.com Subject: Re: [PATCH net] neighbour: allow NUD_NOARP entries to be forced GCed From: David Miller In-Reply-To: <20210607173530.46493-1-dsahern@kernel.org> References: <20210607173530.46493-1-dsahern@kernel.org> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Mon, 07 Jun 2021 15:26:33 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Ahern Date: Mon, 7 Jun 2021 11:35:30 -0600 > IFF_POINTOPOINT interfaces use NUD_NOARP entries for IPv6. It's possible to > fill up the neighbour table with enough entries that it will overflow for > valid connections after that. > > This behaviour is more prevalent after commit 58956317c8de ("neighbor: > Improve garbage collection") is applied, as it prevents removal from > entries that are not NUD_FAILED, unless they are more than 5s old. > > Fixes: 58956317c8de (neighbor: Improve garbage collection) > Reported-by: Kasper Dupont > Signed-off-by: Thadeu Lima de Souza Cascardo > Signed-off-by: David Ahern > --- > rebased to net tree Applied, thanks.