From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C90C4743D for ; Mon, 7 Jun 2021 00:49:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E26BA613C7 for ; Mon, 7 Jun 2021 00:49:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230150AbhFGAvL (ORCPT ); Sun, 6 Jun 2021 20:51:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbhFGAvL (ORCPT ); Sun, 6 Jun 2021 20:51:11 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C6BC061766 for ; Sun, 6 Jun 2021 17:49:04 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id pi6-20020a17090b1e46b029015cec51d7cdso9294760pjb.5 for ; Sun, 06 Jun 2021 17:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EkzmlHTyCHZ4hr2mTxE8K/O/oG80dt6nMc/l9lE4cQQ=; b=eQ7qcYgisztwcej7r7bS4vVY2RbPuDX9Egmzdg+fkkchjMnIrLsL71BAiE5A00lndW BUnGKo+6EubgOt/a0IDJ7zD1UqUa7nnHgCp3V8NZU4oC5cXkhnozfKLWjnleie82erTR xeEyh1KIsu1vWsmS2/3ZrVE7kccQI46ehW8vXBKw/cfqwpcafnguYNxqLdv75NXhbIBA N8jTzVWbqciPHlbn80LR3K9jnt8xzqHxc1WuYxPITfoPbVTT6QATFby1mO5jcZa/qOjM itg/AmPVyWyp6IlR26BLMHTksVvvFeChUmUHj1yEeuQhMIWr8m7V3vLMVOiyA5xVcehH f0vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EkzmlHTyCHZ4hr2mTxE8K/O/oG80dt6nMc/l9lE4cQQ=; b=ik/fgb/oKQMPm4775K2cyG4pgrNOQ6XtU6MEao7bmjOyAvyL2haPsW5eAx+4MahCtz g+wt4ysC2nfTqQmdq7sV5orXccESYN+AdahOjCZ4QegU3kBfnlYRR1bRR8FtHMwZd2sM CElxvWCGjMLouNjLS+xsvTRNiIVHQaT6sd8VKfFkLUXrKk0aWaqVnGHXcCTEvR5B7HEU VlPaMSMKmPLe9nnKBF/7HVGha/jaFB2gZlmkKG6Ol9oM4Zi8OXRKdNnhkT7XMh6UQJj/ k/VfDIodBv41WlVB1/J94JU70BU6+KcgK/jT+YpFS8tdY1gq2CNlIf9K52qjIcfZqhPD dr/Q== X-Gm-Message-State: AOAM530nFe+ymN6Xueixfvp82j2VRFZnPbBDhu9cX1iOD9p4fmWYVofi eX1r+VP5uurXLtuySOGRrw7zRcY/KR/vuw== X-Google-Smtp-Source: ABdhPJx6nXlIoo3RbLdOanMMoodG0+Jt7llzYlMXE/1EvALVEMjDq5WeAt8nwS9ywmhpTpLgEYemSw== X-Received: by 2002:a17:902:a70e:b029:10d:3f69:dff4 with SMTP id w14-20020a170902a70eb029010d3f69dff4mr15612551plq.65.1623026940730; Sun, 06 Jun 2021 17:49:00 -0700 (PDT) Received: from athena.localdomain ([2402:800:63b8:97c0:59aa:7727:6cb5:cccf]) by smtp.gmail.com with ESMTPSA id u13sm7140771pga.64.2021.06.06.17.48.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jun 2021 17:49:00 -0700 (PDT) From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?= To: git@vger.kernel.org Cc: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?= , Taylor Blau , Jeff King , Bagas Sanjaya , =?UTF-8?q?Torsten=20B=C3=B6gershausen?= , Junio C Hamano Subject: [PATCH v3] t: use pre-defined utf-8 locale for testing svn Date: Mon, 7 Jun 2021 07:48:38 +0700 Message-Id: <20210607004838.15235-1-congdanhqx@gmail.com> X-Mailer: git-send-email 2.32.0.rc3.5.gf3d78db977 In-Reply-To: <20210602114646.17463-1-congdanhqx@gmail.com> References: <20210602114646.17463-1-congdanhqx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org In some test-cases, UTF-8 locale is required. To find such locale, we're using the first available UTF-8 locale that returned by "locale -a". However, the locale(1) utility is unavailable on some systems, e.g. Linux with musl libc. However, without "locale -a", we can't guess provided UTF-8 locale. Add a Makefile knob GIT_TEST_UTF8_LOCALE and activate it for linux-musl in our CI system. Rename t/lib-git-svn.sh:prepare_a_utf8_locale to prepare_utf8_locale, since we no longer prepare the variable named "a_utf8_locale", but set up a fallback value for GIT_TEST_UTF8_LOCALE instead. The fallback will be LC_ALL, LANG environment variable, or the first UTF-8 locale from output of "locale -a", in that order. Signed-off-by: Đoàn Trần Công Danh --- Jeff King wrote: > I kind of wonder if trying "C.UTF-8" would be a reasonable fallback so > that people don't even have to set this extra Makefile knob. But I'm not > sure if we have a good way of testing if that locale works (if we can't > find the "locale" binary). I also think we should fallback to "C.UTF-8" instead of not testing those tests. However, I don't know if there're any systems that not have "C.UTF-8" locale. Range-diff against v2: 1: f299ae2239 ! 1: 064cfc0fe3 t: use user-specific utf-8 locale for testing @@ Metadata Author: Đoàn Trần Công Danh ## Commit message ## - t: use user-specific utf-8 locale for testing + t: use pre-defined utf-8 locale for testing svn - In some test-cases, utf-8 locale is required. To find such locale, + In some test-cases, UTF-8 locale is required. To find such locale, we're using the first available UTF-8 locale that returned by "locale -a". - Despite being required by POSIX, locale(1) is unavailable in some - systems, e.g. Linux with musl libc. Some of those systems support - utf-8 locale out of the box. + However, the locale(1) utility is unavailable on some systems, + e.g. Linux with musl libc. However, without "locale -a", we can't guess provided UTF-8 locale. - Let's give users of those systems an option to have better test - coverage. + Add a Makefile knob GIT_TEST_UTF8_LOCALE and activate it for + linux-musl in our CI system. - This change also rename t/lib-git-svn.sh:prepare_a_utf8_locale to - prepare_utf8_locale, since we no longer prepare the variable named - "a_utf8_locale" but set up a fallback value for GIT_TEST_UTF8_LOCALE - instead. The fallback will be LC_ALL, LANG environment variable, - or the first utf-8 locale from output of "locale -a", in that order. + Rename t/lib-git-svn.sh:prepare_a_utf8_locale to prepare_utf8_locale, + since we no longer prepare the variable named "a_utf8_locale", + but set up a fallback value for GIT_TEST_UTF8_LOCALE instead. + The fallback will be LC_ALL, LANG environment variable, + or the first UTF-8 locale from output of "locale -a", in that order. Signed-off-by: Đoàn Trần Công Danh Makefile | 7 +++++++ ci/lib.sh | 1 + t/lib-git-svn.sh | 24 ++++++++++++++++++------ t/t9100-git-svn-basic.sh | 14 +++----------- t/t9115-git-svn-dcommit-funky-renames.sh | 6 +++--- t/t9129-git-svn-i18n-commitencoding.sh | 4 ++-- 6 files changed, 34 insertions(+), 22 deletions(-) diff --git a/Makefile b/Makefile index c3565fc0f8..502e0c9a81 100644 --- a/Makefile +++ b/Makefile @@ -398,6 +398,10 @@ all:: # with a different indexfile format version. If it isn't set the index # file format used is index-v[23]. # +# Define GIT_TEST_UTF8_LOCALE to preferred utf-8 locale for testing. +# If it isn't set, fallback to $LC_ALL, $LANG or use the first utf-8 +# locale returned by "locale -a". +# # Define HAVE_CLOCK_GETTIME if your platform has clock_gettime. # # Define HAVE_CLOCK_MONOTONIC if your platform has CLOCK_MONOTONIC. @@ -2801,6 +2805,9 @@ ifdef GIT_TEST_CMP endif ifdef GIT_TEST_CMP_USE_COPIED_CONTEXT @echo GIT_TEST_CMP_USE_COPIED_CONTEXT=YesPlease >>$@+ +endif +ifdef GIT_TEST_UTF8_LOCALE + @echo GIT_TEST_UTF8_LOCALE=\''$(subst ','\'',$(subst ','\'',$(GIT_TEST_UTF8_LOCALE)))'\' >>$@+ endif @echo NO_GETTEXT=\''$(subst ','\'',$(subst ','\'',$(NO_GETTEXT)))'\' >>$@+ ifdef GIT_PERF_REPEAT_COUNT diff --git a/ci/lib.sh b/ci/lib.sh index d848c036c5..476c3f369f 100755 --- a/ci/lib.sh +++ b/ci/lib.sh @@ -229,6 +229,7 @@ linux-musl) CC=gcc MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=/usr/bin/python3 USE_LIBPCRE2=Yes" MAKEFLAGS="$MAKEFLAGS NO_REGEX=Yes ICONV_OMITS_BOM=Yes" + MAKEFLAGS="$MAKEFLAGS GIT_TEST_UTF8_LOCALE=C.UTF-8" ;; esac diff --git a/t/lib-git-svn.sh b/t/lib-git-svn.sh index 547eb3c31a..83efc17661 100644 --- a/t/lib-git-svn.sh +++ b/t/lib-git-svn.sh @@ -121,12 +121,24 @@ start_svnserve () { --listen-host 127.0.0.1 & } -prepare_a_utf8_locale () { - a_utf8_locale=$(locale -a | sed -n '/\.[uU][tT][fF]-*8$/{ - p - q -}') - if test -n "$a_utf8_locale" +prepare_utf8_locale () { + if test -n "$GIT_TEST_UTF8_LOCALE" + then + : test_set_prereq UTF8 + elif test -n "${LC_ALL:-$LANG}" + then + case "${LC_ALL:-$LANG}" in + *.[Uu][Tt][Ff]8 | *.[Uu][Tt][Ff]-8) + GIT_TEST_UTF8_LOCALE="${LC_ALL:-$LANG}" + ;; + esac + else + GIT_TEST_UTF8_LOCALE=$(locale -a | sed -n '/\.[uU][tT][fF]-*8$/{ + p + q + }') + fi + if test -n "$GIT_TEST_UTF8_LOCALE" then test_set_prereq UTF8 else diff --git a/t/t9100-git-svn-basic.sh b/t/t9100-git-svn-basic.sh index 1d3fdcc997..d5563ec35f 100755 --- a/t/t9100-git-svn-basic.sh +++ b/t/t9100-git-svn-basic.sh @@ -4,21 +4,13 @@ # test_description='git svn basic tests' -GIT_SVN_LC_ALL=${LC_ALL:-$LANG} GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME . ./lib-git-svn.sh -case "$GIT_SVN_LC_ALL" in -*.UTF-8) - test_set_prereq UTF8 - ;; -*) - say "# UTF-8 locale not set, some tests skipped ($GIT_SVN_LC_ALL)" - ;; -esac +prepare_utf8_locale test_expect_success 'git svn --version works anywhere' ' nongit git svn --version @@ -187,8 +179,8 @@ test_expect_success POSIXPERM,SYMLINKS "$name" ' test ! -h "$SVN_TREE"/exec-2.sh && test_cmp help "$SVN_TREE"/exec-2.sh' -name="commit with UTF-8 message: locale: $GIT_SVN_LC_ALL" -LC_ALL="$GIT_SVN_LC_ALL" +name="commit with UTF-8 message: locale: $GIT_TEST_UTF8_LOCALE" +LC_ALL="$GIT_TEST_UTF8_LOCALE" export LC_ALL # This test relies on the previous test, hence requires POSIXPERM,SYMLINKS test_expect_success UTF8,POSIXPERM,SYMLINKS "$name" " diff --git a/t/t9115-git-svn-dcommit-funky-renames.sh b/t/t9115-git-svn-dcommit-funky-renames.sh index 9b44a44bc1..743fbe1fe4 100755 --- a/t/t9115-git-svn-dcommit-funky-renames.sh +++ b/t/t9115-git-svn-dcommit-funky-renames.sh @@ -93,9 +93,9 @@ test_expect_success 'git svn rebase works inside a fresh-cloned repository' ' # > ... All of the above characters, except for the backslash, are converted # > to special UNICODE characters in the range 0xf000 to 0xf0ff (the # > "Private use area") when creating or accessing files. -prepare_a_utf8_locale +prepare_utf8_locale test_expect_success UTF8,!MINGW,!UTF8_NFD_TO_NFC 'svn.pathnameencoding=cp932 new file on dcommit' ' - LC_ALL=$a_utf8_locale && + LC_ALL=$GIT_TEST_UTF8_LOCALE && export LC_ALL && neq=$(printf "\201\202") && git config svn.pathnameencoding cp932 && @@ -107,7 +107,7 @@ test_expect_success UTF8,!MINGW,!UTF8_NFD_TO_NFC 'svn.pathnameencoding=cp932 new # See the comment on the above test for setting of LC_ALL. test_expect_success !MINGW,!UTF8_NFD_TO_NFC 'svn.pathnameencoding=cp932 rename on dcommit' ' - LC_ALL=$a_utf8_locale && + LC_ALL=$GIT_TEST_UTF8_LOCALE && export LC_ALL && inf=$(printf "\201\207") && git config svn.pathnameencoding cp932 && diff --git a/t/t9129-git-svn-i18n-commitencoding.sh b/t/t9129-git-svn-i18n-commitencoding.sh index 2c213ae654..01e1e8a8f7 100755 --- a/t/t9129-git-svn-i18n-commitencoding.sh +++ b/t/t9129-git-svn-i18n-commitencoding.sh @@ -14,12 +14,12 @@ compare_git_head_with () { test_cmp current "$1" } -prepare_a_utf8_locale +prepare_utf8_locale compare_svn_head_with () { # extract just the log message and strip out committer info. # don't use --limit here since svn 1.1.x doesn't have it, - LC_ALL="$a_utf8_locale" svn log $(git svn info --url) | perl -w -e ' + LC_ALL="$GIT_TEST_UTF8_LOCALE" svn log $(git svn info --url) | perl -w -e ' use bytes; $/ = ("-"x72) . "\n"; my @x = ; -- 2.32.0.rc3.5.gf3d78db977