From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 904C6C47082 for ; Mon, 7 Jun 2021 08:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66D07611C1 for ; Mon, 7 Jun 2021 08:04:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230256AbhFGIGE (ORCPT ); Mon, 7 Jun 2021 04:06:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230131AbhFGIGC (ORCPT ); Mon, 7 Jun 2021 04:06:02 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF724C061766 for ; Mon, 7 Jun 2021 01:04:10 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqAEv-000168-59; Mon, 07 Jun 2021 10:04:05 +0200 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1lqAEu-00070f-Nr; Mon, 07 Jun 2021 10:04:04 +0200 Date: Mon, 7 Jun 2021 10:04:04 +0200 From: Oleksij Rempel To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, kernel@pengutronix.de, Jakub Kicinski , "David S. Miller" , Heiner Kallweit Subject: Re: [PATCH net-next v1 7/7] usbnet: run unbind() before unregister_netdev() Message-ID: <20210607080404.5r2gsmz6w2cnpleq@pengutronix.de> References: <20210604134244.2467-1-o.rempel@pengutronix.de> <20210604134244.2467-8-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:02:56 up 186 days, 22:09, 46 users, load average: 0.10, 0.09, 0.09 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 05, 2021 at 01:41:15AM +0200, Andrew Lunn wrote: > On Fri, Jun 04, 2021 at 03:42:44PM +0200, Oleksij Rempel wrote: > > unbind() is the proper place to disconnect PHY, but it will fail if > > netdev is already unregistered. > > O.K, this partially answers the question i was about to ask for the > previous patch. > > void phy_start(struct phy_device *phydev) > { > mutex_lock(&phydev->lock); > > if (phydev->state != PHY_READY && phydev->state != PHY_HALTED) { > WARN(1, "called from state %s\n", > phy_state_to_str(phydev->state)); > goto out; > } > > By skipping phy_error(), phydev->state is not set to PHY_HALTED. So if > you try to start the phy again, without disconnecting it, it looks > like there could be a problem. > > But with this patch, i assume the PHY will always be disconnected and > later reconnected when the device is replugged. Yes. The PHY is disconnected and the PHY driver is unbinded. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |