All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Carl Philipp Klemm <philipp@uvos.xyz>
Cc: linux-omap@vger.kernel.org,
	Arthur Demchenkov <spinal.by@gmail.com>,
	Tony Lindgren <tony@atomide.com>,
	Merlijn Wajer <merlijn@wizzup.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH v2 2/2] power: supply: cpcap-battery: kconfig: depend on ( NVMEM || !NVMEM )
Date: Mon, 7 Jun 2021 13:27:49 +0200	[thread overview]
Message-ID: <20210607112749.fybn34mahaf4w5te@earth.universe> (raw)
In-Reply-To: <20210607130137.0df783dce66301510894a7cc@uvos.xyz>

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

Hi,

On Mon, Jun 07, 2021 at 01:01:37PM +0200, Carl Philipp Klemm wrote:
> > This is missing a long patch description, but needs to be squashed
> > into PATCH 1/2 anyways.
> > 
> > Thanks,
> > 
> > -- Sebastian
> 
> Im thinking I would rather just drop this entirely, since at least I
> and one other user use cpcap-battery with a 3rd party battery with no
> nvmem, and Tony and Merlijn use it with a lab power supply.
> 
> In these cases requireing NVMEM makes no sense and the code in 
> "power: supply: cpcap-battery: Add battery type auto detection
> for mapphone devices" works fine without.

"depends (NVMEM || !NVMEM)" does not add a NVMEM dependency. It just
disallows the configuration of built-in cpcap-battery and modular NVMEM,
which does not work:

NVMEM=y CPCAP_BATTERY=y => valid
NVMEM=y CPCAP_BATTERY=m => valid
NVMEM=y CPCAP_BATTERY=n => valid
NVMEM=n CPCAP_BATTERY=y => valid
NVMEM=n CPCAP_BATTERY=m => valid
NVMEM=n CPCAP_BATTERY=n => valid
NVMEM=m CPCAP_BATTERY=y => invalid
NVMEM=m CPCAP_BATTERY=m => valid
NVMEM=m CPCAP_BATTERY=n => valid

But checking the NVMEM config option it's bool instead of tristate
and cannot be modular anyways. Thus its fine to drop this, since
it's useless.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-06-07 11:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 12:57 [PATCH v2 2/2] power: supply: cpcap-battery: kconfig: depend on ( NVMEM || !NVMEM ) Carl Philipp Klemm
2021-06-04 12:55 ` Sebastian Reichel
2021-06-07 11:01   ` Carl Philipp Klemm
2021-06-07 11:27     ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210607112749.fybn34mahaf4w5te@earth.universe \
    --to=sebastian.reichel@collabora.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=merlijn@wizzup.org \
    --cc=pavel@ucw.cz \
    --cc=philipp@uvos.xyz \
    --cc=spinal.by@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.