From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99AC0C47095 for ; Mon, 7 Jun 2021 13:09:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 758A660FEF for ; Mon, 7 Jun 2021 13:09:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230291AbhFGNLa (ORCPT ); Mon, 7 Jun 2021 09:11:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230193AbhFGNL2 (ORCPT ); Mon, 7 Jun 2021 09:11:28 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 987C9C061766; Mon, 7 Jun 2021 06:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vbgOzbtmK58ivP99PkrwPY3SZvVaeQG4u1eF2Jf+fZY=; b=OcCrKMaH36LqXSa70uu0yk6vd Zij7bwVolkc0d3fTU3An7/IFuQpoTo51lQ9PuQSvtPbY6/W2NbtvUEtowi4YVn7bQWXqeBtT35D3D aRHX+OukHQLa0wbUkSdiJw9jrM1x+uu37vqWwAu9mIF1njMIpV4tNQu/nnjNJ01yXYpzuWerxFNdt IEpbaTY7+R5C496dIX5KdDB2Honj/5yeBY4tDv5sz9eBvl/EYVez1hUVKqHoadDi98xrroDC8aDXz SFRUogOzph3IeUZS2NfK718XYkUWSuq2Y3Rh1vcHvfL6n+tZUds2W6xDc2+VCm/thYFtCMYP+lgVZ Ue0vwJVFg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44792) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqF0R-0000XY-5z; Mon, 07 Jun 2021 14:09:27 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lqF0O-0005x1-LV; Mon, 07 Jun 2021 14:09:24 +0100 Date: Mon, 7 Jun 2021 14:09:24 +0100 From: "Russell King (Oracle)" To: Steen Hegelund Cc: "David S. Miller" , Jakub Kicinski , Andrew Lunn , Microchip Linux Driver Support , Alexandre Belloni , Madalin Bucur , Mark Einon , Masahiro Yamada , Arnd Bergmann , Philipp Zabel , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjarni Jonasson , Lars Povlsen Subject: Re: [PATCH net-next v3 03/10] net: sparx5: add hostmode with phylink support Message-ID: <20210607130924.GE22278@shell.armlinux.org.uk> References: <20210604085600.3014532-1-steen.hegelund@microchip.com> <20210604085600.3014532-4-steen.hegelund@microchip.com> <20210607091536.GA30436@shell.armlinux.org.uk> <9f4fad323e17c8ba6ebde728fcc99c87dd06fc75.camel@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f4fad323e17c8ba6ebde728fcc99c87dd06fc75.camel@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 07, 2021 at 02:45:01PM +0200, Steen Hegelund wrote: > Hi Russell, > > Thanks for your comments. > > On Mon, 2021-06-07 at 10:15 +0100, Russell King (Oracle) wrote: > > 3) I really don't get what's going on with setting the port mode to > > 2500base-X and 1000base-X here when state->interface is 10GBASER. > > The high speed interfaces (> 2.5G) do not support any in-band signalling, so the only way that e.g a > 10G interface running at 2.5G will be able to link up with its partner is if both ends configure the > speed manually via ethtool. We really should not have drivers hacking around in this way. If we want to operate in 2500base-x or 1000base-x, then that is what phylink should be telling the MAC driver. The MAC driver should not be making these decisions in its mac_config() callback. Doing so makes a joke of kernel programming. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C51C47082 for ; Mon, 7 Jun 2021 13:13:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6E1B6108D for ; Mon, 7 Jun 2021 13:13:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6E1B6108D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bPg9I6rNTnbQdzOIiaUO8O7mTdnGt0tKQp9hw0S0cKY=; b=iJn4L7ELq7c6Nl tyS8YwefAJpuBt9yu6h5XXBZ8ni5nH29EU+8Y+6tPR2ktTZ6mEww6KyuCG2igGR9nPWvuPCh+cqvZ mvYB8egcobEFdhJyIKCzckbSAqDFSi2bPho/TtgA/ht62wy0oVaPBEHRBXPjZtsk/CeJJ/jzeMngJ TneoYFfsWqdYPwBbrAEcIn03s35zDVxg/NbJDr1AdxE5sEu22I6TgwlpT945a1Oob/thd607wX9bH JprqtsndMZMUy+m5pmA5bNs8ymUH71k8EAKWxkNVVe/ZAfgzEOKaQkzU752SnYYsjuV8XclIQCRdw SMjjBjfmtqc5hFLSBL1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqF1h-003hxL-Ov; Mon, 07 Jun 2021 13:10:46 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqF0c-003he4-6V for linux-arm-kernel@lists.infradead.org; Mon, 07 Jun 2021 13:09:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vbgOzbtmK58ivP99PkrwPY3SZvVaeQG4u1eF2Jf+fZY=; b=OcCrKMaH36LqXSa70uu0yk6vd Zij7bwVolkc0d3fTU3An7/IFuQpoTo51lQ9PuQSvtPbY6/W2NbtvUEtowi4YVn7bQWXqeBtT35D3D aRHX+OukHQLa0wbUkSdiJw9jrM1x+uu37vqWwAu9mIF1njMIpV4tNQu/nnjNJ01yXYpzuWerxFNdt IEpbaTY7+R5C496dIX5KdDB2Honj/5yeBY4tDv5sz9eBvl/EYVez1hUVKqHoadDi98xrroDC8aDXz SFRUogOzph3IeUZS2NfK718XYkUWSuq2Y3Rh1vcHvfL6n+tZUds2W6xDc2+VCm/thYFtCMYP+lgVZ Ue0vwJVFg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44792) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqF0R-0000XY-5z; Mon, 07 Jun 2021 14:09:27 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lqF0O-0005x1-LV; Mon, 07 Jun 2021 14:09:24 +0100 Date: Mon, 7 Jun 2021 14:09:24 +0100 From: "Russell King (Oracle)" To: Steen Hegelund Cc: "David S. Miller" , Jakub Kicinski , Andrew Lunn , Microchip Linux Driver Support , Alexandre Belloni , Madalin Bucur , Mark Einon , Masahiro Yamada , Arnd Bergmann , Philipp Zabel , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjarni Jonasson , Lars Povlsen Subject: Re: [PATCH net-next v3 03/10] net: sparx5: add hostmode with phylink support Message-ID: <20210607130924.GE22278@shell.armlinux.org.uk> References: <20210604085600.3014532-1-steen.hegelund@microchip.com> <20210604085600.3014532-4-steen.hegelund@microchip.com> <20210607091536.GA30436@shell.armlinux.org.uk> <9f4fad323e17c8ba6ebde728fcc99c87dd06fc75.camel@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9f4fad323e17c8ba6ebde728fcc99c87dd06fc75.camel@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210607_060938_288595_97286746 X-CRM114-Status: GOOD ( 15.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 07, 2021 at 02:45:01PM +0200, Steen Hegelund wrote: > Hi Russell, > > Thanks for your comments. > > On Mon, 2021-06-07 at 10:15 +0100, Russell King (Oracle) wrote: > > 3) I really don't get what's going on with setting the port mode to > > 2500base-X and 1000base-X here when state->interface is 10GBASER. > > The high speed interfaces (> 2.5G) do not support any in-band signalling, so the only way that e.g a > 10G interface running at 2.5G will be able to link up with its partner is if both ends configure the > speed manually via ethtool. We really should not have drivers hacking around in this way. If we want to operate in 2500base-x or 1000base-x, then that is what phylink should be telling the MAC driver. The MAC driver should not be making these decisions in its mac_config() callback. Doing so makes a joke of kernel programming. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel