Hi "Geoffrey,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v5.13-rc4]
[also build test WARNING on next-20210604]
[cannot apply to sound/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Geoffrey-D-Bennett/ALSA-usb-audio-scarlett2-Read-all-configuration-at-init-time/20210606-222037
base:    8124c8a6b35386f73523d27eacb71b5364a68c4c
config: xtensa-randconfig-s032-20210607 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/4cd436ec424b3564c2dcf9b3b8fd83c8894051f1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Geoffrey-D-Bennett/ALSA-usb-audio-scarlett2-Read-all-configuration-at-init-time/20210606-222037
        git checkout 4cd436ec424b3564c2dcf9b3b8fd83c8894051f1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> sound/usb/mixer_scarlett_gen2.c:809:21: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] mix_num @@     got int mix_num @@
   sound/usb/mixer_scarlett_gen2.c:809:21: sparse:     expected restricted __le16 [usertype] mix_num
   sound/usb/mixer_scarlett_gen2.c:809:21: sparse:     got int mix_num
>> sound/usb/mixer_scarlett_gen2.c:810:19: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] count @@     got int num_mixer_in @@
   sound/usb/mixer_scarlett_gen2.c:810:19: sparse:     expected restricted __le16 [usertype] count
   sound/usb/mixer_scarlett_gen2.c:810:19: sparse:     got int num_mixer_in

vim +809 sound/usb/mixer_scarlett_gen2.c

   788	
   789	/* Send a USB message to get the volumes for all inputs of one mix
   790	 * and put the values into private->mix[]
   791	 */
   792	static int scarlett2_usb_get_mix(struct usb_mixer_interface *mixer,
   793					 int mix_num)
   794	{
   795		struct scarlett2_mixer_data *private = mixer->private_data;
   796		const struct scarlett2_device_info *info = private->info;
   797	
   798		int num_mixer_in =
   799			info->ports[SCARLETT2_PORT_TYPE_MIX].num[SCARLETT2_PORT_OUT];
   800		int err, i, j, k;
   801	
   802		struct {
   803			__le16 mix_num;
   804			__le16 count;
   805		} __packed req;
   806	
   807		__le16 data[SCARLETT2_INPUT_MIX_MAX];
   808	
 > 809		req.mix_num = mix_num;
 > 810		req.count = num_mixer_in;
   811	
   812		err = scarlett2_usb(mixer, SCARLETT2_USB_GET_MIX,
   813				    &req, sizeof(req),
   814				    data, num_mixer_in * sizeof(u16));
   815		if (err < 0)
   816			return err;
   817	
   818		for (i = 0, j = mix_num * num_mixer_in; i < num_mixer_in; i++, j++) {
   819			u16 mixer_value = le16_to_cpu(data[i]);
   820	
   821			for (k = 0; k < SCARLETT2_MIXER_VALUE_COUNT; k++)
   822				if (scarlett2_mixer_values[k] >= mixer_value)
   823					break;
   824			if (k == SCARLETT2_MIXER_VALUE_COUNT)
   825				k = SCARLETT2_MIXER_MAX_VALUE;
   826			private->mix[j] = k;
   827		}
   828	
   829		return 0;
   830	}
   831	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org