From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EE7BC47094 for ; Mon, 7 Jun 2021 14:36:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C64C96105A for ; Mon, 7 Jun 2021 14:36:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C64C96105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqGMu-0002sd-Sn for qemu-devel@archiver.kernel.org; Mon, 07 Jun 2021 10:36:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqGJW-00030R-PN for qemu-devel@nongnu.org; Mon, 07 Jun 2021 10:33:14 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:45813) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqGJT-0000Lj-SO for qemu-devel@nongnu.org; Mon, 07 Jun 2021 10:33:14 -0400 Received: by mail-wr1-x42b.google.com with SMTP id z8so17847506wrp.12 for ; Mon, 07 Jun 2021 07:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j3NTNXz+uS7lfDmWPW0+9MGKzWKidvbpOVLTCYmft64=; b=meYNdQKI4kHqMN1YRia38Ifzbwju9rJXJqhQMlZf/LQgT8UQCe+tUE5Cz5WUutT7Uu Erf9w0siD/dOr2kI3EimEw7pydxMY4iSRkhA9ZphsRQ5acQ/jxzYcQXa+53uPREcg9EC I7XJ1nbGADLHENP5uUMQU0tdOs4J1TLrQkQmhR/jzkg43pijs4jul2gioulUExsQwV/1 YCz1gQHTYozdgN0zSwPv4Z8FS8EfJckU9MIm+jyuk4udLExR4tmdInCoKbkuOGl4mi5u rAfJptLertJJnIoepPhweAn6RWh5usnuJg3TeJT8ujH9Q7AYqNQe8SluSVXap6bw/MVF iS3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j3NTNXz+uS7lfDmWPW0+9MGKzWKidvbpOVLTCYmft64=; b=jje1e9R+ZuOVU5gVskavdm2d40q2Hl9JU7tJIhZwfY5fa7sYMVXvrmSbjz3LkSqbwI jzWZ6Uz9JqCaDDoGL2mj+4UrvsvUWgnxpriZfbjqJhRrLs/cUbeWDq7rsUUqZdp1gkqr KGIG8GXx7cD+PceY/7gHULwSna0Sf/NBpb4tn+Ue6i9AZHb4ewmE287GWjmWk5QMs4K6 Rbtnyhgcbp0Ix15pmCh9kzF1w0BRdcgq+OpXVssIGlmwHWd8U3RCSSrPuoy6BAzA4TqC lsmKGKWtUq8t4YvG/neLEiggUJfXBX08NPFDzFD0GBiNknQ8R879kLdRPKuLVErG+sP5 Cc/A== X-Gm-Message-State: AOAM532ZaXoj4GJ1pPo91BO+iCsUuG1itc0qgcgJXXlmLUCz4r3yONk/ XTl/fMej0ahzFbisuJ5ROIfB+Q== X-Google-Smtp-Source: ABdhPJxFVQeB8J4aBh3nF4qXBUvaD4iDLiD9itOJnlQQvBH/hpu1NYns/ShOEJi4MpOE1D8tPVMr1A== X-Received: by 2002:a5d:4351:: with SMTP id u17mr17296640wrr.47.1623076389566; Mon, 07 Jun 2021 07:33:09 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id p6sm16635878wrf.51.2021.06.07.07.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jun 2021 07:33:08 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id D3C881FF8F; Mon, 7 Jun 2021 15:33:03 +0100 (BST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: peter.maydell@linaro.org Subject: [PULL 3/8] tests/tcg/configure.sh: tweak quoting of target_compiler Date: Mon, 7 Jun 2021 15:32:58 +0100 Message-Id: <20210607143303.28572-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210607143303.28572-1-alex.bennee@linaro.org> References: <20210607143303.28572-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" If you configure the host compiler with a multi-command stanza like: --cc="ccache gcc" then the configure.sh machinery falls over with confusion. Work around this by ensuring we correctly quote so where we need a complete evaluation we get it. Of course the has() check needs single variable so we need to unquote that. This does mean it essentially checks that just the ccache command exits but if we got past that step we still check the compiler actually does something. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Cc: Thomas Huth Message-Id: <20210527160319.19834-4-alex.bennee@linaro.org> diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh index ed6492ce59..aa7c24328a 100755 --- a/tests/tcg/configure.sh +++ b/tests/tcg/configure.sh @@ -222,10 +222,10 @@ for target in $target_list; do got_cross_cc=no - if eval test "x\${cross_cc_$arch}" != xyes; then - eval "target_compiler=\${cross_cc_$arch}" + if eval test "x\"\${cross_cc_$arch}\"" != xyes; then + eval "target_compiler=\"\${cross_cc_$arch}\"" - if has "$target_compiler"; then + if has $target_compiler; then if test "$supress_clang" = yes && $target_compiler --version | grep -qi "clang"; then got_cross_cc=no -- 2.20.1