All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: kwolf@redhat.com, eesposit@redhat.com, qemu-block@nongnu.org,
	qemu-devel@nongnu.org, mreitz@redhat.com,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] iotests/check: move general long options to double dash
Date: Mon, 7 Jun 2021 09:44:18 -0500	[thread overview]
Message-ID: <20210607144418.4si73px4t4i4by7w@redhat.com> (raw)
In-Reply-To: <955ce8e3-eafe-79ab-ad4e-f81ecf08d20f@virtuozzo.com>

On Fri, Jun 04, 2021 at 11:25:16AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> So, there are some ways to improve the situation:

My personal preference (although I'm fine with any of your listed
options, if others speak up in favor of a different one):

> 2. Take this patch and also convert protocol and format options
> 
> Pros: everything is consistent and use two dashes, so we can safely use combining short options syntax
> Cons: more pain for developers to write --qcow2 instead of -qcow2 every time. What actually stopped me of posting that patch (converting protocol and format options), I imagined the heavy extra load on all block-layer developers right pinky to push '-' one time more :))

I don't mind typing an extra - for './check --qcow2'.  I agree it will
cause some temporary learning curve when I type the short way and it
fails, but as long as the error message is good, I don't see a problem
in changing the interface since this is a developer-only tool.

> So, I'm OK with either way and can make patches. But I don't want to be the only person who makes a decision. So, let's wait for opinions, and if nobody really interested, go the default way [3].

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



      reply	other threads:[~2021-06-07 14:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 18:16 [PATCH] iotests/check: move general long options to double dash Vladimir Sementsov-Ogievskiy
2021-06-03 10:21 ` Emanuele Giuseppe Esposito
2021-06-03 12:15   ` Vladimir Sementsov-Ogievskiy
2021-06-03 11:38 ` Paolo Bonzini
2021-06-03 12:19   ` Vladimir Sementsov-Ogievskiy
2021-06-04  7:19     ` Paolo Bonzini
2021-06-04  8:25       ` Vladimir Sementsov-Ogievskiy
2021-06-07 14:44         ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210607144418.4si73px4t4i4by7w@redhat.com \
    --to=eblake@redhat.com \
    --cc=eesposit@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.