From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: damien.hedde@greensocs.com, edgar.iglesias@xilinx.com,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
mark.burton@greensocs.com, qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Eric Auger" <eric.auger@redhat.com>,
"Mirela Grujic" <mirela.grujic@greensocs.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls
Date: Mon, 7 Jun 2021 11:03:50 -0500 [thread overview]
Message-ID: <20210607160350.h7kqpwua6hfb7c62@redhat.com> (raw)
In-Reply-To: <dd18ebb7-9583-86b8-e368-afef3b71e5ef@redhat.com>
On Fri, May 14, 2021 at 11:14:23PM +0200, Paolo Bonzini wrote:
> On 14/05/21 15:13, Mirela Grujic wrote:
> > However, if you believe it should rather be just renamed I can do so.
>
> I am just not sure it's such an advantage to replace phase_check with
> separate functions. The rename is a constraint of QAPI, so we have to live
> with the long names.
You can also use 'prefix':'...' as part of the QAPI 'enum' declaration
to pick a shorter name for the C enum (see for example BlkdebugEvent
in block-core.json).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-06-07 16:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 8:25 [RFC PATCH 0/9] Initial support for machine creation via QMP Mirela Grujic
2021-05-13 8:25 ` [RFC PATCH 1/9] vl: Allow finer control in advancing machine through phases Mirela Grujic
2021-05-13 8:25 ` [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls Mirela Grujic
2021-05-13 17:46 ` Paolo Bonzini
2021-05-14 13:13 ` Mirela Grujic
2021-05-14 21:14 ` Paolo Bonzini
2021-06-07 16:03 ` Eric Blake [this message]
2021-05-13 8:25 ` [RFC PATCH 3/9] rename MachineInitPhase enumeration constants Mirela Grujic
2021-05-13 8:25 ` [RFC PATCH 4/9] qapi: Implement 'query-machine-phase' command Mirela Grujic
2021-05-13 17:44 ` Paolo Bonzini
2021-05-19 15:43 ` Daniel P. Berrangé
2021-05-13 8:25 ` [RFC PATCH 5/9] qapi: Implement 'next-machine-phase' command Mirela Grujic
2021-06-04 14:25 ` Eric Blake
2021-06-05 14:40 ` Paolo Bonzini
2021-05-13 8:25 ` [RFC PATCH 6/9] qapi: Implement 'advance-machine-phase' command Mirela Grujic
2021-05-19 15:37 ` Kevin Wolf
2021-05-13 8:25 ` [RFC PATCH 7/9] qdev-monitor: Restructure and fix the check for command availability Mirela Grujic
2021-05-13 17:43 ` Paolo Bonzini
2021-05-14 13:00 ` Mirela Grujic
2021-05-13 8:25 ` [RFC PATCH 8/9] qapi: Introduce 'allow-init-config' option Mirela Grujic
2021-05-13 8:25 ` [RFC PATCH 9/9] qapi: Allow some commands to be executed in machine 'initialized' phase Mirela Grujic
2021-05-13 17:52 ` [RFC PATCH 0/9] Initial support for machine creation via QMP Paolo Bonzini
2021-05-14 12:48 ` Mirela Grujic
2021-05-14 16:00 ` Paolo Bonzini
2021-05-14 16:20 ` Daniel P. Berrangé
2021-05-14 18:32 ` Paolo Bonzini
2021-05-24 17:20 ` Igor Mammedov
2021-05-24 19:05 ` Igor Mammedov
2021-05-21 11:32 ` Markus Armbruster
2021-05-21 17:02 ` Paolo Bonzini
2021-05-21 14:06 ` Mirela Grujic
2021-05-21 16:57 ` Paolo Bonzini
2021-05-24 18:27 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210607160350.h7kqpwua6hfb7c62@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=damien.hedde@greensocs.com \
--cc=dgilbert@redhat.com \
--cc=edgar.iglesias@xilinx.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kraxel@redhat.com \
--cc=mark.burton@greensocs.com \
--cc=mirela.grujic@greensocs.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.