From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABC3DC47094 for ; Mon, 7 Jun 2021 17:11:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E90960FDB for ; Mon, 7 Jun 2021 17:11:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E90960FDB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F08FE89E08; Mon, 7 Jun 2021 17:11:55 +0000 (UTC) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9219989E08 for ; Mon, 7 Jun 2021 17:11:54 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id c5so18441214wrq.9 for ; Mon, 07 Jun 2021 10:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=Egtr2GG3wGFrHEgpynwP7bBI8pqTMK+eY9RSIZkTjSM=; b=sozaCgN544PugTDTIfAQzQ0TVyjjx0tPwcFu4QTKg5V7vWZrgAyZMofyMH1xWsgJnE OjN1GFIqwi2bOdtHVDOtXB1I3YXK1V1ipvceoq0ywsJNfPOaisTmLfKdM4smy12kYTYl nKscn/NzzLpuXwumEOr1eVfZ7+r8wDsJ4pugPyD6zF3NoqZuPZz/tv23Dn35wQ8eh8Jd WM5r0xL2xEvpNfuZdnrQWwutW5p0ZfFV/INJ9aFJeBeb9fnBKiEO0lcpyWv/sj5HM572 hjvFfRjvVPlDwn5zaUHPU+D7m9g2z14T3xYwfh8DrwVcROA64eALn/54DikSFp7CvESF 77aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=Egtr2GG3wGFrHEgpynwP7bBI8pqTMK+eY9RSIZkTjSM=; b=nRxyezu4kA7LvzyfpYj8vEqPuzHNYjic++9zhKD3kv2e+Bq3TPhW1vgoz+Dlc65rJC QGl3lS8uMCHJqgPCmZfjaKbo2JYgTLvKo+oak3VJFn3kTdc7tn2uAv+1tZJYD+dEPXct zmdYxh7TmpttZZKywIvy8v5AcJSno2o5wpfzr5YSVZ44Xcm4ogzpIryuhgPQQII1d3JO rafU1aZbOF7gwhPCuCCUN6r6Yf6Rttg3xgD+NW4I+xCA9m3H9sErbXLEjCtQuS+AEDTl zYjpZkR6CKWgUNiHkSpUQ4+ao+MgQzXhvNT86urlCnXbSkUWjmNmDECFjNuS14W60x4G TovQ== X-Gm-Message-State: AOAM531ijHJ6REEiCmu3hwdyBhHhg5oiCT22OHTgxEqQDrfJyR4+Wph4 rKhx5Wrg+ki9/+csGCRxwfspvJKNCDM= X-Google-Smtp-Source: ABdhPJwQizRds2TYS4KyGTLLZeaKaKWPo2d1FsIT8VHWATDO21gHPD1TZVN7PRaxWgywoaQ4Yc0VhA== X-Received: by 2002:adf:dec3:: with SMTP id i3mr4440562wrn.190.1623085913378; Mon, 07 Jun 2021 10:11:53 -0700 (PDT) Received: from abel.fritz.box ([2a02:908:1252:fb60:f8b0:909c:7b9:b4ae]) by smtp.gmail.com with ESMTPSA id u20sm10272467wmq.24.2021.06.07.10.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jun 2021 10:11:53 -0700 (PDT) From: "=?UTF-8?q?Christian=20K=C3=B6nig?=" X-Google-Original-From: =?UTF-8?q?Christian=20K=C3=B6nig?= To: thomas_os@shipmail.org, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/ttm: fix access to uninitialized variable. Date: Mon, 7 Jun 2021 19:11:52 +0200 Message-Id: <20210607171152.15914-1-christian.koenig@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The resource is not allocated yet, so no chance that this will work. Use the placement instead. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 7e7284da5630..0c74f4cb2a3b 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -736,7 +736,7 @@ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo, struct ww_acquire_ctx *ticket; int ret; - man = ttm_manager_type(bdev, (*mem)->mem_type); + man = ttm_manager_type(bdev, place->mem_type); ticket = dma_resv_locking_ctx(bo->base.resv); do { ret = ttm_resource_alloc(bo, place, mem); -- 2.25.1