From: Nadav Amit <nadav.amit@gmail.com> To: Joerg Roedel <joro@8bytes.org> Cc: Nadav Amit <namit@vmware.com>, Will Deacon <will@kernel.org>, Jiajun Cao <caojiajun@vmware.com>, Robin Murphy <robin.murphy@arm.com>, Lu Baolu <baolu.lu@linux.intel.com>, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/6] iommu/amd: Do not use flush-queue when NpCache is on Date: Mon, 7 Jun 2021 11:25:37 -0700 [thread overview] Message-ID: <20210607182541.119756-3-namit@vmware.com> (raw) In-Reply-To: <20210607182541.119756-1-namit@vmware.com> From: Nadav Amit <namit@vmware.com> Do not use flush-queue on virtualized environments, where the NpCache capability of the IOMMU is set. This is required to reduce virtualization overheads. This change follows a similar change to Intel's VT-d and a detailed explanation as for the rationale is described in commit 29b32839725f ("iommu/vt-d: Do not use flush-queue when caching-mode is on"). Cc: Joerg Roedel <joro@8bytes.org> Cc: Will Deacon <will@kernel.org> Cc: Jiajun Cao <caojiajun@vmware.com> Cc: Robin Murphy <robin.murphy@arm.com> Cc: Lu Baolu <baolu.lu@linux.intel.com> Cc: iommu@lists.linux-foundation.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Nadav Amit <namit@vmware.com> --- drivers/iommu/amd/init.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c index d006724f4dc2..ba3b76ed776d 100644 --- a/drivers/iommu/amd/init.c +++ b/drivers/iommu/amd/init.c @@ -1850,8 +1850,13 @@ static int __init iommu_init_pci(struct amd_iommu *iommu) if (ret) return ret; - if (iommu->cap & (1UL << IOMMU_CAP_NPCACHE)) + if (iommu->cap & (1UL << IOMMU_CAP_NPCACHE)) { + if (!amd_iommu_unmap_flush) + pr_warn_once("IOMMU batching is disabled due to virtualization"); + amd_iommu_np_cache = true; + amd_iommu_unmap_flush = true; + } init_iommu_perf_ctr(iommu); -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Nadav Amit <nadav.amit@gmail.com> To: Joerg Roedel <joro@8bytes.org> Cc: Robin Murphy <robin.murphy@arm.com>, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Nadav Amit <namit@vmware.com>, Jiajun Cao <caojiajun@vmware.com>, Will Deacon <will@kernel.org> Subject: [PATCH v3 2/6] iommu/amd: Do not use flush-queue when NpCache is on Date: Mon, 7 Jun 2021 11:25:37 -0700 [thread overview] Message-ID: <20210607182541.119756-3-namit@vmware.com> (raw) In-Reply-To: <20210607182541.119756-1-namit@vmware.com> From: Nadav Amit <namit@vmware.com> Do not use flush-queue on virtualized environments, where the NpCache capability of the IOMMU is set. This is required to reduce virtualization overheads. This change follows a similar change to Intel's VT-d and a detailed explanation as for the rationale is described in commit 29b32839725f ("iommu/vt-d: Do not use flush-queue when caching-mode is on"). Cc: Joerg Roedel <joro@8bytes.org> Cc: Will Deacon <will@kernel.org> Cc: Jiajun Cao <caojiajun@vmware.com> Cc: Robin Murphy <robin.murphy@arm.com> Cc: Lu Baolu <baolu.lu@linux.intel.com> Cc: iommu@lists.linux-foundation.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Nadav Amit <namit@vmware.com> --- drivers/iommu/amd/init.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c index d006724f4dc2..ba3b76ed776d 100644 --- a/drivers/iommu/amd/init.c +++ b/drivers/iommu/amd/init.c @@ -1850,8 +1850,13 @@ static int __init iommu_init_pci(struct amd_iommu *iommu) if (ret) return ret; - if (iommu->cap & (1UL << IOMMU_CAP_NPCACHE)) + if (iommu->cap & (1UL << IOMMU_CAP_NPCACHE)) { + if (!amd_iommu_unmap_flush) + pr_warn_once("IOMMU batching is disabled due to virtualization"); + amd_iommu_np_cache = true; + amd_iommu_unmap_flush = true; + } init_iommu_perf_ctr(iommu); -- 2.25.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-06-08 1:55 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-07 18:25 [PATCH v3 0/6] iommu/amd: Enable page-selective flushes Nadav Amit 2021-06-07 18:25 ` Nadav Amit 2021-06-07 18:25 ` [PATCH v3 1/6] iommu/amd: Selective flush on unmap Nadav Amit 2021-06-07 18:25 ` Nadav Amit 2021-06-07 18:25 ` Nadav Amit [this message] 2021-06-07 18:25 ` [PATCH v3 2/6] iommu/amd: Do not use flush-queue when NpCache is on Nadav Amit 2021-06-15 13:08 ` Robin Murphy 2021-06-15 13:08 ` Robin Murphy 2021-06-15 18:26 ` Nadav Amit 2021-06-15 18:26 ` Nadav Amit 2021-06-15 19:36 ` Robin Murphy 2021-06-15 19:36 ` Robin Murphy 2021-06-07 18:25 ` [PATCH v3 3/6] iommu: Improve iommu_iotlb_gather helpers Nadav Amit 2021-06-07 18:25 ` Nadav Amit 2021-06-11 13:50 ` Will Deacon 2021-06-11 13:50 ` Will Deacon 2021-06-15 10:42 ` Robin Murphy 2021-06-15 10:42 ` Robin Murphy 2021-06-15 19:05 ` Nadav Amit 2021-06-15 19:05 ` Nadav Amit 2021-06-15 19:07 ` Nadav Amit 2021-06-15 19:07 ` Nadav Amit 2021-06-15 12:29 ` Yong Wu 2021-06-15 12:29 ` Yong Wu 2021-06-15 12:41 ` Robin Murphy 2021-06-15 12:41 ` Robin Murphy 2021-06-07 18:25 ` [PATCH v3 4/6] iommu: Factor iommu_iotlb_gather_is_disjoint() out Nadav Amit 2021-06-07 18:25 ` Nadav Amit 2021-06-11 13:57 ` Will Deacon 2021-06-11 13:57 ` Will Deacon 2021-06-11 16:50 ` Nadav Amit 2021-06-11 16:50 ` Nadav Amit 2021-06-15 10:29 ` Will Deacon 2021-06-15 10:29 ` Will Deacon 2021-06-15 18:54 ` Nadav Amit 2021-06-15 18:54 ` Nadav Amit 2021-06-07 18:25 ` [PATCH v3 5/6] iommu/amd: Tailored gather logic for AMD Nadav Amit 2021-06-07 18:25 ` Nadav Amit 2021-06-15 12:55 ` Robin Murphy 2021-06-15 12:55 ` Robin Murphy 2021-06-15 18:14 ` Nadav Amit 2021-06-15 18:14 ` Nadav Amit 2021-06-15 19:20 ` Robin Murphy 2021-06-15 19:20 ` Robin Murphy 2021-06-15 19:46 ` Nadav Amit 2021-06-15 19:46 ` Nadav Amit 2021-06-07 18:25 ` [PATCH v3 6/6] iommu/amd: Sync once for scatter-gather operations Nadav Amit 2021-06-07 18:25 ` Nadav Amit 2021-06-15 11:25 ` Robin Murphy 2021-06-15 11:25 ` Robin Murphy 2021-06-15 18:51 ` Nadav Amit 2021-06-15 18:51 ` Nadav Amit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210607182541.119756-3-namit@vmware.com \ --to=nadav.amit@gmail.com \ --cc=baolu.lu@linux.intel.com \ --cc=caojiajun@vmware.com \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=namit@vmware.com \ --cc=robin.murphy@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.