From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 1/9] xfs: refactor the inode recycling code
Date: Mon, 7 Jun 2021 17:14:48 -0700 [thread overview]
Message-ID: <20210608001448.GO2945738@locust> (raw)
In-Reply-To: <20210607225906.GF664593@dread.disaster.area>
On Tue, Jun 08, 2021 at 08:59:06AM +1000, Dave Chinner wrote:
> On Mon, Jun 07, 2021 at 03:24:59PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Hoist the code in xfs_iget_cache_hit that restores the VFS inode state
> > to an xfs_inode that was previously vfs-destroyed. The next patch will
> > add a new set of state flags, so we need the helper to avoid
> > duplication.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> > fs/xfs/xfs_icache.c | 139 ++++++++++++++++++++++++++++++---------------------
> > 1 file changed, 81 insertions(+), 58 deletions(-)
> >
> >
> > diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> > index 4e4682879bbd..4d4aa61fbd34 100644
> > --- a/fs/xfs/xfs_icache.c
> > +++ b/fs/xfs/xfs_icache.c
> > @@ -350,19 +350,19 @@ xfs_inew_wait(
> > * need to retain across reinitialisation, and rewrite them into the VFS inode
> > * after reinitialisation even if it fails.
> > */
> > -static int
> > +static inline int
> > xfs_reinit_inode(
> > struct xfs_mount *mp,
> > struct inode *inode)
>
> Don't use inline here as it's a pretty big function - it's a static
> function so let the compiler decide if inlining is worth it.
Fixed.
--D
> Otherwise looks ok.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>
> --
> Dave Chinner
> david@fromorbit.com
next prev parent reply other threads:[~2021-06-08 0:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 22:24 [PATCHSET v6 0/9] xfs: deferred inode inactivation Darrick J. Wong
2021-06-07 22:24 ` [PATCH 1/9] xfs: refactor the inode recycling code Darrick J. Wong
2021-06-07 22:59 ` Dave Chinner
2021-06-08 0:14 ` Darrick J. Wong [this message]
2021-06-07 22:25 ` [PATCH 2/9] xfs: deferred inode inactivation Darrick J. Wong
2021-06-08 0:57 ` Dave Chinner
2021-06-08 4:40 ` Darrick J. Wong
2021-06-09 1:01 ` Dave Chinner
2021-06-09 1:28 ` Darrick J. Wong
2021-06-07 22:25 ` [PATCH 3/9] xfs: expose sysfs knob to control inode inactivation delay Darrick J. Wong
2021-06-08 1:09 ` Dave Chinner
2021-06-08 2:02 ` Darrick J. Wong
2021-06-07 22:25 ` [PATCH 4/9] xfs: force inode inactivation and retry fs writes when there isn't space Darrick J. Wong
2021-06-07 22:25 ` [PATCH 5/9] xfs: force inode garbage collection before fallocate when space is low Darrick J. Wong
2021-06-08 1:26 ` Dave Chinner
2021-06-08 11:48 ` Brian Foster
2021-06-08 15:32 ` Darrick J. Wong
2021-06-08 16:06 ` Brian Foster
2021-06-08 21:55 ` Dave Chinner
2021-06-09 0:25 ` Darrick J. Wong
2021-06-07 22:25 ` [PATCH 6/9] xfs: parallelize inode inactivation Darrick J. Wong
2021-06-07 22:25 ` [PATCH 7/9] xfs: create a polled function to force " Darrick J. Wong
2021-06-07 22:25 ` [PATCH 8/9] xfs: don't run speculative preallocation gc when fs is frozen Darrick J. Wong
2021-06-07 22:25 ` [PATCH 9/9] xfs: avoid buffer deadlocks when walking fs inodes Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2021-03-26 0:21 [PATCHSET v5 0/9] xfs: deferred inode inactivation Darrick J. Wong
2021-03-26 0:21 ` [PATCH 1/9] xfs: refactor the inode recycling code Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608001448.GO2945738@locust \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.