* [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of list_del/list_add_tail
@ 2021-06-08 3:09 ` Baokun Li
0 siblings, 0 replies; 6+ messages in thread
From: Baokun Li @ 2021-06-08 3:09 UTC (permalink / raw)
To: linux-kernel, Vinod Koul, Michal Simek, Radhey Shyam Pandey,
Shravya Kumbham, Matthew Murrian, Romain Perier,
Lars-Peter Clausen, Krzysztof Kozlowski, Allen Pais
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, libaokun1,
dmaengine, linux-arm-kernel, kernel-janitors, Hulk Robot
Using list_move_tail() instead of list_del() + list_add_tail().
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
drivers/dma/xilinx/xilinx_dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
index 75c0b8e904e5..77022ef05ac5 100644
--- a/drivers/dma/xilinx/xilinx_dma.c
+++ b/drivers/dma/xilinx/xilinx_dma.c
@@ -1411,8 +1411,7 @@ static void xilinx_vdma_start_transfer(struct xilinx_dma_chan *chan)
chan->desc_submitcount++;
chan->desc_pendingcount--;
- list_del(&desc->node);
- list_add_tail(&desc->node, &chan->active_list);
+ list_move_tail(&desc->node, &chan->active_list);
if (chan->desc_submitcount == chan->num_frms)
chan->desc_submitcount = 0;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of list_del/list_add_tail
@ 2021-06-08 3:09 ` Baokun Li
0 siblings, 0 replies; 6+ messages in thread
From: Baokun Li @ 2021-06-08 3:09 UTC (permalink / raw)
To: linux-kernel, Vinod Koul, Michal Simek, Radhey Shyam Pandey,
Shravya Kumbham, Matthew Murrian, Romain Perier,
Lars-Peter Clausen, Krzysztof Kozlowski, Allen Pais
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, libaokun1,
dmaengine, linux-arm-kernel, kernel-janitors, Hulk Robot
Using list_move_tail() instead of list_del() + list_add_tail().
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
drivers/dma/xilinx/xilinx_dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
index 75c0b8e904e5..77022ef05ac5 100644
--- a/drivers/dma/xilinx/xilinx_dma.c
+++ b/drivers/dma/xilinx/xilinx_dma.c
@@ -1411,8 +1411,7 @@ static void xilinx_vdma_start_transfer(struct xilinx_dma_chan *chan)
chan->desc_submitcount++;
chan->desc_pendingcount--;
- list_del(&desc->node);
- list_add_tail(&desc->node, &chan->active_list);
+ list_move_tail(&desc->node, &chan->active_list);
if (chan->desc_submitcount == chan->num_frms)
chan->desc_submitcount = 0;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of list_del/list_add_tail
2021-06-08 3:09 ` Baokun Li
@ 2021-06-08 13:16 ` Radhey Shyam Pandey
-1 siblings, 0 replies; 6+ messages in thread
From: Radhey Shyam Pandey @ 2021-06-08 13:16 UTC (permalink / raw)
To: Baokun Li, linux-kernel, Vinod Koul, Michal Simek,
Shravya Kumbham, Matthew Murrian, Romain Perier,
Lars-Peter Clausen, Krzysztof Kozlowski, Allen Pais
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, dmaengine,
linux-arm-kernel, kernel-janitors, Hulk Robot
> -----Original Message-----
> From: Baokun Li <libaokun1@huawei.com>
> Sent: Tuesday, June 8, 2021 8:39 AM
> To: linux-kernel@vger.kernel.org; Vinod Koul <vkoul@kernel.org>; Michal
> Simek <michals@xilinx.com>; Radhey Shyam Pandey <radheys@xilinx.com>;
> Shravya Kumbham <shravyak@xilinx.com>; Matthew Murrian
> <matthew.murrian@goctsi.com>; Romain Perier
> <romain.perier@gmail.com>; Lars-Peter Clausen <lars@metafoo.de>;
> Krzysztof Kozlowski <krzk@kernel.org>; Allen Pais <allen.lkml@gmail.com>
> Cc: weiyongjun1@huawei.com; yuehaibing@huawei.com;
> yangjihong1@huawei.com; yukuai3@huawei.com; libaokun1@huawei.com;
> dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org; kernel-
> janitors@vger.kernel.org; Hulk Robot <hulkci@huawei.com>
> Subject: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of
> list_del/list_add_tail
>
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Thanks!
> ---
> drivers/dma/xilinx/xilinx_dma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index 75c0b8e904e5..77022ef05ac5 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -1411,8 +1411,7 @@ static void xilinx_vdma_start_transfer(struct
> xilinx_dma_chan *chan)
>
> chan->desc_submitcount++;
> chan->desc_pendingcount--;
> - list_del(&desc->node);
> - list_add_tail(&desc->node, &chan->active_list);
> + list_move_tail(&desc->node, &chan->active_list);
> if (chan->desc_submitcount == chan->num_frms)
> chan->desc_submitcount = 0;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of list_del/list_add_tail
@ 2021-06-08 13:16 ` Radhey Shyam Pandey
0 siblings, 0 replies; 6+ messages in thread
From: Radhey Shyam Pandey @ 2021-06-08 13:16 UTC (permalink / raw)
To: Baokun Li, linux-kernel, Vinod Koul, Michal Simek,
Shravya Kumbham, Matthew Murrian, Romain Perier,
Lars-Peter Clausen, Krzysztof Kozlowski, Allen Pais
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, dmaengine,
linux-arm-kernel, kernel-janitors, Hulk Robot
> -----Original Message-----
> From: Baokun Li <libaokun1@huawei.com>
> Sent: Tuesday, June 8, 2021 8:39 AM
> To: linux-kernel@vger.kernel.org; Vinod Koul <vkoul@kernel.org>; Michal
> Simek <michals@xilinx.com>; Radhey Shyam Pandey <radheys@xilinx.com>;
> Shravya Kumbham <shravyak@xilinx.com>; Matthew Murrian
> <matthew.murrian@goctsi.com>; Romain Perier
> <romain.perier@gmail.com>; Lars-Peter Clausen <lars@metafoo.de>;
> Krzysztof Kozlowski <krzk@kernel.org>; Allen Pais <allen.lkml@gmail.com>
> Cc: weiyongjun1@huawei.com; yuehaibing@huawei.com;
> yangjihong1@huawei.com; yukuai3@huawei.com; libaokun1@huawei.com;
> dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org; kernel-
> janitors@vger.kernel.org; Hulk Robot <hulkci@huawei.com>
> Subject: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of
> list_del/list_add_tail
>
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Thanks!
> ---
> drivers/dma/xilinx/xilinx_dma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index 75c0b8e904e5..77022ef05ac5 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -1411,8 +1411,7 @@ static void xilinx_vdma_start_transfer(struct
> xilinx_dma_chan *chan)
>
> chan->desc_submitcount++;
> chan->desc_pendingcount--;
> - list_del(&desc->node);
> - list_add_tail(&desc->node, &chan->active_list);
> + list_move_tail(&desc->node, &chan->active_list);
> if (chan->desc_submitcount == chan->num_frms)
> chan->desc_submitcount = 0;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of list_del/list_add_tail
2021-06-08 3:09 ` Baokun Li
@ 2021-07-28 6:35 ` Vinod Koul
-1 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2021-07-28 6:35 UTC (permalink / raw)
To: Baokun Li
Cc: linux-kernel, Michal Simek, Radhey Shyam Pandey, Shravya Kumbham,
Matthew Murrian, Romain Perier, Lars-Peter Clausen,
Krzysztof Kozlowski, Allen Pais, weiyongjun1, yuehaibing,
yangjihong1, yukuai3, dmaengine, linux-arm-kernel,
kernel-janitors, Hulk Robot
On 08-06-21, 11:09, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of list_del/list_add_tail
@ 2021-07-28 6:35 ` Vinod Koul
0 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2021-07-28 6:35 UTC (permalink / raw)
To: Baokun Li
Cc: linux-kernel, Michal Simek, Radhey Shyam Pandey, Shravya Kumbham,
Matthew Murrian, Romain Perier, Lars-Peter Clausen,
Krzysztof Kozlowski, Allen Pais, weiyongjun1, yuehaibing,
yangjihong1, yukuai3, dmaengine, linux-arm-kernel,
kernel-janitors, Hulk Robot
On 08-06-21, 11:09, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().
Applied, thanks
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-28 6:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 3:09 [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of list_del/list_add_tail Baokun Li
2021-06-08 3:09 ` Baokun Li
2021-06-08 13:16 ` Radhey Shyam Pandey
2021-06-08 13:16 ` Radhey Shyam Pandey
2021-07-28 6:35 ` Vinod Koul
2021-07-28 6:35 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.