From: Kees Cook <firstname.lastname@example.org> To: Andrew Morton <email@example.com> Cc: Vlastimil Babka <firstname.lastname@example.org>, Marco Elver <email@example.com>, Christoph Lameter <firstname.lastname@example.org>, "Lin, Zhenpeng" <email@example.com>, Pekka Enberg <firstname.lastname@example.org>, David Rientjes <email@example.com>, Joonsoo Kim <firstname.lastname@example.org>, Roman Gushchin <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH v4 0/3] Actually fix freelist pointer vs redzoning Date: Tue, 8 Jun 2021 16:08:13 -0700 [thread overview] Message-ID: <202106081605.929AF37@keescook> (raw) In-Reply-To: <email@example.com> On Tue, Jun 08, 2021 at 01:53:27PM -0700, Andrew Morton wrote: > On Tue, 8 Jun 2021 11:39:52 -0700 Kees Cook <firstname.lastname@example.org> wrote: > > > This fixes redzoning vs the freelist pointer (both for middle-position > > and very small caches). Both are "theoretical" fixes, in that I see no > > evidence of such small-sized caches actually be used in the kernel, but > > that's no reason to let the bugs continue to exist, especially since > > people doing local development keep tripping over it. :) > > So I don't think this is suitable -stable material? Yeah, I think it's -stable material, but I'd like some bake time in -next just in case. zplin saw that there was a 2 * sizeof(void *) case that existed in the kernel that would trip over the issue. > It's a bit odd that patches 2&3 were cc:stable but #1 was not. Makes > one afraid that 2&3 might have had a dependency anyway. #1 is entirely cosmetic. It should also be fine to put into -stable, but since it had no operational impact, I figured it didn't need to be. > So I'm thinking that the whole series can just be for 5.14-rc1, in the > sent order. Unless I'm missing something big, yeah, that would be my preference too. (And -stable can pick it up then.) -- Kees Cook
prev parent reply other threads:[~2021-06-08 23:08 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-08 18:39 Kees Cook 2021-06-08 18:39 ` [PATCH v4 1/3] mm/slub: Clarify verification reporting Kees Cook 2021-06-08 18:39 ` [PATCH v4 2/3] mm/slub: Fix redzoning for small allocations Kees Cook 2021-06-11 9:13 ` Vlastimil Babka 2021-06-08 18:39 ` [PATCH v4 3/3] mm/slub: Actually fix freelist pointer vs redzoning Kees Cook 2021-06-08 20:56 ` Andrew Morton 2021-06-08 23:11 ` Kees Cook 2021-06-08 20:53 ` [PATCH v4 0/3] " Andrew Morton 2021-06-08 23:08 ` Kees Cook [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202106081605.929AF37@keescook \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v4 0/3] Actually fix freelist pointer vs redzoning' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.