From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85688C47095 for ; Wed, 9 Jun 2021 07:00:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F4CD6124C for ; Wed, 9 Jun 2021 07:00:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236897AbhFIHCe (ORCPT ); Wed, 9 Jun 2021 03:02:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60554 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234137AbhFIHC0 (ORCPT ); Wed, 9 Jun 2021 03:02:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623222032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6hIZj5McJwNKEs212yGJXp2y36I81CvD5+PXaLps0Hg=; b=I9p1LTQN6m1GKeQ4Hgi1KLpxgr2TOptXJRT3qtV3Po4124YWm2NbKOG05/m4QYj9KYTDtv /kxYqD/Of5gnyvs3mjmI3TMb6SY7cxc1dgpyg95yPdDEhgUw9TRgCmzTGYRsehGwOhxNVc 2aMCAfLxKTxlrix7oDHPodrwnkIFYSw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-xQCyc86KPvisvcAPrxDywg-1; Wed, 09 Jun 2021 03:00:30 -0400 X-MC-Unique: xQCyc86KPvisvcAPrxDywg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DEB8A8042A6; Wed, 9 Jun 2021 07:00:28 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-69.ams2.redhat.com [10.36.113.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 111C419C45; Wed, 9 Jun 2021 07:00:25 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7770C18003B6; Wed, 9 Jun 2021 09:00:23 +0200 (CEST) Date: Wed, 9 Jun 2021 09:00:23 +0200 From: Gerd Hoffmann To: Colin King Cc: Dave Airlie , Daniel Vetter , Alon Levy , virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: qxl: ensure surf.data is ininitialized Message-ID: <20210609070023.zp53qaopkbx2ol3a@sirius.home.kraxel.org> References: <20210608161313.161922-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210608161313.161922-1-colin.king@canonical.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 08, 2021 at 05:13:13PM +0100, Colin King wrote: > From: Colin Ian King > > The object surf is not fully initialized and the uninitialized > field surf.data is being copied by the call to qxl_bo_create > via the call to qxl_gem_object_create. Set surf.data to zero > to ensure garbage data from the stack is not being copied. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: f64122c1f6ad ("drm: add new QXL driver. (v1.4)") > Signed-off-by: Colin Ian King Pushed to drm-misc-next. thanks, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B7E7C48BDF for ; Wed, 9 Jun 2021 07:00:38 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C8D760FDA for ; Wed, 9 Jun 2021 07:00:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C8D760FDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id F3DE883279; Wed, 9 Jun 2021 07:00:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DvrBayWLhzxC; Wed, 9 Jun 2021 07:00:37 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id AD91583227; Wed, 9 Jun 2021 07:00:36 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6BC53C000E; Wed, 9 Jun 2021 07:00:36 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id CF3AEC000B for ; Wed, 9 Jun 2021 07:00:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id BE26A608B1 for ; Wed, 9 Jun 2021 07:00:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ynzGxEqc92jY for ; Wed, 9 Jun 2021 07:00:33 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 9E00860672 for ; Wed, 9 Jun 2021 07:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623222032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6hIZj5McJwNKEs212yGJXp2y36I81CvD5+PXaLps0Hg=; b=I9p1LTQN6m1GKeQ4Hgi1KLpxgr2TOptXJRT3qtV3Po4124YWm2NbKOG05/m4QYj9KYTDtv /kxYqD/Of5gnyvs3mjmI3TMb6SY7cxc1dgpyg95yPdDEhgUw9TRgCmzTGYRsehGwOhxNVc 2aMCAfLxKTxlrix7oDHPodrwnkIFYSw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-xQCyc86KPvisvcAPrxDywg-1; Wed, 09 Jun 2021 03:00:30 -0400 X-MC-Unique: xQCyc86KPvisvcAPrxDywg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DEB8A8042A6; Wed, 9 Jun 2021 07:00:28 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-69.ams2.redhat.com [10.36.113.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 111C419C45; Wed, 9 Jun 2021 07:00:25 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7770C18003B6; Wed, 9 Jun 2021 09:00:23 +0200 (CEST) Date: Wed, 9 Jun 2021 09:00:23 +0200 From: Gerd Hoffmann To: Colin King Subject: Re: [PATCH] drm: qxl: ensure surf.data is ininitialized Message-ID: <20210609070023.zp53qaopkbx2ol3a@sirius.home.kraxel.org> References: <20210608161313.161922-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210608161313.161922-1-colin.king@canonical.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Alon Levy , Daniel Vetter , spice-devel@lists.freedesktop.org, Dave Airlie X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, Jun 08, 2021 at 05:13:13PM +0100, Colin King wrote: > From: Colin Ian King > > The object surf is not fully initialized and the uninitialized > field surf.data is being copied by the call to qxl_bo_create > via the call to qxl_gem_object_create. Set surf.data to zero > to ensure garbage data from the stack is not being copied. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: f64122c1f6ad ("drm: add new QXL driver. (v1.4)") > Signed-off-by: Colin Ian King Pushed to drm-misc-next. thanks, Gerd _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE02C48BCF for ; Wed, 9 Jun 2021 07:00:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A126E60FDA for ; Wed, 9 Jun 2021 07:00:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A126E60FDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0977B6E051; Wed, 9 Jun 2021 07:00:37 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 25C416E051 for ; Wed, 9 Jun 2021 07:00:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623222034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6hIZj5McJwNKEs212yGJXp2y36I81CvD5+PXaLps0Hg=; b=hRbZuTkkWBX16lKIMugF7H5LhBYUx11LxvJ65IdaYYYX/nEvIIfL+N43q+MitRc+hSsJzK PsCVBFOCRo9m/ZdKB6aJAs76KJYfEfHHe4wpE8pTPBZ7aK/bzuqLWbLr4nGWBztX5jiHuv uPSvXe7O9CHs7I5TLEzNtOTYtr/ZuUo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-xQCyc86KPvisvcAPrxDywg-1; Wed, 09 Jun 2021 03:00:30 -0400 X-MC-Unique: xQCyc86KPvisvcAPrxDywg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DEB8A8042A6; Wed, 9 Jun 2021 07:00:28 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-69.ams2.redhat.com [10.36.113.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 111C419C45; Wed, 9 Jun 2021 07:00:25 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7770C18003B6; Wed, 9 Jun 2021 09:00:23 +0200 (CEST) Date: Wed, 9 Jun 2021 09:00:23 +0200 From: Gerd Hoffmann To: Colin King Subject: Re: [PATCH] drm: qxl: ensure surf.data is ininitialized Message-ID: <20210609070023.zp53qaopkbx2ol3a@sirius.home.kraxel.org> References: <20210608161313.161922-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210608161313.161922-1-colin.king@canonical.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Alon Levy , spice-devel@lists.freedesktop.org, Dave Airlie Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 08, 2021 at 05:13:13PM +0100, Colin King wrote: > From: Colin Ian King > > The object surf is not fully initialized and the uninitialized > field surf.data is being copied by the call to qxl_bo_create > via the call to qxl_gem_object_create. Set surf.data to zero > to ensure garbage data from the stack is not being copied. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: f64122c1f6ad ("drm: add new QXL driver. (v1.4)") > Signed-off-by: Colin Ian King Pushed to drm-misc-next. thanks, Gerd