All of lore.kernel.org
 help / color / mirror / Atom feed
From: Edward Wu <edwardwu@realtek.com>
To: <netdev@vger.kernel.org>
Cc: <nic_swsd@realtek.com>, Edward Wu <edwardwu@realtek.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH net-dev] net: Exposing more skb fields in netif_receive_skb trace event
Date: Wed, 9 Jun 2021 17:36:54 +0800	[thread overview]
Message-ID: <20210609093656.8984-1-edwardwu@realtek.com> (raw)

This exposing helps to analyze network behavior.

In performance tuning, we will check nr_frags to analyze
GRO aggregation behavior. By this commit, we can
enable netif_receive_skb trace event for dynamic debugging.

Signed-off-by: Edward Wu <edwardwu@realtek.com>
---
 include/trace/events/net.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/include/trace/events/net.h b/include/trace/events/net.h
index 2399073c3afc..48aa7168b68f 100644
--- a/include/trace/events/net.h
+++ b/include/trace/events/net.h
@@ -147,13 +147,6 @@ DEFINE_EVENT(net_dev_template, net_dev_queue,
 	TP_ARGS(skb)
 );
 
-DEFINE_EVENT(net_dev_template, netif_receive_skb,
-
-	TP_PROTO(struct sk_buff *skb),
-
-	TP_ARGS(skb)
-);
-
 DEFINE_EVENT(net_dev_template, netif_rx,
 
 	TP_PROTO(struct sk_buff *skb),
@@ -239,6 +232,13 @@ DEFINE_EVENT(net_dev_rx_verbose_template, napi_gro_receive_entry,
 	TP_ARGS(skb)
 );
 
+DEFINE_EVENT(net_dev_rx_verbose_template, netif_receive_skb,
+
+	TP_PROTO(const struct sk_buff *skb),
+
+	TP_ARGS(skb)
+);
+
 DEFINE_EVENT(net_dev_rx_verbose_template, netif_receive_skb_entry,
 
 	TP_PROTO(const struct sk_buff *skb),
-- 
2.17.1


             reply	other threads:[~2021-06-09 10:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09  9:36 Edward Wu [this message]
2021-06-23 11:23 ` [PATCH net-next resend] net: Exposing more skb fields in netif_receive_skb trace event Edward Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210609093656.8984-1-edwardwu@realtek.com \
    --to=edwardwu@realtek.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.