From: Greg Kurz <groug@kaod.org>
To: Max Reitz <mreitz@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
virtio-fs@redhat.com, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH v2 0/7] fuse: Some fixes for submounts
Date: Wed, 9 Jun 2021 09:46:38 +0200 [thread overview]
Message-ID: <20210609094638.197ca7fc@bahia.lan> (raw)
In-Reply-To: <c3d49438-6ee1-32b1-1be4-41be78cec2ce@redhat.com>
On Tue, 8 Jun 2021 17:52:13 +0200
Max Reitz <mreitz@redhat.com> wrote:
> On 04.06.21 18:11, Greg Kurz wrote:
> > v2:
> >
> > - add an extra fix (patch 2) : mount is now added to the list before
> > unlocking sb->s_umount
> > - set SB_BORN just before unlocking sb->s_umount, just like it would
> > happen when using fc_mount() (Max)
> > - don't allocate a FUSE context for the submounts (Max)
> > - introduce a dedicated context ops for submounts
> > - add a extra cleanup : simplify the code even more with fc_mount()
> >
> > v1:
> >
> > While working on adding syncfs() support in FUSE, I've hit some severe
> > bugs with submounts (a crash and an infinite loop). The fix for the
> > crash is straightforward (patch 1), but the fix for the infinite loop
> > is more invasive : as suggested by Miklos, a simple bug fix is applied
> > first (patch 2) and the final fix (patch 3) is applied on top.
>
> Thanks a lot for these patches. I’ve had a style nit on patch 6, but
> other than that, looks nice to me.
>
Thanks a lot for the review !
Cheers,
--
Greg
> Max
>
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kurz <groug@kaod.org>
To: Max Reitz <mreitz@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com,
linux-kernel@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [Virtio-fs] [PATCH v2 0/7] fuse: Some fixes for submounts
Date: Wed, 9 Jun 2021 09:46:38 +0200 [thread overview]
Message-ID: <20210609094638.197ca7fc@bahia.lan> (raw)
In-Reply-To: <c3d49438-6ee1-32b1-1be4-41be78cec2ce@redhat.com>
On Tue, 8 Jun 2021 17:52:13 +0200
Max Reitz <mreitz@redhat.com> wrote:
> On 04.06.21 18:11, Greg Kurz wrote:
> > v2:
> >
> > - add an extra fix (patch 2) : mount is now added to the list before
> > unlocking sb->s_umount
> > - set SB_BORN just before unlocking sb->s_umount, just like it would
> > happen when using fc_mount() (Max)
> > - don't allocate a FUSE context for the submounts (Max)
> > - introduce a dedicated context ops for submounts
> > - add a extra cleanup : simplify the code even more with fc_mount()
> >
> > v1:
> >
> > While working on adding syncfs() support in FUSE, I've hit some severe
> > bugs with submounts (a crash and an infinite loop). The fix for the
> > crash is straightforward (patch 1), but the fix for the infinite loop
> > is more invasive : as suggested by Miklos, a simple bug fix is applied
> > first (patch 2) and the final fix (patch 3) is applied on top.
>
> Thanks a lot for these patches. I’ve had a style nit on patch 6, but
> other than that, looks nice to me.
>
Thanks a lot for the review !
Cheers,
--
Greg
> Max
>
next prev parent reply other threads:[~2021-06-09 7:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 16:11 [PATCH v2 0/7] fuse: Some fixes for submounts Greg Kurz
2021-06-04 16:11 ` [Virtio-fs] " Greg Kurz
2021-06-04 16:11 ` [PATCH v2 1/7] fuse: Fix crash in fuse_dentry_automount() error path Greg Kurz
2021-06-04 16:11 ` [Virtio-fs] " Greg Kurz
2021-06-04 16:11 ` [PATCH v2 2/7] fuse: Fix crash if superblock of submount gets killed early Greg Kurz
2021-06-04 16:11 ` [Virtio-fs] " Greg Kurz
2021-06-08 15:08 ` Max Reitz
2021-06-08 15:08 ` [Virtio-fs] " Max Reitz
2021-06-04 16:11 ` [PATCH v2 3/7] fuse: Fix infinite loop in sget_fc() Greg Kurz
2021-06-04 16:11 ` [Virtio-fs] " Greg Kurz
2021-06-08 15:12 ` Max Reitz
2021-06-08 15:12 ` [Virtio-fs] " Max Reitz
2021-06-04 16:11 ` [PATCH v2 4/7] fuse: Add dedicated filesystem context ops for submounts Greg Kurz
2021-06-04 16:11 ` [Virtio-fs] " Greg Kurz
2021-06-08 15:25 ` Max Reitz
2021-06-08 15:25 ` [Virtio-fs] " Max Reitz
2021-06-04 16:11 ` [PATCH v2 5/7] fuse: Call vfs_get_tree() " Greg Kurz
2021-06-04 16:11 ` [Virtio-fs] " Greg Kurz
2021-06-08 15:40 ` Max Reitz
2021-06-08 15:40 ` [Virtio-fs] " Max Reitz
2021-06-04 16:11 ` [PATCH v2 6/7] fuse: Switch to fc_mount() " Greg Kurz
2021-06-04 16:11 ` [Virtio-fs] " Greg Kurz
2021-06-08 15:51 ` Max Reitz
2021-06-08 15:51 ` [Virtio-fs] " Max Reitz
2021-06-09 7:45 ` Greg Kurz
2021-06-09 7:45 ` [Virtio-fs] " Greg Kurz
2021-06-11 14:44 ` Miklos Szeredi
2021-06-11 14:44 ` [Virtio-fs] " Miklos Szeredi
2021-06-04 16:11 ` [PATCH v2 7/7] fuse: Make fuse_fill_super_submount() static Greg Kurz
2021-06-04 16:11 ` [Virtio-fs] " Greg Kurz
2021-06-08 15:52 ` [PATCH v2 0/7] fuse: Some fixes for submounts Max Reitz
2021-06-08 15:52 ` [Virtio-fs] " Max Reitz
2021-06-09 7:46 ` Greg Kurz [this message]
2021-06-09 7:46 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609094638.197ca7fc@bahia.lan \
--to=groug@kaod.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mreitz@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.