From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC150C47095 for ; Wed, 9 Jun 2021 10:00:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22703610C7 for ; Wed, 9 Jun 2021 10:00:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22703610C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqv0D-0006O7-5c for qemu-devel@archiver.kernel.org; Wed, 09 Jun 2021 06:00:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lquzS-00053w-5P for qemu-devel@nongnu.org; Wed, 09 Jun 2021 05:59:14 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:39483) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lquzQ-0002tB-5m for qemu-devel@nongnu.org; Wed, 09 Jun 2021 05:59:13 -0400 Received: by mail-lj1-x229.google.com with SMTP id c11so30904909ljd.6 for ; Wed, 09 Jun 2021 02:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I5rIk8UWqTGEV6Rmkzt6tHSaJHcV+PBskMtsqg/NEeA=; b=zMHMVQeMzQWLUgw8b1AeQwfuFkjHrpcP1luTs/w/QZi5Fqt6ArR6NSc5eRISicLFgt Uvfo5wEPQ5sS91VD+d+v8K85gEIEntvwNW87eL6lhc7xnkzm04XizCpLtODLcUU14t+1 CRTXJWcLOkt/jeVUxlpkj7GQf4V4tuuN2tYvJ9c60yACmoJuffC8ZAvRN8l7I6IjKZNo SyuJUZAgRk9Bl6h1cUkcN1EjaoZI8KyH2A4oEa7jAaRQo7edHoYY7jJ3pooXfc1niNsD MNIHW00oRlgG2KSZasqpsRDofZc6MKceSl5Egc4Tu+v6zl3/gx3DFIb88L2GjkI36rDC mN7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I5rIk8UWqTGEV6Rmkzt6tHSaJHcV+PBskMtsqg/NEeA=; b=sk0c5Y8OJ5pOa5zNVLTWdJ/8ldDfIsMVEl6y2ic4sUYifRr3EUDe+NsDNIDKB+amP3 SZgy/MGQ+zreHCH2JtaE1nRBkLTdtWVhnA8QhOoWJEFTU+8wLx/fDqBvIAn0ILrbhBqw hiJwlkdTh7o9Nw7m3z/21i834tKlPhmFnkgcUUoNHYOQQQR9SD/Q4owxwri2vW7F5LF5 RFaF9bvNRUWXqzh3cVGuwxHUBRqxnGU9x1yUG49rZLwwHGAfokKoxyVMU/aH92jJQNlE iK7JIqpBqZFzRxnDGzgLaN0JA7Rsf7dLvZiKixJ2cmX1sUdHlSz0jdhD4um6LfWhIOfX 3p2w== X-Gm-Message-State: AOAM533HLaOsOQxJGWm4ji18PZ4AWrsJ0o7SVYrF8OySLa70f4RiprFA F1a9sxmHnGW/7XHWvauCMOK1rw== X-Google-Smtp-Source: ABdhPJwm3iFLk5aOIHzHgpECrobhXPk6alfdP6OZtXFYWo5GXrGQgl27nFgCsme81RsdItFnFGzhUQ== X-Received: by 2002:a05:651c:17a8:: with SMTP id bn40mr22014441ljb.288.1623232749903; Wed, 09 Jun 2021 02:59:09 -0700 (PDT) Received: from navi.cosmonova.net.ua ([95.67.24.131]) by smtp.gmail.com with ESMTPSA id q6sm218751lfj.88.2021.06.09.02.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 02:59:09 -0700 (PDT) From: Andrew Melnychenko To: mst@redhat.com Subject: [PATCH 0/3] virtio-pci: Checks for virtio device presence on the bus. Date: Wed, 9 Jun 2021 12:58:40 +0300 Message-Id: <20210609095843.141378-1-andrew@daynix.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=2a00:1450:4864:20::229; envelope-from=andrew@daynix.com; helo=mail-lj1-x229.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" At some point, after unplugging virtio-pci the virtio device may be unrealised, but the memory regions may be present in flatview. So, it's a possible situation when memory region's callbacks are called for "unplugged" device. In patches were added checks for virtio device presence on virtio-bus. Added checks in PCI config callbacks. Also changed return values in memory regions read if virtio not present. BZ link https://bugzilla.redhat.com/show_bug.cgi?id=1938042 The issue similar to https://bugzilla.redhat.com/show_bug.cgi?id=1743098 Backtrace: at ../hw/virtio/virtio-pci.c:1271 proxy = 0x560b535f8bf0 vdev = 0x0 (mr=, addr=, value=, size=, shift=, mask=, attrs=...) at ../softmmu/memory.c:491 tmp = (addr=addr@entry=22, value=value@entry=0x7fd743dfe518, size=size@entry=2, access_size_min=, access_size_max=, access_fn=0x560b513fc500 , mr=0x560b535f95d0, attrs=...) at ../softmmu/memory.c:552 access_mask = 65535 access_size = 2 i = r = 0 (mr=mr@entry=0x560b535f95d0, addr=22, data=, op=, attrs=attrs@entry=...) at ../softmmu/memory.c:1501 size = 2 (fv=fv@entry=0x7fd6f005d3b0, addr=addr@entry=4246716438, attrs=..., ptr=ptr@entry=0x7fe69b2b0028, len=len@entry=2, addr1=, l=, mr=0x560b535f95d0) at /usr/src/debug/qemu-kvm-5.2.0-11.module+el8.4.0+10268+62bcbbed.x86_64/include/qemu/host-utils.h:164 ram_ptr = val = result = 0 release_lock = true buf = 0x7fe69b2b0028 "" at ../softmmu/physmem.c:2799 l = 2 addr1 = 22 mr = result = 0 _rcu_read_auto = 0x1 result = 0 fv = attrs = {unspecified = 0, secure = 0, user = 0, requester_id = 0, byte_swap = 0, target_tlb_bit0 = 0, target_tlb_bit1 = 0, target_tlb_bit2 = 0} run = ret = run_ret = 0 cpu = 0x560b522738d0 r = __clframe = {__cancel_routine = , __cancel_arg = 0x0, __do_it = 1, __cancel_type = } qemu_thread_args = 0x560b5229a6f0 start_routine = 0x560b513faeb0 arg = 0x560b522738d0 r = Andrew Melnychenko (3): virtio-pci: Added check for virtio device presence in mm callbacks. virtio-pci: Added check for virtio device in PCI config cbs. virtio-pci: Changed return values for "notify", "device" and "isr" read. hw/virtio/virtio-pci.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) -- 2.31.1