From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6E86C48BDF for ; Wed, 9 Jun 2021 10:33:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B16EF61375 for ; Wed, 9 Jun 2021 10:33:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238843AbhFIKfd (ORCPT ); Wed, 9 Jun 2021 06:35:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45809 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237099AbhFIKfb (ORCPT ); Wed, 9 Jun 2021 06:35:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623234816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I6RFVrIlNJV4mNL6ANvqt/Qw3/Fb8/fimwbEL77gRdY=; b=Se/Jnr20uz842cvy5EzrPDhTqyUpEMx/0VYixupQpQMpNGrUIJAp3nEQgsnnj0TNLA2RWU qTumO9CSva93AGmTCJMHIm3A8nS0RKMAGEdd/Jmfkt1W/4r47SuVaHnGVpT7ebelsrWyNo YtHsHq1Zn+fRR3PICuXXhvZecB6Qddk= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-277-YyiJCZ-LPjWnWRccwhywJQ-1; Wed, 09 Jun 2021 06:33:35 -0400 X-MC-Unique: YyiJCZ-LPjWnWRccwhywJQ-1 Received: by mail-ed1-f71.google.com with SMTP id t11-20020a056402524bb029038ffacf1cafso2860371edd.5 for ; Wed, 09 Jun 2021 03:33:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I6RFVrIlNJV4mNL6ANvqt/Qw3/Fb8/fimwbEL77gRdY=; b=rfcG6jkXWIgzDYE8Y2KKdCHF7YhofkMkDtQrTi24pQ62EwJ62NAFIg+ms24by1NEMU DHAmFBPW+sGMthujnVxDk9liJHeGav7snaSYKbC9SS5D0PuBmdL/FaR+kVZTxkOcTtBh tjznNMlFsk9esyaLzPzqKrvIfXA+SLEiEhgttQKbGKJ9lkCsC35vaFv2wc02x7bIfjV1 oYYiOmiT06UUU3qm6zQUNvGsmmgniUEtjSHYnYYL4c5SU+VU9rjzSFR5QsfTTG3NrDx+ ZaVZPcdU1ZJu4jm9uU5b/7BkSX5ncg3wRVOZWgRv9GU+Nsb8ZvvpUPHET7fn8y5xN3v6 JkJw== X-Gm-Message-State: AOAM533cRpeR43veJMxpKinrumrHHluFmIuTIS1KrlLt0TT6/L1IoDzm SfIZtM+1TSvlht/yHsxs1x8pifK1DlUKMkj8yjVpa4czMEClkF60owQSzlrmghdmT64R69AD7EU VtiBtJwTwL/bN X-Received: by 2002:a17:906:1792:: with SMTP id t18mr16230746eje.38.1623234814355; Wed, 09 Jun 2021 03:33:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSS/+KNKnXT0QQpuEWI8iYGTn6gTZHYpHRtIhPO3wIfSXPTo2W2Il/Qh2CqA4beAkAqr+45A== X-Received: by 2002:a17:906:1792:: with SMTP id t18mr16230736eje.38.1623234814221; Wed, 09 Jun 2021 03:33:34 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id cx7sm967596edb.65.2021.06.09.03.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 03:33:32 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 7FE50180729; Wed, 9 Jun 2021 12:33:30 +0200 (CEST) From: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= To: bpf@vger.kernel.org, netdev@vger.kernel.org Cc: Martin KaFai Lau , Hangbin Liu , Jesper Dangaard Brouer , Magnus Karlsson , "Paul E . McKenney" , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Guy Tzalik , Saeed Bishara Subject: [PATCH bpf-next 05/17] ena: remove rcu_read_lock() around XDP program invocation Date: Wed, 9 Jun 2021 12:33:14 +0200 Message-Id: <20210609103326.278782-6-toke@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210609103326.278782-1-toke@redhat.com> References: <20210609103326.278782-1-toke@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org The ena driver has rcu_read_lock()/rcu_read_unlock() pairs around XDP program invocations. However, the actual lifetime of the objects referred by the XDP program invocation is longer, all the way through to the call to xdp_do_flush(), making the scope of the rcu_read_lock() too small. This turns out to be harmless because it all happens in a single NAPI poll cycle (and thus under local_bh_disable()), but it makes the rcu_read_lock() misleading. Rather than extend the scope of the rcu_read_lock(), just get rid of it entirely. With the addition of RCU annotations to the XDP_REDIRECT map types that take bh execution into account, lockdep even understands this to be safe, so there's really no reason to keep it around. Cc: Guy Tzalik Cc: Saeed Bishara Signed-off-by: Toke Høiland-Jørgensen --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index 881f88754bf6..a4378b14af4c 100644 --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c @@ -385,7 +385,6 @@ static int ena_xdp_execute(struct ena_ring *rx_ring, struct xdp_buff *xdp) u64 *xdp_stat; int qid; - rcu_read_lock(); xdp_prog = READ_ONCE(rx_ring->xdp_bpf_prog); if (!xdp_prog) @@ -443,8 +442,6 @@ static int ena_xdp_execute(struct ena_ring *rx_ring, struct xdp_buff *xdp) ena_increase_stat(xdp_stat, 1, &rx_ring->syncp); out: - rcu_read_unlock(); - return verdict; } -- 2.31.1