From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D84C9C48BCD for ; Wed, 9 Jun 2021 21:57:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCF29613DF for ; Wed, 9 Jun 2021 21:57:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229989AbhFIV7d (ORCPT ); Wed, 9 Jun 2021 17:59:33 -0400 Received: from mail-ot1-f51.google.com ([209.85.210.51]:44669 "EHLO mail-ot1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbhFIV7b (ORCPT ); Wed, 9 Jun 2021 17:59:31 -0400 Received: by mail-ot1-f51.google.com with SMTP id q5-20020a9d66450000b02903f18d65089fso9258483otm.11; Wed, 09 Jun 2021 14:57:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c7WxSL952AsDBW+4Q+slVrXXE4mBT22/Jigijej7zVs=; b=QvwudXpefizh5l8ptOup9n7sjq6enz5kIftWOR/AAF2RV8PR7lzyMAl/cEdqMC+aO5 5HplrVFCWTaYpMaohtDfEU6Z/f9dOyBY8QVWgH1fj0ZL8/y0F+rEpX8sJTonk8qjWiR+ K+UEAOP18hou7oCNqfnE0gB9qklfnfdYPd3r1UbcebwmeJ02LYQXroK/EjvbwU15XutP a8sNIaQbXcqKAQin60AHoYWO6ffNZWW2WeOGC9cIjK6fuT4DgmPeJoP7F2l2hfgrv3UR DvQRg9BAGZofMYz0GhvGvDqmScTs+SsAJnIjZBLfCAj0RdmefOo3gS0fWC2yUWORUyDa nelg== X-Gm-Message-State: AOAM531pKC4EffGWMtzYBD6Mgip9q0Yi7OGA5haILB4znJjGXvKVs3wv j/4U5+MNHS2BMRwMJtIrPw== X-Google-Smtp-Source: ABdhPJy6bcqCt9Nr7mez/COGdYXUV+b7ETIQSyxBwcojEj07xvqX689RWOJae7Mqf1SPDoohBZOb8Q== X-Received: by 2002:a9d:355:: with SMTP id 79mr1336380otv.101.1623275846809; Wed, 09 Jun 2021 14:57:26 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id k8sm198439ool.5.2021.06.09.14.57.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 14:57:25 -0700 (PDT) Received: (nullmailer pid 168056 invoked by uid 1000); Wed, 09 Jun 2021 21:57:24 -0000 Date: Wed, 9 Jun 2021 16:57:24 -0500 From: Rob Herring To: Jonathan Marek Cc: freedreno@lists.freedesktop.org, Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Vinod Koul , Anurag Kumar Vulisha , Laurent Pinchart , Swapnil Jakhade , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v3 2/3] dt-bindings: msm: dsi: document phy-type property for 7nm dsi phy Message-ID: <20210609215724.GA163102@robh.at.kernel.org> References: <20210608195342.18269-1-jonathan@marek.ca> <20210608195342.18269-3-jonathan@marek.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210608195342.18269-3-jonathan@marek.ca> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jun 08, 2021 at 03:53:28PM -0400, Jonathan Marek wrote: > Document a new phy-type property which will be used to determine whether > the phy should operate in D-PHY or C-PHY mode. > > Signed-off-by: Jonathan Marek > --- > .../devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 4 ++++ > include/dt-bindings/phy/phy.h | 2 ++ > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > index bf16b1c65e10..d447b517ea19 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > @@ -34,6 +34,10 @@ properties: > description: | > Connected to VDD_A_DSI_PLL_0P9 pin (or VDDA_DSI{0,1}_PLL_0P9 for sm8150) > > + phy-type: > + description: | > + D-PHY (default) or C-PHY mode: PHY_TYPE_DSI_DPHY or PHY_TYPE_DSI_CPHY Don't write prose for what can be schema. Unfortunately, can't do defines here, but you need: enum: [ 10, 11 ] default: 10 > + > required: > - compatible > - reg > diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h > index 887a31b250a8..b978dac16bb8 100644 > --- a/include/dt-bindings/phy/phy.h > +++ b/include/dt-bindings/phy/phy.h > @@ -20,5 +20,7 @@ > #define PHY_TYPE_XPCS 7 > #define PHY_TYPE_SGMII 8 > #define PHY_TYPE_QSGMII 9 > +#define PHY_TYPE_DSI_DPHY 10 > +#define PHY_TYPE_DSI_CPHY 11 > > #endif /* _DT_BINDINGS_PHY */ > -- > 2.26.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDB96C48BCD for ; Wed, 9 Jun 2021 21:57:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82E5C613E1 for ; Wed, 9 Jun 2021 21:57:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82E5C613E1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F27976EB1C; Wed, 9 Jun 2021 21:57:28 +0000 (UTC) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 541DF6EB1C; Wed, 9 Jun 2021 21:57:27 +0000 (UTC) Received: by mail-ot1-f42.google.com with SMTP id j11-20020a9d738b0000b02903ea3c02ded8so11877912otk.5; Wed, 09 Jun 2021 14:57:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c7WxSL952AsDBW+4Q+slVrXXE4mBT22/Jigijej7zVs=; b=egu7o+7oCColcyiMdHHhAAGwcdc5plx5YMeH39r7A1s3A/L6GdTGsVsvBjinEYMTQ2 ctFG0QaIpA2VMWhl6c5znu6aoOEoGtFgIxyYXQ/7HS7K6RxO/74bFseQAzskTvI6WDJI Hjsq1wdFjKvKzAXI4XHHaHoX6jagIx2vURSfa2CbjrMQ/C+K5Unoz+do271aA4WzMC5+ un5MyTg9TuOcT1oY9pdVwn295KpQbRZLkh9EKge3tnTtPDSycZCWZQe0wO0sKXmQ0BpJ y7b7lYnLgReFoCtD81TrkZ5MZAjbMgz7inFKKl+BVQFw3uhFXhPO5gbzirVzW/zZQ3/6 3qyA== X-Gm-Message-State: AOAM5323dUhodRDWkz+XdfwLNoXf/9RLFTYjJeJeYeMNwqtFO9uy0O0i Are00Db/YGqWj/LmALGJyA== X-Google-Smtp-Source: ABdhPJy6bcqCt9Nr7mez/COGdYXUV+b7ETIQSyxBwcojEj07xvqX689RWOJae7Mqf1SPDoohBZOb8Q== X-Received: by 2002:a9d:355:: with SMTP id 79mr1336380otv.101.1623275846809; Wed, 09 Jun 2021 14:57:26 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id k8sm198439ool.5.2021.06.09.14.57.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 14:57:25 -0700 (PDT) Received: (nullmailer pid 168056 invoked by uid 1000); Wed, 09 Jun 2021 21:57:24 -0000 Date: Wed, 9 Jun 2021 16:57:24 -0500 From: Rob Herring To: Jonathan Marek Subject: Re: [PATCH v3 2/3] dt-bindings: msm: dsi: document phy-type property for 7nm dsi phy Message-ID: <20210609215724.GA163102@robh.at.kernel.org> References: <20210608195342.18269-1-jonathan@marek.ca> <20210608195342.18269-3-jonathan@marek.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210608195342.18269-3-jonathan@marek.ca> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Anurag Kumar Vulisha , David Airlie , freedreno@lists.freedesktop.org, "open list:DRM DRIVER FOR MSM ADRENO GPU" , Vinod Koul , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , Laurent Pinchart , Swapnil Jakhade , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 08, 2021 at 03:53:28PM -0400, Jonathan Marek wrote: > Document a new phy-type property which will be used to determine whether > the phy should operate in D-PHY or C-PHY mode. > > Signed-off-by: Jonathan Marek > --- > .../devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 4 ++++ > include/dt-bindings/phy/phy.h | 2 ++ > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > index bf16b1c65e10..d447b517ea19 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > @@ -34,6 +34,10 @@ properties: > description: | > Connected to VDD_A_DSI_PLL_0P9 pin (or VDDA_DSI{0,1}_PLL_0P9 for sm8150) > > + phy-type: > + description: | > + D-PHY (default) or C-PHY mode: PHY_TYPE_DSI_DPHY or PHY_TYPE_DSI_CPHY Don't write prose for what can be schema. Unfortunately, can't do defines here, but you need: enum: [ 10, 11 ] default: 10 > + > required: > - compatible > - reg > diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h > index 887a31b250a8..b978dac16bb8 100644 > --- a/include/dt-bindings/phy/phy.h > +++ b/include/dt-bindings/phy/phy.h > @@ -20,5 +20,7 @@ > #define PHY_TYPE_XPCS 7 > #define PHY_TYPE_SGMII 8 > #define PHY_TYPE_QSGMII 9 > +#define PHY_TYPE_DSI_DPHY 10 > +#define PHY_TYPE_DSI_CPHY 11 > > #endif /* _DT_BINDINGS_PHY */ > -- > 2.26.1