From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4283C48BD1 for ; Thu, 10 Jun 2021 03:50:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC5BB613FE for ; Thu, 10 Jun 2021 03:50:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229557AbhFJDwG (ORCPT ); Wed, 9 Jun 2021 23:52:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229655AbhFJDwF (ORCPT ); Wed, 9 Jun 2021 23:52:05 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AF0AC061574 for ; Wed, 9 Jun 2021 20:50:09 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id fy24-20020a17090b0218b029016c5a59021fso2935796pjb.0 for ; Wed, 09 Jun 2021 20:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pwLscPt/B/b/5SFEs+HEyMeL+d3/cTsy8u9p+tu3dIo=; b=qv8v8cqG/Ai5hMpH29a1Q5T6WTaZ4NIrnjR7FhyNFtOKgcW9hmlCU70zYVrhvvDLqY UY33gGZykUoKQSAN9jQCoq/iedqBijDGaSG035hsMTsxxl2VjuFMFBycKVk4I8QL3dfS 3ro3lQ0sgaBszICT3LUjgW505aUGgNdBPhJR1N8FyGvY4IhC8ir8pbLZX7y8JOXGxnwZ RNIWKR0wV3CaJBWXRzNxUUc26pgmlBhEJ8r1dEEjOxE56liOa4YtS1iuOnA9XdcXcHcm mYQSg17HTK0Xrh4dTpVrfJtw7GuzTm341QJDbqS5a44hgXqMoe0rVoeo4WJrpQhANm2b qSSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=pwLscPt/B/b/5SFEs+HEyMeL+d3/cTsy8u9p+tu3dIo=; b=Yf96/KeEsw4f6CF9NplIBF/vkQ3bCPbwDgdKT+uoMbL6PAO91O4PUAXiN/+CzjUIgi ODDleraD1+pgLJiTY3tojd2F5KEEaWeP5x8AF5o7VcpYOHoTaTZ0xGXJraz2gNIuzWlu e+vEYWRABrAY5jmXiCjYguhjOBjW7UeWVWZEI9RhSilkT6/PfETS/ixskbn1n9GzCUQy Et15rtaFYOwddQbJuSNKntfvAcEZ2E/wSC7/Rhi0prqGdAnp03+15Vqhei3X/+Lk2vCL fL4LqLE2KrpIqgVfXEp1iAfl0Fj6WeoFB/fu2VYlYUI1Jh0YKo2wM3+HslZlXx63AgUf meww== X-Gm-Message-State: AOAM530bMFA+MR1zGyX24xDfWzV5koKmn/qnKDy/vvDGWcjIcbRqXOhM MN+dyuOagGh5NQ2e2Lm0Kog= X-Google-Smtp-Source: ABdhPJxYN735f1W6bGAzwHfU6tFYnMOyQ9KVGyE7AC5r+T8MjcCYyzO3aS0lWNvp10/46STzr3lIkw== X-Received: by 2002:a17:90a:6289:: with SMTP id d9mr1157140pjj.84.1623297009088; Wed, 09 Jun 2021 20:50:09 -0700 (PDT) Received: from localhost.localdomain ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id j13sm1062652pgp.29.2021.06.09.20.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 20:50:08 -0700 (PDT) Sender: "joel.stan@gmail.com" From: Joel Stanley To: Fabio Estevam , Peter Chen , Arnd Bergmann , Felipe Balbi Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs Date: Thu, 10 Jun 2021 13:19:57 +0930 Message-Id: <20210610034957.93376-1-joel@jms.id.au> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver") dropped the ARCH_MXC dependency from USB_FSL_USB2, leaving it depending solely on FSL_SOC. FSL_SOC is powerpc only; it was briefly available on ARM in 2014 but was removed by commit cfd074ad8600 ("ARM: imx: temporarily remove CONFIG_SOC_FSL from LS1021A"). Therefore the driver can no longer be enabled on ARM platforms. This appears to be a mistake as arm64's ARCH_LAYERSCAPE and arm32 SOC_LS1021A SoCs use this symbol. It's enabled in these defconfigs: arch/arm/configs/imx_v6_v7_defconfig:CONFIG_USB_FSL_USB2=y arch/arm/configs/multi_v7_defconfig:CONFIG_USB_FSL_USB2=y arch/powerpc/configs/mgcoge_defconfig:CONFIG_USB_FSL_USB2=y arch/powerpc/configs/mpc512x_defconfig:CONFIG_USB_FSL_USB2=y To fix, expand the dependencies so USB_FSL_USB2 can be enabled on the ARM platforms, and with COMPILE_TEST. Fixes: a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver") Signed-off-by: Joel Stanley --- v2: Fix spelling of ARCH_LAYERSCAPE --- drivers/usb/gadget/udc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig index 8c614bb86c66..7348acbdc560 100644 --- a/drivers/usb/gadget/udc/Kconfig +++ b/drivers/usb/gadget/udc/Kconfig @@ -90,7 +90,7 @@ config USB_BCM63XX_UDC config USB_FSL_USB2 tristate "Freescale Highspeed USB DR Peripheral Controller" - depends on FSL_SOC + depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST help Some of Freescale PowerPC and i.MX processors have a High Speed Dual-Role(DR) USB controller, which supports device mode. -- 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66909C47094 for ; Thu, 10 Jun 2021 03:54:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 302CA61407 for ; Thu, 10 Jun 2021 03:54:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 302CA61407 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=jmHchgQDqjvFCWIlU07uRLeigWK74VZEvzwSraCkNNI=; b=P/wdKFETooWd/s oP9Q9LMzjhsaflSnncu3U75eXDRuty9+/q15xfZcKUKrvR21UhOuwgDr0ZCPzKRbt8TPENNtS39C2 6XMHm0d85tdQleBYE1pWK64IWO0Ppk+Kz6xvq6YFDU3KQimMck+vJvtOdGtrmNyNQZDukjV8+zdy9 dRUHIe8XN+yBrbH+S/HtvYYEK+dS5KUzsCw041KmIda2T7nWhgRF8ha0Wjs1gFZCZildF+VnzjxnN fuCtD4KGXlLVUeQiISSMsMSx+qxIKDavv7Gl2ivxSM85nJAItBFAwWi45lPN779pCDyegg1yczQaa sitPfkpEs4MQF79SdEIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrBht-00Ghfn-76; Thu, 10 Jun 2021 03:50:13 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrBhp-00Ghf8-TW for linux-arm-kernel@lists.infradead.org; Thu, 10 Jun 2021 03:50:11 +0000 Received: by mail-pj1-x1029.google.com with SMTP id k5so2833488pjj.1 for ; Wed, 09 Jun 2021 20:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pwLscPt/B/b/5SFEs+HEyMeL+d3/cTsy8u9p+tu3dIo=; b=qv8v8cqG/Ai5hMpH29a1Q5T6WTaZ4NIrnjR7FhyNFtOKgcW9hmlCU70zYVrhvvDLqY UY33gGZykUoKQSAN9jQCoq/iedqBijDGaSG035hsMTsxxl2VjuFMFBycKVk4I8QL3dfS 3ro3lQ0sgaBszICT3LUjgW505aUGgNdBPhJR1N8FyGvY4IhC8ir8pbLZX7y8JOXGxnwZ RNIWKR0wV3CaJBWXRzNxUUc26pgmlBhEJ8r1dEEjOxE56liOa4YtS1iuOnA9XdcXcHcm mYQSg17HTK0Xrh4dTpVrfJtw7GuzTm341QJDbqS5a44hgXqMoe0rVoeo4WJrpQhANm2b qSSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=pwLscPt/B/b/5SFEs+HEyMeL+d3/cTsy8u9p+tu3dIo=; b=Zr03OV9qXJWfy1RtNp/WYfItMyHsRM1YlCF6jsdzS27+U4DrhGifDXrtEtRxRH0Maf uxm6xouqJ5VxMGmeo3XP/PJ9m4Tj+q4Sdrgi3V43Pkxka02YdO44joqaRTWE5ccFgjHg 3koljRpGB5aL93syhJjp5zdxhO4CJBRq11LQOWI3jIfKeTlYis8kVFPtFNTgnv82LnFG gem5YCjQjRd9xlOBZJ9I9itPSyM7iucUleIEsnlUScmlJkx5dCfpLV8R/eCTX0tNNBjr s/Ww5Uo7CYeX4Ns25pn+Zsx3JzJU2ZbjC6s93SNWzJ5pDTxBf3nQ3M+IbyjMRrnN4rkM Qz1A== X-Gm-Message-State: AOAM530lQKXI3flm1fsJI7ls6SaOs6qSY5I75x47PyjMWWVsFv/K0R5K JRMKBT7jhB2OgEr77S3h0cg= X-Google-Smtp-Source: ABdhPJxYN735f1W6bGAzwHfU6tFYnMOyQ9KVGyE7AC5r+T8MjcCYyzO3aS0lWNvp10/46STzr3lIkw== X-Received: by 2002:a17:90a:6289:: with SMTP id d9mr1157140pjj.84.1623297009088; Wed, 09 Jun 2021 20:50:09 -0700 (PDT) Received: from localhost.localdomain ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id j13sm1062652pgp.29.2021.06.09.20.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 20:50:08 -0700 (PDT) From: Joel Stanley To: Fabio Estevam , Peter Chen , Arnd Bergmann , Felipe Balbi Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs Date: Thu, 10 Jun 2021 13:19:57 +0930 Message-Id: <20210610034957.93376-1-joel@jms.id.au> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_205009_992857_FF459E25 X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver") dropped the ARCH_MXC dependency from USB_FSL_USB2, leaving it depending solely on FSL_SOC. FSL_SOC is powerpc only; it was briefly available on ARM in 2014 but was removed by commit cfd074ad8600 ("ARM: imx: temporarily remove CONFIG_SOC_FSL from LS1021A"). Therefore the driver can no longer be enabled on ARM platforms. This appears to be a mistake as arm64's ARCH_LAYERSCAPE and arm32 SOC_LS1021A SoCs use this symbol. It's enabled in these defconfigs: arch/arm/configs/imx_v6_v7_defconfig:CONFIG_USB_FSL_USB2=y arch/arm/configs/multi_v7_defconfig:CONFIG_USB_FSL_USB2=y arch/powerpc/configs/mgcoge_defconfig:CONFIG_USB_FSL_USB2=y arch/powerpc/configs/mpc512x_defconfig:CONFIG_USB_FSL_USB2=y To fix, expand the dependencies so USB_FSL_USB2 can be enabled on the ARM platforms, and with COMPILE_TEST. Fixes: a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver") Signed-off-by: Joel Stanley --- v2: Fix spelling of ARCH_LAYERSCAPE --- drivers/usb/gadget/udc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig index 8c614bb86c66..7348acbdc560 100644 --- a/drivers/usb/gadget/udc/Kconfig +++ b/drivers/usb/gadget/udc/Kconfig @@ -90,7 +90,7 @@ config USB_BCM63XX_UDC config USB_FSL_USB2 tristate "Freescale Highspeed USB DR Peripheral Controller" - depends on FSL_SOC + depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST help Some of Freescale PowerPC and i.MX processors have a High Speed Dual-Role(DR) USB controller, which supports device mode. -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel