All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Perez de Castro <aperez@igalia.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libpsl: needs wchar
Date: Thu, 10 Jun 2021 06:26:13 +0300	[thread overview]
Message-ID: <20210610062613.GB135851@momiji> (raw)
In-Reply-To: <20210609214130.1593145-1-fontaine.fabrice@gmail.com>

Hi,

On Wed, 09 Jun 2021 23:41:30 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Add a dependency on wchar as both icu and libunistring needs wchar

Good catch, thanks! \o/

> Fixes:
>  - http://autobuild.buildroot.org/results/704d8e6f8b78015180e5b12c132495425637430a
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
>  package/libpsl/Config.in  | 4 ++++
>  package/libsoup/Config.in | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libpsl/Config.in b/package/libpsl/Config.in
> index dd484799e7..de77ff8d10 100644
> --- a/package/libpsl/Config.in
> +++ b/package/libpsl/Config.in
> @@ -1,8 +1,12 @@
>  config BR2_PACKAGE_LIBPSL
>  	bool "libpsl"
> +	depends on BR2_USE_WCHAR
>  	select BR2_PACKAGE_LIBIDN2 if !BR2_PACKAGE_ICU && !BR2_PACKAGE_LIBIDN
>  	select BR2_PACKAGE_LIBUNISTRING if !BR2_PACKAGE_ICU
>  	help
>  	  C library to handle the Public Suffix List of TLDs.
>  
>  	  https://github.com/rockdaboot/libpsl
> +
> +comment "libpsl needs a toolchain w/ wchar"
> +	depends on !BR2_USE_WCHAR
> diff --git a/package/libsoup/Config.in b/package/libsoup/Config.in
> index 47adfb33f2..0c0454c7c2 100644
> --- a/package/libsoup/Config.in
> +++ b/package/libsoup/Config.in
> @@ -1,6 +1,6 @@
>  config BR2_PACKAGE_LIBSOUP
>  	bool "libsoup"
> -	depends on BR2_USE_WCHAR # glib2 and gnutls
> +	depends on BR2_USE_WCHAR # glib2, gnutls and libpsl
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
>  	depends on BR2_USE_MMU # glib2
>  	select BR2_PACKAGE_LIBXML2
> -- 
> 2.30.2
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210610/b6ccebfb/attachment.asc>

  reply	other threads:[~2021-06-10  3:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09 21:41 [Buildroot] [PATCH 1/1] package/libpsl: needs wchar Fabrice Fontaine
2021-06-10  3:26 ` Adrian Perez de Castro [this message]
2021-06-20 13:54 ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210610062613.GB135851@momiji \
    --to=aperez@igalia.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.