Re: [PATCH][next] ACPI: scan: ensure ret is initialized to avoid garbage being returned

From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daniel Scally <djrscally@gmail.com>
Cc: Colin King <colin.king@canonical.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	Maximilian Luz <luzmaximilian@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] ACPI: scan: ensure ret is initialized to avoid garbage being returned
Date: Thu, 10 Jun 2021 09:29:39 +0300	[thread overview]
Message-ID: <20210610062939.GI1955@kadam> (raw)
In-Reply-To: <CAFLoDVE03-Eqmrji66P-b79ezgD0PayWqO5u3L7nyjMX1+LBtg@mail.gmail.com>

On Wed, Jun 09, 2021 at 10:38:04PM +0100, Daniel Scally wrote:
> Hi Colin
> 
> On Wed, Jun 9, 2021 at 6:33 PM Colin King <colin.king@canonical.com> wrote:
> >
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > In the unlikely event that there are no callback calls made then ret
> > will be returned as an uninitialized value. Clean up static analysis
> > warnings by ensuring ret is initialized.
> 
> Ah, thanks - good spot.
> 
> > Addresses-Coverity: ("Uninitialized scalar variable")
> > Fixes: a9e10e587304 ("ACPI: scan: Extend acpi_walk_dep_device_list()")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Reviewed-by: Daniel Scally <djrscally@gmail.com>
> 
> I'm still bad at Git; will the commit hash here be right, since the
> patch that this fixes isn't upstream yet?

The hash is stable unless the branch rebases.  When maintainers rebase a
branch, they're expected to update the Fixes tags as well.  Most people
probably have a script to do it.  I think Stephen Rothwell has a script
which checks whether Fixes tags are correct?

regards,
dan carpenter