From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org,
"Alex Bennée" <alex.bennee@linaro.org>,
"Andrew Strauss" <astrauss11@gmail.com>
Subject: [PATCH v2] semihosting/arm-compat: remove heuristic softmmu SYS_HEAPINFO
Date: Thu, 10 Jun 2021 11:26:17 +0100 [thread overview]
Message-ID: <20210610102617.17281-1-alex.bennee@linaro.org> (raw)
The previous numbers were a guess at best. While we could extract the
information from a loaded ELF file via -kernel we could still get
tripped up by self decompressing or relocating code. Besides sane
library code like newlib will fall back to known symbols to determine
of the location of the heap. We can still report the limits though as
we are reasonably confident that busting out of RAM would be a bad
thing for either stack or heap.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Andrew Strauss <astrauss11@gmail.com>
Reviewed-by: Andrew Strauss <astrauss11@gmail.com>
Message-Id: <20210601090715.22330-1-alex.bennee@linaro.org>
---
v2
- report some known information (limits)
- reword the commit message
---
semihosting/arm-compat-semi.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c
index 1c29146dcf..8873486e8c 100644
--- a/semihosting/arm-compat-semi.c
+++ b/semihosting/arm-compat-semi.c
@@ -1202,10 +1202,14 @@ target_ulong do_common_semihosting(CPUState *cs)
retvals[3] = 0; /* Stack limit. */
#else
limit = current_machine->ram_size;
- /* TODO: Make this use the limit of the loaded application. */
- retvals[0] = rambase + limit / 2;
- retvals[1] = rambase + limit;
- retvals[2] = rambase + limit; /* Stack base */
+ /*
+ * Reporting 0 indicates we couldn't calculate the real
+ * values which should force most software to fall back to
+ * using information it has.
+ */
+ retvals[0] = 0; /* Heap Base */
+ retvals[1] = rambase + limit; /* Heap Limit */
+ retvals[2] = 0; /* Stack base */
retvals[3] = rambase; /* Stack limit. */
#endif
--
2.20.1
next reply other threads:[~2021-06-10 10:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 10:26 Alex Bennée [this message]
2021-06-10 10:57 ` [PATCH v2] semihosting/arm-compat: remove heuristic softmmu SYS_HEAPINFO Peter Maydell
2021-06-10 13:55 ` Alex Bennée
2021-06-10 12:32 ` Peter Maydell
2021-06-10 14:12 ` Alex Bennée
2021-06-10 14:25 ` Peter Maydell
2021-06-11 17:01 ` Alex Bennée
2021-06-13 14:58 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610102617.17281-1-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=astrauss11@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.