All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: a64-sopine-baseboard: change RGMII mode to TXID
Date: Thu, 10 Jun 2021 14:52:09 +0200	[thread overview]
Message-ID: <20210610125209.glrd2qlpwqiha24h@gilmour> (raw)
In-Reply-To: <20210609083843.463750-1-icenowy@aosc.io>

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

On Wed, Jun 09, 2021 at 04:38:43PM +0800, Icenowy Zheng wrote:
> Although the schematics of Pine A64-LTS and SoPine Baseboard shows both
> the RX and TX internal delay are enabled, they're using the same broken
> RTL8211E chip batch with Pine A64+, so they should use TXID instead, not
> ID.
> 
> In addition, by checking the real components soldered on both a SoPine
> Baseboard and a Pine A64-LTS, RX delay is not enabled (GR69 soldered and
> GR70 NC) despite the schematics says it's enabled. It's a common
> situation for Pine64 boards that the NC information on schematics is not
> the same with the board.
> 
> So the RGMII delay mode should be TXID on these boards.
> 
> Fixes: c2b111e59a7b ("arm64: dts: allwinner: A64 Sopine: phy-mode rgmii-id")
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>

Applied, thanks
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: a64-sopine-baseboard: change RGMII mode to TXID
Date: Thu, 10 Jun 2021 14:52:09 +0200	[thread overview]
Message-ID: <20210610125209.glrd2qlpwqiha24h@gilmour> (raw)
In-Reply-To: <20210609083843.463750-1-icenowy@aosc.io>


[-- Attachment #1.1: Type: text/plain, Size: 847 bytes --]

On Wed, Jun 09, 2021 at 04:38:43PM +0800, Icenowy Zheng wrote:
> Although the schematics of Pine A64-LTS and SoPine Baseboard shows both
> the RX and TX internal delay are enabled, they're using the same broken
> RTL8211E chip batch with Pine A64+, so they should use TXID instead, not
> ID.
> 
> In addition, by checking the real components soldered on both a SoPine
> Baseboard and a Pine A64-LTS, RX delay is not enabled (GR69 soldered and
> GR70 NC) despite the schematics says it's enabled. It's a common
> situation for Pine64 boards that the NC information on schematics is not
> the same with the board.
> 
> So the RGMII delay mode should be TXID on these boards.
> 
> Fixes: c2b111e59a7b ("arm64: dts: allwinner: A64 Sopine: phy-mode rgmii-id")
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>

Applied, thanks
Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-10 12:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09  8:38 [PATCH] arm64: dts: allwinner: a64-sopine-baseboard: change RGMII mode to TXID Icenowy Zheng
2021-06-09  8:38 ` Icenowy Zheng
2021-06-10 12:52 ` Maxime Ripard [this message]
2021-06-10 12:52   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210610125209.glrd2qlpwqiha24h@gilmour \
    --to=maxime@cerno.tech \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=wens@csie.org \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.