From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2727AC48BDF for ; Thu, 10 Jun 2021 15:52:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05D6A613CB for ; Thu, 10 Jun 2021 15:52:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231712AbhFJPy1 (ORCPT ); Thu, 10 Jun 2021 11:54:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231356AbhFJPyZ (ORCPT ); Thu, 10 Jun 2021 11:54:25 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99E2EC061760 for ; Thu, 10 Jun 2021 08:52:29 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id pi6-20020a17090b1e46b029015cec51d7cdso4092970pjb.5 for ; Thu, 10 Jun 2021 08:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KX8l2w0IMtRC5c6qHNvl0KgU7tvOhrSsL7RNXq9bR+4=; b=xlK80h3lCnAZasvGDJUY/22RvUNUYrnQIILihwWn1jtnVzkFjdirmA1C2IX0aBZUur QYzyZ6sahO6KYHSSVu5oUKyGhNxIDm11Xkcmtd+RHYFQmbw+Su+q/fFbP61HigCus8GR aGV2g125VmsYTBRXgqwHMdUOs2AtnSZlq8QWMc7hDweLvEDBRCWouCbot+Pd6/4Kg5Zq OgaWas7x7iPk/N3sK/U9so2cgt0mY5eAjW2+HqaYpnKms9NerMwg9xD/dl+iRyOJs6/g 3+k+0b1elDas4zCXZjg0VWsXyPFU9ExIfkiOYhYmFOMMWzZj9seZvFT9i5nr4T+teElt Q3Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KX8l2w0IMtRC5c6qHNvl0KgU7tvOhrSsL7RNXq9bR+4=; b=XpKZs9kK5eLHon+usy9R1oNLvV6x3uc5uzdX0BhGIe3ad2u7iM9SsenyaT2UUcsNTQ TXSyAgL1PWH2ooWzSzOIL3v0qHJFYMZ/G9DoAftRPJ53IXbJ24UYwjN5lj2BKIQ4trbR Jkeis6xEENviAvTDQxGR1KR+M8H2FlFigTY8n+a4gO7/JjZ98jxH4DH9TIorsTitqn8R 8uUW2iq0sWxvhSHdzB5wQovHXgMmnSKfPGpfNflEcQpKwuq/vqeNgJc5pWjIqmlwRU6J dO+C2e9nRWKfkGap/ioZFk+Vn+T6jh7mXLWF1Jp8kLX2Fl4vIcjGSBRwcMrVGvG2Gm9E 4Veg== X-Gm-Message-State: AOAM530vAzWbqbqNZV/ddIezD2O+O4Z31K3MF/sHwEXG6eU7LFhaaFFF DFewd+u1U+mTe/AZDC6b5hS5PA== X-Google-Smtp-Source: ABdhPJyYXLEX++QpbNBN6pTxAJDenevuet6zyqh/LlCGRu22lr5FnmL6Dy8Mn7kk/ZRFzA+tId9r7g== X-Received: by 2002:a17:902:db0b:b029:111:7dac:2789 with SMTP id m11-20020a170902db0bb02901117dac2789mr5373146plx.45.1623340349069; Thu, 10 Jun 2021 08:52:29 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id q2sm3038962pje.50.2021.06.10.08.52.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 08:52:28 -0700 (PDT) Date: Thu, 10 Jun 2021 09:52:25 -0600 From: Mathieu Poirier To: James Clark Cc: acme@kernel.org, coresight@lists.linaro.org, leo.yan@linaro.org, al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org, suzuki.poulose@arm.com, anshuman.khandual@arm.com, Mike Leach , John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/1] perf cs-etm: Split Coresight decode by aux records Message-ID: <20210610155225.GA34238@p14s> References: <20210610103647.7038-1-james.clark@arm.com> <20210610103647.7038-2-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 10, 2021 at 04:55:27PM +0300, James Clark wrote: > > > On 10/06/2021 13:36, James Clark wrote: > > + return auxtrace_queues__add_event(&etm->queues, > > + session, > > + &auxtrace_fragment, > > + file_offset, > > + NULL); > > There's one more indentation error here that I will fix in the next set. Yes, this one needs fixing and while at it you probably want to fix the stacking as well: return auxtrace_queues__add_event(&etm->queues, session, &auxtrace_fragment, file_offset, NULL); Also look for "deccoding" at the end of the second paragraph in the changelog. Thanks, Mathieu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D617C47094 for ; Thu, 10 Jun 2021 15:57:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3250B613D0 for ; Thu, 10 Jun 2021 15:57:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3250B613D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6q6WjSWW/0kZ0S2pcFl7m1Yjw1GJDqSdKTIbeSuTbuY=; b=fjGxJIjpZhROjB Gi8LoSfTmyOMIeuMNsKG3dwGVFWI3KwOdVCcQ3sdtOfI7eYI9NuK+sWuv8ofHmsNxouYy4vpiWgXO mwP1qOTzRMCIuRWwKANxQ/kLuvDlEfed5gxCh18m8zfCMKZLBEoMGnhjx0q2waoqcTyvbJXwG54AC Rzn1rG3dGSPtvCJnqOoJjDO8/vQE5IJGn4Bl9nWr2FhQOvyGRdJmDnI1YgU0zrXwZ4NZlED5DZdJi lHc9DhbJ0l4yt4eEjEv0MAFAx6evr1XVpsObt0D7OzNtbJmabEaVJlvWONj3l/XHrSVxlbbUMhNGe EFgE0Y9EC5l6V3eriVVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrN1i-001ViW-9k; Thu, 10 Jun 2021 15:55:28 +0000 Received: from mail-pl1-f176.google.com ([209.85.214.176]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrMzr-001Upu-SB for linux-arm-kernel@lists.infradead.org; Thu, 10 Jun 2021 15:53:33 +0000 Received: by mail-pl1-f176.google.com with SMTP id e7so1248273plj.7 for ; Thu, 10 Jun 2021 08:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KX8l2w0IMtRC5c6qHNvl0KgU7tvOhrSsL7RNXq9bR+4=; b=xlK80h3lCnAZasvGDJUY/22RvUNUYrnQIILihwWn1jtnVzkFjdirmA1C2IX0aBZUur QYzyZ6sahO6KYHSSVu5oUKyGhNxIDm11Xkcmtd+RHYFQmbw+Su+q/fFbP61HigCus8GR aGV2g125VmsYTBRXgqwHMdUOs2AtnSZlq8QWMc7hDweLvEDBRCWouCbot+Pd6/4Kg5Zq OgaWas7x7iPk/N3sK/U9so2cgt0mY5eAjW2+HqaYpnKms9NerMwg9xD/dl+iRyOJs6/g 3+k+0b1elDas4zCXZjg0VWsXyPFU9ExIfkiOYhYmFOMMWzZj9seZvFT9i5nr4T+teElt Q3Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KX8l2w0IMtRC5c6qHNvl0KgU7tvOhrSsL7RNXq9bR+4=; b=LNoBXxcjp49sj4y/p3e21FgxY2EsUOT6PVMuYiUQv5fLwb41nbGNF0etMxvzkWBPod C8T79hoj5yYRZ8tvKBku1ahM2G1m8fb0bRGkToJg2b1Db5qVpI9zJm22mT61Zwhl6jR5 pWc6RfTnbWtOdvMW0keumb1MpvmdoYjGv9lO30LvPYxYsGdD6/GtnKJo6uybcddtJOQR 6UQGsnWjGMW65+gADXZtIrJ6WLwpPBrKHEWImzrN2PvZD4w1R7umHEYLjXl9eNXGdW/d ZaCMZvvWDKfyTIdVr0+7hqiFjR3nGUO2Z4Z/ZGop9xo1/n6y7h2vuduTaXautIlCHoWQ U+CQ== X-Gm-Message-State: AOAM531xkl6GuZQfJxHbg61rAex85nkQg2J1gZituZWHlFLUopCnYrh7 C1+Co5VukIunyrKoTOsiqljT/g== X-Google-Smtp-Source: ABdhPJyYXLEX++QpbNBN6pTxAJDenevuet6zyqh/LlCGRu22lr5FnmL6Dy8Mn7kk/ZRFzA+tId9r7g== X-Received: by 2002:a17:902:db0b:b029:111:7dac:2789 with SMTP id m11-20020a170902db0bb02901117dac2789mr5373146plx.45.1623340349069; Thu, 10 Jun 2021 08:52:29 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id q2sm3038962pje.50.2021.06.10.08.52.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 08:52:28 -0700 (PDT) Date: Thu, 10 Jun 2021 09:52:25 -0600 From: Mathieu Poirier To: James Clark Cc: acme@kernel.org, coresight@lists.linaro.org, leo.yan@linaro.org, al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org, suzuki.poulose@arm.com, anshuman.khandual@arm.com, Mike Leach , John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/1] perf cs-etm: Split Coresight decode by aux records Message-ID: <20210610155225.GA34238@p14s> References: <20210610103647.7038-1-james.clark@arm.com> <20210610103647.7038-2-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210610_085331_966334_C3161B56 X-CRM114-Status: GOOD ( 10.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 10, 2021 at 04:55:27PM +0300, James Clark wrote: > > > On 10/06/2021 13:36, James Clark wrote: > > + return auxtrace_queues__add_event(&etm->queues, > > + session, > > + &auxtrace_fragment, > > + file_offset, > > + NULL); > > There's one more indentation error here that I will fix in the next set. Yes, this one needs fixing and while at it you probably want to fix the stacking as well: return auxtrace_queues__add_event(&etm->queues, session, &auxtrace_fragment, file_offset, NULL); Also look for "deccoding" at the end of the second paragraph in the changelog. Thanks, Mathieu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel