From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B927BC47094 for ; Thu, 10 Jun 2021 14:29:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93C62610A5 for ; Thu, 10 Jun 2021 14:29:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93C62610A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nic.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5119382EAC; Thu, 10 Jun 2021 16:29:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="DGXuIYrT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5378F82EBB; Thu, 10 Jun 2021 16:29:05 +0200 (CEST) Received: from mail.nic.cz (lists.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3F93182CBE for ; Thu, 10 Jun 2021 16:29:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPSA id 0D2EA140AA1; Thu, 10 Jun 2021 16:29:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1623335341; bh=rKOmqEKwt+MSXHd4gZrjNBdFZFsdxm5pjG47dmanAXI=; h=Date:From:To; b=DGXuIYrTDnBFdyC+Yty8T66+kkIiuhImJo4S5QXynFrWcpZXMSJ5uHi/lPYPK834b hztPW1vnbzl16dwNhXaLWcHINg8lIQh0JPM6U1slPfDtTdz5hLIRlWqf+Vg5Z9M4q8 F3EpsyIBYTZUrNPtSFuYkTvbg98uGQTGGmcSUuoU= Date: Thu, 10 Jun 2021 16:28:59 +0200 From: Marek Behun To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH u-boot-marvell v2 5/6] arm: mvebu: dts: turris_mox: add nodes for SPI NOR partitions Message-ID: <20210610162859.4ec5cf7a@thinkpad> In-Reply-To: <20210610140705.y42ghe3z624ady7n@pali> References: <20210607143451.5343-1-marek.behun@nic.cz> <20210607143451.5343-6-marek.behun@nic.cz> <20210608095131.bczcdi632j6fhvds@pali> <86412efd-1d6b-3c54-e83b-aab5ed4355ba@denx.de> <20210610140705.y42ghe3z624ady7n@pali> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On Thu, 10 Jun 2021 16:07:05 +0200 Pali Roh=C3=A1r wrote: > On Thursday 10 June 2021 07:12:53 Stefan Roese wrote: > > Hi Pali, > >=20 > > On 08.06.21 11:51, Pali Roh=C3=A1r wrote: =20 > > > On Monday 07 June 2021 16:34:50 Marek Beh=C3=BAn wrote: =20 > > > > Add nodes for SPI NOR partitions to the device tree of Turris MOX, = as > > > > are in Linux' device tree. =20 > > >=20 > > > This patch is not needed (for now) as U-Boot cannot parse SPI NOR > > > partitions from DT yet. U-Boot for SPI NOR currently supports specify= ing > > > partitions only via CONFIG_MTDPARTS_DEFAULT compile option. =20 > >=20 > > But do you agree that this patch "does not hurt"? I'm asking to check, > > if I should include this patch in a potential pull request. =20 >=20 > Yes. This does not hurt and currently does nothing. And after patches > for SPI NOR parsing are merged then this patch can be useful. >=20 > So if you are fine with merging which which currently does noting and in > future is useful then there is no problem with it. Moreover this definition is also in kernel's DTS. I am going to try to work on the U-Boot's A3720 comphy driver so that we can completely align U-Boot's A3720 DTS files with kernel's. Marek