All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Albrecht <jonathan.albrecht@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: ruixin.bao@ibm.com, qemu-s390x@nongnu.org,
	Jonathan Albrecht <jonathan.albrecht@linux.vnet.ibm.com>,
	Laurent Vivier <laurent@vivier.eu>,
	jonathan.albrecht@ibm.com
Subject: [PATCH RFC 0/1] linux-user/s390x: save/restore condition code state during signal handling
Date: Thu, 10 Jun 2021 14:58:22 -0400	[thread overview]
Message-ID: <20210610185823.14817-1-jonathan.albrecht@linux.vnet.ibm.com> (raw)

Peter Bao <ruixin.bao@ibm.com> and I have been looking at some issues with
qemu user mode x86_64 host/s390x guest when running go1.14+ executables.
From the qemu cpu traces, it looks like the condition code is not restored
after a signal handler is run. This affects go1.14+ because it uses signals
heavily to implement the async preempt feature in the goroutine scheduler
that was added in go1.14.

This patch tries save and restore the condition code related fields when
handling a signal. We're submitting it as an RFC since we're new to qemu and
not sure if this is s390x specific. We have some C code (s390x specific)
that reproduces the issue and can try to add it as a unit test.

Jonathan Albrecht (1):
  linux-user/s390x: save/restore condition code state during signal
    handling

 linux-user/s390x/signal.c | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

-- 
2.31.1



             reply	other threads:[~2021-06-10 21:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10 18:58 Jonathan Albrecht [this message]
2021-06-10 18:58 ` [PATCH RFC 1/1] linux-user/s390x: save/restore condition code state during signal handling Jonathan Albrecht
2021-06-11 15:18   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210610185823.14817-1-jonathan.albrecht@linux.vnet.ibm.com \
    --to=jonathan.albrecht@linux.vnet.ibm.com \
    --cc=jonathan.albrecht@ibm.com \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=ruixin.bao@ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.