From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 292E2C48BD1 for ; Fri, 11 Jun 2021 06:39:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D89E61278 for ; Fri, 11 Jun 2021 06:39:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231151AbhFKGlq (ORCPT ); Fri, 11 Jun 2021 02:41:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:58542 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbhFKGlo (ORCPT ); Fri, 11 Jun 2021 02:41:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3444E61285; Fri, 11 Jun 2021 06:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623393587; bh=7XTJ+zxV7skHRXnn2pnhP4tpSNvduxlBN3JkyMlwBgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NAO1IuG6hK8hwDDHT0Ud00c5ysdRvABJHZ99YlSCUvVOUlwPbjqgkiuaP4W9qKLwT aRFs9YqvRG0uh+ehpZ9FgTKhcjj1XmBdL+A1pRYIeksWrnfqk/N4svJ4+YHFdHmHdI FCrBn3CYB6yDKtexafaz5KrE1FkbWmPDWt29Y1xi/fb6ciYLsJWGI8lf0tajQYWimW P9giwdVCbJxFknufVrsmKMWKaOv7gARyiApeQhr4PN5LYdcfNlRq8vdjKInbEmghFz 8SjAUG+m3nVqMywkP8Ofii/4dQ/JQyWQ5E9KQ0iD1ZpnQjiV+7F/PxCJcMd+B1dlXe BKszMR4ZlRexA== Date: Fri, 11 Jun 2021 12:09:40 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM: dts: owl-s500-roseapplepi: Add ethernet support Message-ID: <20210611063940.GD6950@thinkpad> References: <632e12c445ced7f10e6d7240162484ae5afc148e.1623358117.git.cristian.ciocaltea@gmail.com> <20210611055606.GB6950@thinkpad> <20210611063147.GA1520454@BV030612LT> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210611063147.GA1520454@BV030612LT> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 11, 2021 at 09:31:47AM +0300, Cristian Ciocaltea wrote: > On Fri, Jun 11, 2021 at 11:26:06AM +0530, Manivannan Sadhasivam wrote: > > On Fri, Jun 11, 2021 at 12:09:22AM +0300, Cristian Ciocaltea wrote: > > > Add pinctrl configuration for enabling the Ethernet MAC on RoseapplePi > > > SBC. Additionally, provide the necessary properties for the generic S500 > > > ethernet node in order to setup PHY and MDIO. > > > > > > Signed-off-by: Cristian Ciocaltea > > > --- > > > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 56 ++++++++++++++++++++++ > > > 1 file changed, 56 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > > > index b8c5db2344aa..bffabc7eaa50 100644 > > > --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts > > > +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts [...] > > > + mdio { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + reset-gpios = <&pinctrl 88 GPIO_ACTIVE_LOW>; /* GPIOC24 */ > > > + reset-delay-us = <10000>; > > > + reset-post-delay-us = <150000>; > > > > reset-* properties belong to "ethernet-phy" node. Also, while adding new nodes > > please run the dtbs_check and try to address the warnings. > > The properties are those described in Documentation/devicetree/bindings/net/mdio.yaml Do you mean the reset properties are applicable for all PHYs in this SoC? > The dtbs_check doesn't report any issues in my case, usually this > happens when dtschema is not updated to the latest version. I always > run the following command after rebasing to a new kernel version: > > pip3 install --upgrade dtschema > That's good! Thanks, Mani > Thanks for the review, > Cristi > > > Thanks, > > Mani > > > > > + > > > + eth_phy: ethernet-phy@3 { > > > + reg = <0x3>; > > > + max-speed = <100>; > > > + interrupt-parent = <&sirq>; > > > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > > > + }; > > > + }; > > > +}; > > > + > > > &twd_timer { > > > status = "okay"; > > > }; > > > -- > > > 2.32.0 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 573FAC4743D for ; Fri, 11 Jun 2021 06:49:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1832761364 for ; Fri, 11 Jun 2021 06:49:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1832761364 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7gsmcnQteDr15ietY1z5I2HN/IoZvDNC1CwBrYMCcIc=; b=ImSB1DcyhWbtEg QqA4TaYmN3skDnMyYgb/YNeFb9i+QIogoP/X9vo9YMw1637FO/oiftlIqgQxXF+TxZtbvA9BO7iqy PEB8DpH1jc2tGfckHkNf0aawGz3Z1dAuDXmj4athN+112Aoj2uZjyi5p7LXBfNA4ERo3NJ/4HWYfj uJf0xin2n7Mokgg63tI+qKb+uucWiGSLsCrCYTPmGl4mhOGRy56XoWxQBsc9f3ySjt67tZtsr7kJT rq5YwTFAnTc5JPoulVcBNAcJsZFEA7TFKD1o9LjHiFfZ+EtT8XDHzoUFhfgRfvJ7wveip4xbFr+mh +vS5fjrDwcHbZB7QzwSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lraxF-003xcg-ER; Fri, 11 Jun 2021 06:47:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrapX-003vG1-R5; Fri, 11 Jun 2021 06:39:49 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3444E61285; Fri, 11 Jun 2021 06:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623393587; bh=7XTJ+zxV7skHRXnn2pnhP4tpSNvduxlBN3JkyMlwBgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NAO1IuG6hK8hwDDHT0Ud00c5ysdRvABJHZ99YlSCUvVOUlwPbjqgkiuaP4W9qKLwT aRFs9YqvRG0uh+ehpZ9FgTKhcjj1XmBdL+A1pRYIeksWrnfqk/N4svJ4+YHFdHmHdI FCrBn3CYB6yDKtexafaz5KrE1FkbWmPDWt29Y1xi/fb6ciYLsJWGI8lf0tajQYWimW P9giwdVCbJxFknufVrsmKMWKaOv7gARyiApeQhr4PN5LYdcfNlRq8vdjKInbEmghFz 8SjAUG+m3nVqMywkP8Ofii/4dQ/JQyWQ5E9KQ0iD1ZpnQjiV+7F/PxCJcMd+B1dlXe BKszMR4ZlRexA== Date: Fri, 11 Jun 2021 12:09:40 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM: dts: owl-s500-roseapplepi: Add ethernet support Message-ID: <20210611063940.GD6950@thinkpad> References: <632e12c445ced7f10e6d7240162484ae5afc148e.1623358117.git.cristian.ciocaltea@gmail.com> <20210611055606.GB6950@thinkpad> <20210611063147.GA1520454@BV030612LT> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210611063147.GA1520454@BV030612LT> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210610_233947_952675_D3C60332 X-CRM114-Status: GOOD ( 21.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 11, 2021 at 09:31:47AM +0300, Cristian Ciocaltea wrote: > On Fri, Jun 11, 2021 at 11:26:06AM +0530, Manivannan Sadhasivam wrote: > > On Fri, Jun 11, 2021 at 12:09:22AM +0300, Cristian Ciocaltea wrote: > > > Add pinctrl configuration for enabling the Ethernet MAC on RoseapplePi > > > SBC. Additionally, provide the necessary properties for the generic S500 > > > ethernet node in order to setup PHY and MDIO. > > > > > > Signed-off-by: Cristian Ciocaltea > > > --- > > > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 56 ++++++++++++++++++++++ > > > 1 file changed, 56 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > > > index b8c5db2344aa..bffabc7eaa50 100644 > > > --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts > > > +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts [...] > > > + mdio { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + reset-gpios = <&pinctrl 88 GPIO_ACTIVE_LOW>; /* GPIOC24 */ > > > + reset-delay-us = <10000>; > > > + reset-post-delay-us = <150000>; > > > > reset-* properties belong to "ethernet-phy" node. Also, while adding new nodes > > please run the dtbs_check and try to address the warnings. > > The properties are those described in Documentation/devicetree/bindings/net/mdio.yaml Do you mean the reset properties are applicable for all PHYs in this SoC? > The dtbs_check doesn't report any issues in my case, usually this > happens when dtschema is not updated to the latest version. I always > run the following command after rebasing to a new kernel version: > > pip3 install --upgrade dtschema > That's good! Thanks, Mani > Thanks for the review, > Cristi > > > Thanks, > > Mani > > > > > + > > > + eth_phy: ethernet-phy@3 { > > > + reg = <0x3>; > > > + max-speed = <100>; > > > + interrupt-parent = <&sirq>; > > > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > > > + }; > > > + }; > > > +}; > > > + > > > &twd_timer { > > > status = "okay"; > > > }; > > > -- > > > 2.32.0 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel